Extract common X.509 OID constants to components [chromium/src : main]
0 views
Skip to first unread message
Tian Ye (Gerrit)
May 21, 2026, 4:12:05 AM (11 days ago) May 21
to Filipa Senra, Matt Mueller, chromium...@chromium.org, net-r...@chromium.org
Attention needed from Filipa Senra and Matt Mueller
Tian Ye added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Tian Ye . unresolved
Hi mattm@, I have separated the changes to the OID constants from the original CL. Please review it for me. Thank you.
Related details
Attention is currently required from:
- Filipa Senra
- Matt Mueller
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Filipa Senra (Gerrit)
May 21, 2026, 4:28:41 AM (11 days ago) May 21
to Tian Ye, Matt Mueller, chromium...@chromium.org, net-r...@chromium.org
Attention needed from Matt Mueller and Tian Ye
Filipa Senra added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Filipa Senra . resolved
The files are owned by Matt. So I will leave the review to him. I can be the reviewer for the UI related changes where I am the owner of the files.
Related details
Attention is currently required from:
- Matt Mueller
- Tian Ye
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tian Ye (Gerrit)
May 21, 2026, 7:35:30 AM (11 days ago) May 21
to Filipa Senra, Matt Mueller, chromium...@chromium.org, net-r...@chromium.org
Attention needed from Filipa Senra and Matt Mueller
Tian Ye added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Filipa Senra . resolved
The files are owned by Matt. So I will leave the review to him. I can be the reviewer for the UI related changes where I am the owner of the files.
Tian Ye
Okay. I added you as a reviewer because I needed two reviewers' approval, but I could only find Matt. So you can review it once Matt approves it.
Related details
Attention is currently required from:
- Filipa Senra
- Matt Mueller
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tian Ye (Gerrit)
May 26, 2026, 10:40:54 PM (5 days ago) May 26
to Filipa Senra, Matt Mueller, chromium...@chromium.org, net-r...@chromium.org
Attention needed from Filipa Senra and Matt Mueller
Tian Ye added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Matt Mueller (Gerrit)
May 28, 2026, 9:40:05 PM (3 days ago) May 28
to Tian Ye, Matt Mueller, Filipa Senra, chromium...@chromium.org, net-r...@chromium.org
Attention needed from Filipa Senra and Tian Ye
Matt Mueller voted and added 2 comments![]( "Open in Gerrit")
Votes added by Matt Mueller
| Code-Review | +1 |
2 comments
Patchset-level comments
Tian Ye . resolved
Hi @ma...@chromium.org, Please help review this CL. Thanks.
Matt Mueller
Acknowledged
Tian Ye . resolved
Hi mattm@, I have separated the changes to the OID constants from the original CL. Please review it for me. Thank you.
Attention is currently required from:
- Filipa Senra
- Tian Ye
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Filipa Senra (Gerrit)
May 29, 2026, 4:26:11 AM (3 days ago) May 29
to Tian Ye, Matt Mueller, chromium...@chromium.org, net-r...@chromium.org
Attention needed from Tian Ye
Filipa Senra voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Tian Ye
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tian Ye (Gerrit)
May 31, 2026, 10:51:34 PM (2 hours ago) May 31
to Filipa Senra, Matt Mueller, chromium...@chromium.org, net-r...@chromium.org
Tian Ye voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 31, 2026, 11:42:27 PM (1 hour ago) May 31
to Tian Ye, Filipa Senra, Matt Mueller, chromium...@chromium.org, net-r...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Extract common X.509 OID constants to components
Extract shared X.509 OID byte-array constants to a new components file
so that they can be shared across platforms.
Bug: None
Change-Id: I9aea7235506db866f43d88bcc1dd6bad92af338b
Reviewed-by: Matt Mueller <ma...@chromium.org>
Reviewed-by: Filipa Senra <fse...@google.com>
Commit-Queue: Tian Ye <tia...@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1639152}
Files:
- M chrome/common/net/x509_certificate_model.cc
- M components/certificate_model/BUILD.gn
- A components/certificate_model/x509_certificate_constants.h
- M components/certificate_model/x509_certificate_model_base.h
Change size: L
Delta: 4 files changed, 145 insertions(+), 126 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Filipa Senra, +1 by Matt Mueller
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages