[Memory] Add promo bubble header Lottie resource [chromium/src : main]
0 views
Skip to first unread message
Maryia Mankevich (Gerrit)
Apr 9, 2026, 2:57:47 PM (4 days ago) Apr 9
to Mitsuru Oshima, chromium...@chromium.org, AyeAye, oshima...@chromium.org
Attention needed from Mitsuru Oshima
Maryia Mankevich added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 38 (Latest):
Maryia Mankevich . resolved
Hi Mitsuru.
Could you please PTAL at this CL for an OWNERS approval on chrome/app/theme/?
We are adding a new Lottie JSON file (at_memory_promo_header.json) to be used as the static header graphic for a new Autofill "At-Memory" promo bubble. (We are using a Lottie file here to support the multicolor/dynamic styling required by the Figma design).
Bubble screenshot: https://screenshot.googleplex.com/9Qtx52VBM3waeb3.
Note: The JSON binary size is ~53 KB*.
Thanks!
Related details
Attention is currently required from:
- Mitsuru Oshima
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mitsuru Oshima (Gerrit)
Apr 9, 2026, 4:34:07 PM (4 days ago) Apr 9
to Maryia Mankevich, chromium...@chromium.org, AyeAye, oshima...@chromium.org
Attention needed from Maryia Mankevich
Mitsuru Oshima added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Mitsuru Oshima . resolved
lottie resources for chrome/browser are currently defind in chrome/browesr/browser_rsources.grd and placed under chrome/browser/resources/.
Shouldn't this follow the same pattern?
Related details
Attention is currently required from:
- Maryia Mankevich
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maryia Mankevich (Gerrit)
Apr 10, 2026, 7:24:48 AM (3 days ago) Apr 10
to Mitsuru Oshima, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, oshima...@chromium.org
Attention needed from Mitsuru Oshima
Maryia Mankevich added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Mitsuru Oshima . resolved
lottie resources for chrome/browser are currently defind in chrome/browesr/browser_rsources.grd and placed under chrome/browser/resources/.
Shouldn't this follow the same pattern?
Maryia Mankevich
Good catch, that makes perfect sense. Thanks! I applied that pattern. PTAL
Related details
Attention is currently required from:
- Mitsuru Oshima
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mitsuru Oshima (Gerrit)
Apr 10, 2026, 11:25:47 AM (3 days ago) Apr 10
to Maryia Mankevich, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, oshima...@chromium.org
Attention needed from Maryia Mankevich
Mitsuru Oshima voted and added 2 comments![]( "Open in Gerrit")
Votes added by Mitsuru Oshima
| Code-Review | +1 |
2 comments
Patchset-level comments
File-level comment, Patchset 41 (Latest):
Mitsuru Oshima . resolved
I'm not the owner of these file/directory, so you need another reviewer.
File chrome/browser/resources/autofill/autofill_at_memory_promo_header_opted_in.json
Related details
Attention is currently required from:
- Maryia Mankevich
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maryia Mankevich (Gerrit)
Apr 10, 2026, 2:42:21 PM (3 days ago) Apr 10
to Mitsuru Oshima, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, oshima...@chromium.org
Maryia Mankevich added 1 comment![]( "Open in Gerrit")
File chrome/browser/resources/autofill/autofill_at_memory_promo_header_opted_in.json
nit: no need to pretty print lottie JSON.
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maryia Mankevich (Gerrit)
Apr 10, 2026, 2:43:06 PM (3 days ago) Apr 10
to Mitsuru Oshima, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, oshima...@chromium.org
Maryia Mankevich added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 42 (Latest):
Maryia Mankevich . resolved
Hi Ted,
could you please take a look?
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maryia Mankevich (Gerrit)
Apr 10, 2026, 2:46:15 PM (3 days ago) Apr 10
to Ted Choc, Mitsuru Oshima, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, oshima...@chromium.org
Attention needed from Ted Choc
Maryia Mankevich added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Ted Choc
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ted Choc (Gerrit)
Apr 10, 2026, 4:35:49 PM (3 days ago) Apr 10
to Maryia Mankevich, Mitsuru Oshima, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, oshima...@chromium.org
Attention needed from Maryia Mankevich
Ted Choc voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Maryia Mankevich
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maryia Mankevich (Gerrit)
6:47 AM (2 hours ago) 6:47 AM
to Ted Choc, Mitsuru Oshima, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, oshima...@chromium.org
Maryia Mankevich added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maryia Mankevich (Gerrit)
6:47 AM (2 hours ago) 6:47 AM
to Ted Choc, Mitsuru Oshima, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, oshima...@chromium.org
Maryia Mankevich voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
7:41 AM (1 hour ago) 7:41 AM
to Maryia Mankevich, Ted Choc, Mitsuru Oshima, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, oshima...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Memory] Add promo bubble header Lottie resource
This CL adds the Lottie animation JSON for the At-Memory promo
bubble header and defines it in theme_resources.grd.
Bubble screenshot:
https://screenshot.googleplex.com/9Qtx52VBM3waeb3.
Bug: 494131189
Change-Id: Iff128b9b1775a6da4a367c770c5885da153e453e
Reviewed-by: Mitsuru Oshima <osh...@chromium.org>
Reviewed-by: Ted Choc <ted...@chromium.org>
Commit-Queue: Maryia Mankevich <mma...@google.com>
Cr-Commit-Position: refs/heads/main@{#1613625}
Files:
- M chrome/browser/browser_resources.grd
- A chrome/browser/resources/autofill/autofill_at_memory_promo_header_opted_in.json
Change size: XS
Delta: 2 files changed, 2 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ted Choc, +1 by Mitsuru Oshima
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages