monitoring: better handling for resolved groups [infra/luci/luci-go : main]
0 views
Skip to first unread message
Matthew Warton (Gerrit)
Sep 3, 2025, 3:14:52 AM (5 days ago) Sep 3
to Mostafa Draz, chromium...@chromium.org, chops-tfs-t...@google.com, infra-revi...@chromium.org
Attention needed from Mostafa Draz
Matthew Warton voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Mostafa Draz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mostafa Draz (Gerrit)
Sep 4, 2025, 1:47:32 AM (4 days ago) Sep 4
to Matthew Warton, LUCI CQ, chromium...@chromium.org, chops-tfs-t...@google.com, infra-revi...@chromium.org
Attention needed from Matthew Warton
Mostafa Draz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mostafa Draz
| Code-Review | +1 |
1 comment
File milo/ui/src/monitoringv2/components/alerts/alerts_side_nav.tsx
Line 60, Patchset 1 (Latest):
const [userShowResolved, setUserShowResolved] = useState<boolean | undefined>(Mostafa Draz . unresolved
nit: should this be stored somewhere, perhaps local storage or the url?a
Related details
Attention is currently required from:
- Matthew Warton
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matthew Warton (Gerrit)
Sep 4, 2025, 8:34:46 PM (3 days ago) Sep 4
to Mostafa Draz, LUCI CQ, chromium...@chromium.org, chops-tfs-t...@google.com, infra-revi...@chromium.org
Matthew Warton voted and added 1 comment![]( "Open in Gerrit")
Votes added by Matthew Warton
| Commit-Queue | +2 |
1 comment
File milo/ui/src/monitoringv2/components/alerts/alerts_side_nav.tsx
Line 60, Patchset 1 (Latest):
const [userShowResolved, setUserShowResolved] = useState<boolean | undefined>(Mostafa Draz . resolved
nit: should this be stored somewhere, perhaps local storage or the url?a
Matthew Warton
I want it to default to closed, as I would usually expect it to be a pretty long list, so going to require users to open it manually.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
LUCI CQ (Gerrit)
Sep 4, 2025, 9:11:28 PM (3 days ago) Sep 4
to Matthew Warton, Mostafa Draz, chromium...@chromium.org, chops-tfs-t...@google.com, infra-revi...@chromium.org
LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
monitoring: better handling for resolved groups
In a demo of this page I was confused by a group which had been resolved
but still had a similar seeming alert ungrouped.
This fixes the counts in the sidebar to ensure that resolved groups
correctly reflect the current alert status.
It also hides resolved groups by default to prevent busywork of
gardeners having to delete the groups manually after they are resolved.
(the backend will delete them after 30 days of no updates anyway).
Bug: 439689543
Change-Id: I60d34bda2a671e880b584e65af8422778ffa1504
Commit-Queue: Matthew Warton <mwa...@google.com>
Auto-Submit: Matthew Warton <mwa...@google.com>
Reviewed-by: Mostafa Draz <md...@google.com>
Files:
- M milo/ui/src/monitoringv2/components/alerts/alerts.tsx
- M milo/ui/src/monitoringv2/components/alerts/alerts_side_nav.tsx
- M milo/ui/src/monitoringv2/pages/monitoring_page/context/context.tsx
- M milo/ui/src/monitoringv2/util/alerts.ts
Change size: M
Delta: 4 files changed, 130 insertions(+), 21 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mostafa Draz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages