Dominic Farolino (Gerrit)

unread,

May 21, 2026, 5:53:17 PMMay 21

to Chromium LUCI CQ, Mark Foltz, chromium...@chromium.org, Khushal Sagar, aleventh...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Mark Foltz

Dominic Farolino voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Mark Foltz

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Mark Foltz (Gerrit)

unread,

May 22, 2026, 5:51:55 PMMay 22

to Dominic Farolino, Mark Foltz, Chromium LUCI CQ, chromium...@chromium.org, Khushal Sagar, aleventh...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Dominic Farolino

Mark Foltz voted and added 1 comment

Votes added by Mark Foltz

Code-Review

+1

1 comment

File third_party/blink/web_tests/wpt_internal/webmcp/resources/webmcp-helpers.js

Line 1, Patchset 2 (Latest):async function waitForTool(name) {

Mark Foltz . unresolved

This duplicates waitForTool in third_party/blink/web_tests/fast/webmcp/resources/webmcp-helpers.js ...

Open in Gerrit

Related details

Attention is currently required from:

Dominic Farolino

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Mark Foltz (Gerrit)

unread,

May 22, 2026, 5:53:05 PMMay 22

to Dominic Farolino, Mark Foltz, Chromium LUCI CQ, chromium...@chromium.org, Khushal Sagar, aleventh...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Dominic Farolino

Mark Foltz added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Mark Foltz . resolved

Looks like a rebaseline is needed for a bunch of WPTs because of the deprecation warning 😋

satisfied_requirement

unsatisfied_requirement

open

diffy

Dominic Farolino (Gerrit)

unread,

May 24, 2026, 11:49:51 AMMay 24

to android-bu...@system.gserviceaccount.com, Mark Foltz, Chromium LUCI CQ, chromium...@chromium.org, Khushal Sagar, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, aleventh...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Mark Foltz

Dominic Farolino voted and added 2 comments

Votes added by Dominic Farolino

Commit-Queue

+1

2 comments

Patchset-level comments

File-level comment, Patchset 2:

Mark Foltz . resolved

Looks like a rebaseline is needed for a bunch of WPTs because of the deprecation warning 😋

Dominic Farolino

Think I got them all. We'll see if the bots are happy.

File third_party/blink/web_tests/wpt_internal/webmcp/resources/webmcp-helpers.js

Line 1, Patchset 2:async function waitForTool(name) {

Mark Foltz . resolved

This duplicates waitForTool in third_party/blink/web_tests/fast/webmcp/resources/webmcp-helpers.js ...

Dominic Farolino

Yeah so there is some unfortunate duplication, there are three `webmcp-helpers.js` files:
 - fast/
 - wpt_internal
 - external/wpt

The duplication between the first two is what you're commenting on, but I don't think those two types of tests can share files, so it is what it is. The last two technically don't have to be duplicated, so I've removed `wpt_internal/webmcp/resources/webmcp-helpers.js` and updated the internal WPTs to reference the external file. Seems like a good change.

Open in Gerrit

Related details

Attention is currently required from:

Mark Foltz

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dominic Farolino (Gerrit)

unread,

May 24, 2026, 12:26:30 PMMay 24

to android-bu...@system.gserviceaccount.com, Mark Foltz, Chromium LUCI CQ, chromium...@chromium.org, Khushal Sagar, blink-revi...@chromium.org, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, aleventh...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Mark Foltz

Dominic Farolino voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Mark Foltz

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dominic Farolino (Gerrit)

unread,

May 24, 2026, 12:26:42 PMMay 24

to android-bu...@system.gserviceaccount.com, Mark Foltz, Chromium LUCI CQ, chromium...@chromium.org, Khushal Sagar, blink-revi...@chromium.org, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, aleventh...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Mark Foltz

Dominic Farolino voted Commit-Queue+0

Commit-Queue

+0

satisfied_requirement

unsatisfied_requirement

open

diffy

Dominic Farolino (Gerrit)

unread,

May 24, 2026, 12:39:25 PMMay 24

to android-bu...@system.gserviceaccount.com, Mark Foltz, Chromium LUCI CQ, chromium...@chromium.org, Khushal Sagar, blink-revi...@chromium.org, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, aleventh...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Mark Foltz

Dominic Farolino voted and added 1 comment

Votes added by Dominic Farolino

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Dominic Farolino . resolved

Jetski botched the rebase but I fixed it...

Open in Gerrit

Related details

Attention is currently required from:

Mark Foltz

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dominic Farolino (Gerrit)

unread,

May 24, 2026, 1:15:48 PMMay 24

to android-bu...@system.gserviceaccount.com, Mark Foltz, Chromium LUCI CQ, chromium...@chromium.org, Khushal Sagar, blink-revi...@chromium.org, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, aleventh...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Mark Foltz

Dominic Farolino voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Mark Foltz

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dominic Farolino (Gerrit)

unread,

May 25, 2026, 11:59:42 AMMay 25

to android-bu...@system.gserviceaccount.com, Mark Foltz, Chromium LUCI CQ, chromium...@chromium.org, Khushal Sagar, blink-revi...@chromium.org, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, aleventh...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Mark Foltz

Dominic Farolino voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Mark Foltz

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Mark Foltz (Gerrit)

unread,

May 25, 2026, 8:08:23 PMMay 25

to Dominic Farolino, Mark Foltz, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Khushal Sagar, blink-revi...@chromium.org, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, aleventh...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Dominic Farolino

Mark Foltz voted and added 1 comment

Votes added by Mark Foltz

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 8 (Latest):

Mark Foltz . resolved

Thanks for cleaning up the duplicate helper script 👍

Open in Gerrit

Related details

Attention is currently required from:

Dominic Farolino

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Blink W3C Test Autoroller (Gerrit)

unread,

May 25, 2026, 8:16:12 PMMay 25

to Dominic Farolino, Mark Foltz, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Khushal Sagar, blink-revi...@chromium.org, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, aleventh...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Dominic Farolino

Message from Blink W3C Test Autoroller

Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/60158.

When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

Open in Gerrit

Related details

Attention is currently required from:

Dominic Farolino

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Fr (Gerrit)

unread,

May 26, 2026, 3:13:39 AMMay 26

to Dominic Farolino, Blink W3C Test Autoroller, Mark Foltz, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Khushal Sagar, blink-revi...@chromium.org, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, aleventh...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Dominic Farolino

Fr added 1 comment

File third_party/blink/renderer/core/script_tools/model_context_supplement.cc

Line 80, Patchset 8 (Latest): *document, window->GetTaskRunner(TaskType::kUserInteraction));

Fr . unresolved

I'm officially out of my depth on Chromium's internals here—should we be using `document->GetTaskRunner(...)` instead of using `window`?

Open in Gerrit

Related details

Attention is currently required from:

Dominic Farolino

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dominic Farolino (Gerrit)

unread,

May 26, 2026, 9:35:32 AMMay 26

to Fr, Blink W3C Test Autoroller, Mark Foltz, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Khushal Sagar, blink-revi...@chromium.org, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, aleventh...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Fr

Dominic Farolino voted and added 1 comment

Votes added by Dominic Farolino

Commit-Queue

+2

1 comment

File third_party/blink/renderer/core/script_tools/model_context_supplement.cc

Line 80, Patchset 8: *document, window->GetTaskRunner(TaskType::kUserInteraction));

Fr . resolved

I'm officially out of my depth on Chromium's internals here—should we be using `document->GetTaskRunner(...)` instead of using `window`?

Dominic Farolino

There's no difference in this case. Here we get it the task from LocalDOMWindow, and Document::GetTaskRunner() gets it from its `execution_context_`, which [is a LocalDOMWindow](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/dom/document.h;l=2714-2721;drc=6a3eac9c665a23caf101edf535b0a3479e5f0b2e). Good question though.

Open in Gerrit

Related details

Attention is currently required from:

Fr

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Fr (Gerrit)

unread,

May 26, 2026, 11:10:33 AMMay 26

to Dominic Farolino, Blink W3C Test Autoroller, Mark Foltz, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Khushal Sagar, blink-revi...@chromium.org, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, aleventh...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Dominic Farolino

Fr added 1 comment

File third_party/blink/renderer/core/script_tools/model_context_supplement.cc

Line 80, Patchset 8: *document, window->GetTaskRunner(TaskType::kUserInteraction));

Fr . resolved

I'm officially out of my depth on Chromium's internals here—should we be using `document->GetTaskRunner(...)` instead of using `window`?

Dominic Farolino

There's no difference in this case. Here we get it the task from LocalDOMWindow, and Document::GetTaskRunner() gets it from its `execution_context_`, which [is a LocalDOMWindow](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/dom/document.h;l=2714-2721;drc=6a3eac9c665a23caf101edf535b0a3479e5f0b2e). Good question though.

Fr

Thank you for the pointer! I guess the only advantage then would be that we don't have to check for `document->domWindow()` right?

```cpp
ModelContext* ModelContextSupplement::modelContext() {
  if (!model_context_) {
    Document* document = GetSupplementable();
    CHECK(document);
    model_context_ = MakeGarbageCollected<ModelContext>(*document);
  }
  return model_context_.Get();
}
```

And then update ModelContext constructor to set task_runner_ directly from document?

```cpp
ModelContext::ModelContext(
    Document& document)
    : document_(document),
      task_runner_(document.GetTaskRunner(TaskType::kUserInteraction)),
...
```

Does it make sense as a follow up?

Open in Gerrit

Related details

Attention is currently required from:

Dominic Farolino

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

May 26, 2026, 11:37:32 AMMay 26

to Dominic Farolino, Fr, Blink W3C Test Autoroller, Mark Foltz, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Khushal Sagar, blink-revi...@chromium.org, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, aleventh...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

8 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: third_party/blink/web_tests/external/wpt/webmcp/imperative/exposedTo-invalid-origins.https.html
Insertions: 2, Deletions: 2.

@@ -24,8 +24,8 @@
     {success: true, origin: 'http://localhost:3000'},
   ];
 
-  for (const origin of invalid_origins) {
-    assert_throws_dom('SecurityError', () => {
+  for (const test of test_cases) {
+    const register = () => {
       document.modelContext.registerTool({
         name: 'test_tool_' + Math.random(),
         description: 'Test tool',
```

Change information

Commit message:

WebMCP: Expose document.modelContext

Per https://github.com/webmachinelearning/webmcp/issues/173 and
https://github.com/w3ctag/design-reviews/issues/1231#issuecomment-4502765330,
we're moving `modelContext` to `document` from `navigator`. This CL does
that, but keeps `navigator` exposure around for a bit and dispatches a
console warning when it is used.

This CL also updates all web platform tests to use
`document.modelContext`. There might be other lingering tests elsewhere,
but we can update those when we fully remove the API.

R=mfoltz

Bug: 489045948

Change-Id: I2005719574b78367199c0a87f94f3577b8039f15

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7867800

Reviewed-by: Mark Foltz <mfo...@chromium.org>

Commit-Queue: Dominic Farolino <d...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1636216}

Files:

M android_webview/test/data/web_tests/webexposed/global-interface-listing-expected.txt
M third_party/blink/renderer/core/dom/document.cc
M third_party/blink/renderer/core/frame/local_frame_mojo_handler.cc
M third_party/blink/renderer/core/html/forms/html_form_element.cc
M third_party/blink/renderer/core/inspector/inspector_web_mcp_agent.cc
M third_party/blink/renderer/core/script_tools/model_context_supplement.cc
M third_party/blink/renderer/core/script_tools/model_context_supplement.h
M third_party/blink/renderer/core/script_tools/model_context_supplement.idl
M third_party/blink/renderer/modules/content_extraction/ai_page_content_agent.cc
M third_party/blink/web_tests/external/wpt/webmcp/declarative/getTools-declarative-schema.https.html
M third_party/blink/web_tests/external/wpt/webmcp/declarative/toolchange-on-name-change.https.html
M third_party/blink/web_tests/external/wpt/webmcp/imperative/detached-frame-executeTool.https.html
M third_party/blink/web_tests/external/wpt/webmcp/imperative/detached-frame-getTools.https.html
M third_party/blink/web_tests/external/wpt/webmcp/imperative/detached-frame-registerTool.https.html
M third_party/blink/web_tests/external/wpt/webmcp/imperative/duplicate_tool_registration.https.window.js
M third_party/blink/web_tests/external/wpt/webmcp/imperative/executeTool-abort.https.html
M third_party/blink/web_tests/external/wpt/webmcp/imperative/executeTool-across-trees.https.html
M third_party/blink/web_tests/external/wpt/webmcp/imperative/executeTool-caller-navigate-abort.https.html
M third_party/blink/web_tests/external/wpt/webmcp/imperative/executeTool-invalid-dictionary.https.html
M third_party/blink/web_tests/external/wpt/webmcp/imperative/executeTool-target-detachment.https.html
M third_party/blink/web_tests/external/wpt/webmcp/imperative/executeTool-target-navigation.https.html
M third_party/blink/web_tests/external/wpt/webmcp/imperative/executeTool-unauthorized-origin.https.html
M third_party/blink/web_tests/external/wpt/webmcp/imperative/exposedTo-cross-origin-child.https.html
M third_party/blink/web_tests/external/wpt/webmcp/imperative/exposedTo-defaults-cross-origin.https.html
M third_party/blink/web_tests/external/wpt/webmcp/imperative/exposedTo-defaults-same-origin.https.html
M third_party/blink/web_tests/external/wpt/webmcp/imperative/exposedTo-invalid-origins.https.html
M third_party/blink/web_tests/external/wpt/webmcp/imperative/exposedTo-multiple-children.https.html
M third_party/blink/web_tests/external/wpt/webmcp/imperative/exposedTo-window-open.https.html
M third_party/blink/web_tests/external/wpt/webmcp/imperative/model_context.https.window.js
M third_party/blink/web_tests/external/wpt/webmcp/imperative/non-secure.window.js
M third_party/blink/web_tests/external/wpt/webmcp/imperative/opaque-origin-tools.https.html
M third_party/blink/web_tests/external/wpt/webmcp/imperative/permissions-policy.https.html
M third_party/blink/web_tests/external/wpt/webmcp/imperative/register_tool_invalid_json_schema.https.window.js
M third_party/blink/web_tests/external/wpt/webmcp/imperative/register_tool_name_validation.https.window.js
M third_party/blink/web_tests/external/wpt/webmcp/imperative/register_tool_no_schema.https.window.js
M third_party/blink/web_tests/external/wpt/webmcp/imperative/register_tool_with_empty_annotation.https.window.js
M third_party/blink/web_tests/external/wpt/webmcp/imperative/register_tool_with_schema.https.window.js
M third_party/blink/web_tests/external/wpt/webmcp/imperative/resources/iframe-caller.html
M third_party/blink/web_tests/external/wpt/webmcp/imperative/resources/iframe-register-tool.html
M third_party/blink/web_tests/external/wpt/webmcp/imperative/unregister-during-executeTool.https.html
M third_party/blink/web_tests/external/wpt/webmcp/resources/helpers.js
M third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt
M third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt
M third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt
M third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
M third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
M third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
A third_party/blink/web_tests/fast/webmcp/deprecation_warning.https-expected.txt
A third_party/blink/web_tests/fast/webmcp/deprecation_warning.https.html
M third_party/blink/web_tests/fast/webmcp/execute_tool.html
M third_party/blink/web_tests/fast/webmcp/get_cross_document_script_tool_result.https.html
M third_party/blink/web_tests/fast/webmcp/list_tools.html
M third_party/blink/web_tests/fast/webmcp/resources/webmcp-helpers.js
M third_party/blink/web_tests/fast/webmcp/toolchange.html
M third_party/blink/web_tests/fast/webmcp/usecounter.https.html
M third_party/blink/web_tests/http/tests/worklet/webexposed/global-interface-listing-worklets-expected.txt
M third_party/blink/web_tests/inspector-protocol/webmcp/cancel-invocation.js
M third_party/blink/web_tests/inspector-protocol/webmcp/invoke-tool.js
M third_party/blink/web_tests/inspector-protocol/webmcp/list-tools.js
M third_party/blink/web_tests/inspector-protocol/webmcp/log-tool-calls.js
M third_party/blink/web_tests/virtual/webmcp/inspector-protocol/webmcp/list-tools-expected.txt
M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
M third_party/blink/web_tests/wpt_internal/script_tools/form_removal_submit_crash.https.html
M third_party/blink/web_tests/wpt_internal/webmcp/abort_registration_gc.https.window.js
M third_party/blink/web_tests/wpt_internal/webmcp/custom-element-cease-param.https.html
M third_party/blink/web_tests/wpt_internal/webmcp/custom-element-fill.https.html
M third_party/blink/web_tests/wpt_internal/webmcp/custom-element-invalid-schema.https.html
M third_party/blink/web_tests/wpt_internal/webmcp/execute_tool_change_event.https.html
M third_party/blink/web_tests/wpt_internal/webmcp/execute_tool_submit_from_js.https.html
M third_party/blink/web_tests/wpt_internal/webmcp/initial-about-blank-shared-tool.https.html
D third_party/blink/web_tests/wpt_internal/webmcp/resources/webmcp-helpers.js
M third_party/blink/web_tests/wpt_internal/webmcp/select-multiple-events.https.html

Change size: L

Delta: 72 files changed, 224 insertions(+), 212 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Mark Foltz

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Dominic Farolino (Gerrit)

unread,

May 26, 2026, 11:57:58 AMMay 26

to Chromium LUCI CQ, Fr, Blink W3C Test Autoroller, Mark Foltz, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Khushal Sagar, blink-revi...@chromium.org, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, aleventh...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org

Dominic Farolino added 1 comment

File third_party/blink/renderer/core/script_tools/model_context_supplement.cc

Line 80, Patchset 8: *document, window->GetTaskRunner(TaskType::kUserInteraction));

Fr . resolved

I'm officially out of my depth on Chromium's internals here—should we be using `document->GetTaskRunner(...)` instead of using `window`?

Dominic Farolino

There's no difference in this case. Here we get it the task from LocalDOMWindow, and Document::GetTaskRunner() gets it from its `execution_context_`, which [is a LocalDOMWindow](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/dom/document.h;l=2714-2721;drc=6a3eac9c665a23caf101edf535b0a3479e5f0b2e). Good question though.

Fr

Thank you for the pointer! I guess the only advantage then would be that we don't have to check for `document->domWindow()` right?
```cpp
ModelContext* ModelContextSupplement::modelContext() {
  if (!model_context_) {
    Document* document = GetSupplementable();
    CHECK(document);
    model_context_ = MakeGarbageCollected<ModelContext>(*document);
  }
  return model_context_.Get();
}
```
And then update ModelContext constructor to set task_runner_ directly from document?
```cpp
ModelContext::ModelContext(
    Document& document)
    : document_(document),
      task_runner_(document.GetTaskRunner(TaskType::kUserInteraction)),
...
```
Does it make sense as a follow up?

Dominic Farolino

Seems like a good idea, thanks! I've uploaded https://crrev.com/c/7871892

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Blink W3C Test Autoroller (Gerrit)

unread,

May 26, 2026, 11:55:01 PMMay 26

to Dominic Farolino, Chromium LUCI CQ, Fr, Mark Foltz, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Khushal Sagar, blink-revi...@chromium.org, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, aleventh...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org

Message from Blink W3C Test Autoroller

The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/60158

satisfied_requirement

open

diffy

ثامرy الحربي (Gerrit)‎

unread,

Jul 9, 2026, 9:33:58 PMJul 9

to Dominic Farolino, Chromium LUCI CQ, Fr, Blink W3C Test Autoroller, Mark Foltz, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Khushal Sagar, blink-revi...@chromium.org, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, aleventh...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org

ثامرy الحربي added 1 comment

Patchset-level comments

File-level comment, Patchset 10 (Latest):

ثامرy الحربي . resolved

أم عائشة الحربي
allenri...@gmail.com

satisfied_requirement

open

diffy

Abhinav Vinod (Gerrit)

unread,

12:09 AM (4 hours ago) 12:09 AM

to Dominic Farolino, Chromium LUCI CQ, ثامرy الحربي, Fr, Blink W3C Test Autoroller, Mark Foltz, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Khushal Sagar, blink-revi...@chromium.org, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, aleventh...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org

Abhinav Vinod added 1 comment

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Abhinav Vinod . resolved

THE ui was improved

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

WebMCP: Expose document.modelContext [chromium/src : main]

Dominic Farolino (Gerrit)

Dominic Farolino voted Commit-Queue+1

Related details

Mark Foltz (Gerrit)

Mark Foltz voted and added 1 comment

Votes added by Mark Foltz

1 comment

Related details

Mark Foltz (Gerrit)

Mark Foltz added 1 comment

Dominic Farolino (Gerrit)

Dominic Farolino voted and added 2 comments

Votes added by Dominic Farolino

2 comments

Related details

Dominic Farolino (Gerrit)

Dominic Farolino voted Commit-Queue+1

Related details

Dominic Farolino (Gerrit)

Dominic Farolino voted Commit-Queue+0

Dominic Farolino (Gerrit)

Dominic Farolino voted and added 1 comment

Votes added by Dominic Farolino

1 comment

Related details

Dominic Farolino (Gerrit)

Dominic Farolino voted Commit-Queue+1

Related details

Dominic Farolino (Gerrit)

Dominic Farolino voted Commit-Queue+1

Related details

Mark Foltz (Gerrit)

Mark Foltz voted and added 1 comment

Votes added by Mark Foltz

1 comment

Related details

Blink W3C Test Autoroller (Gerrit)

Message from Blink W3C Test Autoroller

Related details

Fr (Gerrit)

Fr added 1 comment

Related details

Dominic Farolino (Gerrit)

Dominic Farolino voted and added 1 comment

Votes added by Dominic Farolino

1 comment

Related details

Fr (Gerrit)

Fr added 1 comment

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information

Dominic Farolino (Gerrit)

Dominic Farolino added 1 comment

Related details

Blink W3C Test Autoroller (Gerrit)

Message from Blink W3C Test Autoroller

ثامرy الحربي (Gerrit)‎

ثامرy الحربي added 1 comment

Abhinav Vinod (Gerrit)

Abhinav Vinod added 1 comment

Related details