Implement IsEntityDataValid for WebApkSyncBridge [chromium/src : main]

0 views
Skip to first unread message

Marc Treib (Gerrit)

unread,
Sep 25, 2025, 9:32:09 AM (23 hours ago) Sep 25
to Marc Treib, Chromium Sync Reviews, chromium...@chromium.org, Chromium LUCI CQ, webapks-...@chromium.org
Attention needed from Chromium Sync Reviews

Marc Treib voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Chromium Sync Reviews
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9fe959959ba3b297d9e3cfd83dccace4974e40c2
Gerrit-Change-Number: 6983605
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Treib <tr...@chromium.org>
Gerrit-Reviewer: Chromium Sync Reviews <chromium-s...@google.com>
Gerrit-Reviewer: Marc Treib <tr...@chromium.org>
Gerrit-Attention: Chromium Sync Reviews <chromium-s...@google.com>
Gerrit-Comment-Date: Thu, 25 Sep 2025 13:31:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Sep 25, 2025, 9:35:22 AM (23 hours ago) Sep 25
to Marc Treib, Chromium Sync Reviews, Ankush Singh, chromium...@chromium.org, Chromium LUCI CQ, webapks-...@chromium.org
Attention needed from Ankush Singh

Message from gwsq

Reviewer source(s):
ankus...@google.com is from context(googleclient/chrome/chromium_gwsq/components/sync/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Ankush Singh
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9fe959959ba3b297d9e3cfd83dccace4974e40c2
Gerrit-Change-Number: 6983605
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Treib <tr...@chromium.org>
Gerrit-Reviewer: Ankush Singh <ankus...@google.com>
Gerrit-Reviewer: Marc Treib <tr...@chromium.org>
Gerrit-CC: Chromium Sync Reviews <chromium-s...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Ankush Singh <ankus...@google.com>
Gerrit-Comment-Date: Thu, 25 Sep 2025 13:35:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Ankush Singh (Gerrit)

unread,
Sep 25, 2025, 12:25:03 PM (20 hours ago) Sep 25
to Marc Treib, Chromium Sync Reviews, chromium...@chromium.org, Chromium LUCI CQ, webapks-...@chromium.org
Attention needed from Marc Treib

Ankush Singh voted and added 1 comment

Votes added by Ankush Singh

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Ankush Singh . resolved

LGTM, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Marc Treib
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9fe959959ba3b297d9e3cfd83dccace4974e40c2
    Gerrit-Change-Number: 6983605
    Gerrit-PatchSet: 1
    Gerrit-Owner: Marc Treib <tr...@chromium.org>
    Gerrit-Reviewer: Ankush Singh <ankus...@google.com>
    Gerrit-Reviewer: Marc Treib <tr...@chromium.org>
    Gerrit-CC: Chromium Sync Reviews <chromium-s...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Marc Treib <tr...@chromium.org>
    Gerrit-Comment-Date: Thu, 25 Sep 2025 16:24:46 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 25, 2025, 12:27:44 PM (20 hours ago) Sep 25
    to Marc Treib, Ankush Singh, Chromium Sync Reviews, chromium...@chromium.org, webapks-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Implement IsEntityDataValid for WebApkSyncBridge

    The implementation simply checks that the manifest_id is not empty.
    Bug: 40889096
    Change-Id: I9fe959959ba3b297d9e3cfd83dccace4974e40c2
    Reviewed-by: Ankush Singh <ankus...@google.com>
    Auto-Submit: Marc Treib <tr...@chromium.org>
    Commit-Queue: Ankush Singh <ankus...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1520675}
    Files:
    • M chrome/browser/android/webapk/webapk_sync_bridge.cc
    • M chrome/browser/android/webapk/webapk_sync_bridge.h
    Change size: XS
    Delta: 2 files changed, 6 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Ankush Singh
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9fe959959ba3b297d9e3cfd83dccace4974e40c2
    Gerrit-Change-Number: 6983605
    Gerrit-PatchSet: 2
    Gerrit-Owner: Marc Treib <tr...@chromium.org>
    Gerrit-Reviewer: Ankush Singh <ankus...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Marc Treib <tr...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages