[Extensions][Code Health] Clean up function arguments of in AlarmManager [chromium/src : main]

0 views

Skip to first unread message

Anton Bershanskyi (Gerrit)

unread,

2:30 AM (5 hours ago) 2:30 AM

to Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, extension...@chromium.org, chromium-a...@chromium.org

Attention needed from Devlin Cronin

Anton Bershanskyi added 3 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Anton Bershanskyi . resolved

Hi Devlin,
this is a minor cleanup CL removing unused parameters from function signatures in extensions alarms system. I decided to split it out from a CL I'm writing for this bug:
https://github.com/w3c/webextensions/issues/1055

Would you agree to remove unused function arguments? Thanks!

File extensions/browser/api/alarms/alarm_manager.cc

Line 146, Patchset 2 (Latest):AlarmManager::AlarmList AlarmsFromValue(base::TimeDelta min_delay,

Anton Bershanskyi . resolved

`ExtensionId` is not used by this function.

File extensions/browser/api/alarms/alarms_api.h

Line 72, Patchset 2 (Latest): void Callback(bool removed);

Anton Bershanskyi . resolved

Renamed `success` to `removed`, since it is true if an alarm existed and was cleared and false otherwise.

Open in Gerrit

Related details

Attention is currently required from:

Devlin Cronin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages