Add an explicit example of canvas without fallback. [chromium/src : main]

0 views
Skip to first unread message

Ramin Halavati (Gerrit)

unread,
Jan 13, 2026, 12:23:33 PM (17 hours ago) Jan 13
to Ramin Halavati, Lucas Radaelli, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Lucas Radaelli

Ramin Halavati voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lucas Radaelli
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I27fb575606910c1fc5ae5d74fcd71fea8c07d6e7
Gerrit-Change-Number: 7462752
Gerrit-PatchSet: 1
Gerrit-Owner: Ramin Halavati <rhal...@chromium.org>
Gerrit-Reviewer: Lucas Radaelli <lucasr...@google.com>
Gerrit-Reviewer: Ramin Halavati <rhal...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-Attention: Lucas Radaelli <lucasr...@google.com>
Gerrit-Comment-Date: Tue, 13 Jan 2026 17:23:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Lucas Radaelli (Gerrit)

unread,
Jan 13, 2026, 4:42:14 PM (12 hours ago) Jan 13
to Ramin Halavati, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Ramin Halavati

Lucas Radaelli voted and added 2 comments

Votes added by Lucas Radaelli

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Lucas Radaelli . resolved

So just to confirm: 1. the example added is meant to be dropped in the tree. 2. because of that, no diff is seen in the -expected-*.txt variant?

Commit Message
Line 7, Patchset 1 (Latest):Add an explicit example of canvas without fallback.
Lucas Radaelli . unresolved

nit: add [a11y]

Open in Gerrit

Related details

Attention is currently required from:
  • Ramin Halavati
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I27fb575606910c1fc5ae5d74fcd71fea8c07d6e7
    Gerrit-Change-Number: 7462752
    Gerrit-PatchSet: 1
    Gerrit-Owner: Ramin Halavati <rhal...@chromium.org>
    Gerrit-Reviewer: Lucas Radaelli <lucasr...@google.com>
    Gerrit-Reviewer: Ramin Halavati <rhal...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-Attention: Ramin Halavati <rhal...@chromium.org>
    Gerrit-Comment-Date: Tue, 13 Jan 2026 21:40:53 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Ramin Halavati (Gerrit)

    unread,
    12:30 AM (4 hours ago) 12:30 AM
    to Ramin Halavati, Lucas Radaelli, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

    Ramin Halavati voted and added 1 comment

    Votes added by Ramin Halavati

    Auto-Submit+1
    Commit-Queue+2

    1 comment

    Commit Message
    Line 7, Patchset 1:Add an explicit example of canvas without fallback.
    Lucas Radaelli . resolved

    nit: add [a11y]

    Ramin Halavati

    Done

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I27fb575606910c1fc5ae5d74fcd71fea8c07d6e7
      Gerrit-Change-Number: 7462752
      Gerrit-PatchSet: 2
      Gerrit-Owner: Ramin Halavati <rhal...@chromium.org>
      Gerrit-Reviewer: Lucas Radaelli <lucasr...@google.com>
      Gerrit-Reviewer: Ramin Halavati <rhal...@chromium.org>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-Comment-Date: Wed, 14 Jan 2026 05:29:56 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Lucas Radaelli <lucasr...@google.com>
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      12:35 AM (4 hours ago) 12:35 AM
      to Ramin Halavati, Lucas Radaelli, Akihiro Ota, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

      Chromium LUCI CQ submitted the change

      Unreviewed changes

      1 is the latest approved patch-set.
      No files were changed between the latest approved patch-set and the submitted one.

      Change information

      Commit message:
      [a11y] Add an explicit example of canvas without fallback.

      Canvases without fallback are dropped from a11y tree. Add an explicit
      case to accessibility tree dump test.
      AX-Relnotes: n/a
      Bug: 475512055
      Change-Id: I27fb575606910c1fc5ae5d74fcd71fea8c07d6e7
      Reviewed-by: Lucas Radaelli <lucasr...@google.com>
      Auto-Submit: Ramin Halavati <rhal...@chromium.org>
      Commit-Queue: Ramin Halavati <rhal...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1568904}
      Files:
      • M content/test/data/accessibility/html/canvas.html
      Change size: XS
      Delta: 1 file changed, 1 insertion(+), 0 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Lucas Radaelli
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I27fb575606910c1fc5ae5d74fcd71fea8c07d6e7
      Gerrit-Change-Number: 7462752
      Gerrit-PatchSet: 3
      Gerrit-Owner: Ramin Halavati <rhal...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Lucas Radaelli <lucasr...@google.com>
      Gerrit-Reviewer: Ramin Halavati <rhal...@chromium.org>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages