Display watermark timestamps in user's local timezone [chromium/src : main]

0 views
Skip to first unread message

gwsq (Gerrit)

unread,
9:40 AM (1 hour ago) 9:40 AM
to Adam Kassi Lahlou, Chrome Enterprise Premium Reviews, Shanthanu Bhardwaj, Dominique Fauteux-Chapleau, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com
Attention needed from Dominique Fauteux-Chapleau and Shanthanu Bhardwaj

Message from gwsq

Reviewer source(s):
xa...@google.com is from context(chrome/enterprise/gwsq/cep-review.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Dominique Fauteux-Chapleau
  • Shanthanu Bhardwaj
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I30d4ed437b051802b1b0e6e2b5a4b9de1ec48e48
Gerrit-Change-Number: 8050061
Gerrit-PatchSet: 11
Gerrit-Owner: Adam Kassi Lahlou <ada...@google.com>
Gerrit-Reviewer: Adam Kassi Lahlou <ada...@google.com>
Gerrit-Reviewer: Dominique Fauteux-Chapleau <do...@chromium.org>
Gerrit-Reviewer: Shanthanu Bhardwaj <xa...@google.com>
Gerrit-CC: Chrome Enterprise Premium Reviews <cep-r...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Shanthanu Bhardwaj <xa...@google.com>
Gerrit-Attention: Dominique Fauteux-Chapleau <do...@chromium.org>
Gerrit-Comment-Date: Wed, 08 Jul 2026 13:40:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Dominique Fauteux-Chapleau (Gerrit)

unread,
10:58 AM (4 minutes ago) 10:58 AM
to Adam Kassi Lahlou, Chrome Enterprise Premium Reviews, Shanthanu Bhardwaj, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, cbe-cep-eng...@google.com
Attention needed from Adam Kassi Lahlou and Shanthanu Bhardwaj

Dominique Fauteux-Chapleau added 3 comments

File chrome/browser/enterprise/watermark/watermark_browsertest.cc
Line 165, Patchset 11 (Latest): WatermarkTextParams{"Multilingual", kMultilingualWatermarkMessage},
WatermarkTextParams{"LongLines", kLongLinesWatermarkMessage}));
Dominique Fauteux-Chapleau . unresolved

Can you add test cases here similar to the ones you have in utils_unittest.cc? This way we'll have screenshots of the new watermark timestamp format to validate in tests.

File components/enterprise/data_protection/utils.h
Line 41, Patchset 11 (Latest):// YYYY-MM-DD HH:MM:SS (UTC+HH:MM) or (UTC-HH:MM).
Dominique Fauteux-Chapleau . unresolved

Based on the implementation this is only the first pattern?

File testing/variations/fieldtrial_testing_config.json
Line 10553, Patchset 11 (Latest): "platforms": [
Dominique Fauteux-Chapleau . unresolved

No iOS?

Open in Gerrit

Related details

Attention is currently required from:
  • Adam Kassi Lahlou
  • Shanthanu Bhardwaj
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I30d4ed437b051802b1b0e6e2b5a4b9de1ec48e48
    Gerrit-Change-Number: 8050061
    Gerrit-PatchSet: 11
    Gerrit-Owner: Adam Kassi Lahlou <ada...@google.com>
    Gerrit-Reviewer: Adam Kassi Lahlou <ada...@google.com>
    Gerrit-Reviewer: Dominique Fauteux-Chapleau <do...@chromium.org>
    Gerrit-Reviewer: Shanthanu Bhardwaj <xa...@google.com>
    Gerrit-CC: Chrome Enterprise Premium Reviews <cep-r...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Shanthanu Bhardwaj <xa...@google.com>
    Gerrit-Attention: Adam Kassi Lahlou <ada...@google.com>
    Gerrit-Comment-Date: Wed, 08 Jul 2026 14:58:17 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages