[PA] Enable External Metadata on canary. [chromium/src : main]

0 views
Skip to first unread message

Takashi Sakamoto (Gerrit)

unread,
Aug 19, 2025, 1:08:36 AMAug 19
to Yuki Shiino, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, bartek...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, wfh+...@chromium.org
Attention needed from Yuki Shiino

Takashi Sakamoto added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Takashi Sakamoto . resolved

Would you review this CL?

Regarding the previous trial, the numbers of crash reports were almost the same. I will try the trial for 2 days.

Open in Gerrit

Related details

Attention is currently required from:
  • Yuki Shiino
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I707d48a31e44400c927e481bfe352fb72f04d52c
Gerrit-Change-Number: 6857387
Gerrit-PatchSet: 1
Gerrit-Owner: Takashi Sakamoto <ta...@google.com>
Gerrit-Reviewer: Takashi Sakamoto <ta...@google.com>
Gerrit-Reviewer: Yuki Shiino <yukis...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: Yuki Shiino <yukis...@chromium.org>
Gerrit-Comment-Date: Tue, 19 Aug 2025 05:08:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Yuki Shiino (Gerrit)

unread,
Aug 19, 2025, 1:32:36 AMAug 19
to Takashi Sakamoto, Yuki Shiino, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, bartek...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, wfh+...@chromium.org
Attention needed from Takashi Sakamoto

Yuki Shiino voted and added 1 comment

Votes added by Yuki Shiino

Code-Review+1

1 comment

Patchset-level comments
Yuki Shiino . resolved

LGTM.

Open in Gerrit

Related details

Attention is currently required from:
  • Takashi Sakamoto
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I707d48a31e44400c927e481bfe352fb72f04d52c
    Gerrit-Change-Number: 6857387
    Gerrit-PatchSet: 1
    Gerrit-Owner: Takashi Sakamoto <ta...@google.com>
    Gerrit-Reviewer: Takashi Sakamoto <ta...@google.com>
    Gerrit-Reviewer: Yuki Shiino <yukis...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-Attention: Takashi Sakamoto <ta...@google.com>
    Gerrit-Comment-Date: Tue, 19 Aug 2025 05:32:07 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Takashi Sakamoto (Gerrit)

    unread,
    Aug 19, 2025, 1:45:43 AMAug 19
    to Yuki Shiino, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, bartek...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, wfh+...@chromium.org

    Takashi Sakamoto added 1 comment

    Patchset-level comments
    Takashi Sakamoto . resolved

    Thank you for the review.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I707d48a31e44400c927e481bfe352fb72f04d52c
    Gerrit-Change-Number: 6857387
    Gerrit-PatchSet: 1
    Gerrit-Owner: Takashi Sakamoto <ta...@google.com>
    Gerrit-Reviewer: Takashi Sakamoto <ta...@google.com>
    Gerrit-Reviewer: Yuki Shiino <yukis...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-Comment-Date: Tue, 19 Aug 2025 05:45:37 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy

    Takashi Sakamoto (Gerrit)

    unread,
    Aug 19, 2025, 1:45:46 AMAug 19
    to Yuki Shiino, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, bartek...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, wfh+...@chromium.org

    Takashi Sakamoto voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I707d48a31e44400c927e481bfe352fb72f04d52c
    Gerrit-Change-Number: 6857387
    Gerrit-PatchSet: 1
    Gerrit-Owner: Takashi Sakamoto <ta...@google.com>
    Gerrit-Reviewer: Takashi Sakamoto <ta...@google.com>
    Gerrit-Reviewer: Yuki Shiino <yukis...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-Comment-Date: Tue, 19 Aug 2025 05:45:41 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Aug 19, 2025, 1:49:29 AMAug 19
    to Takashi Sakamoto, Yuki Shiino, chromium...@chromium.org, Kentaro Hara, bartek...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, wfh+...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [PA] Enable External Metadata on canary.

    Enable PartitionAllocExternalMetadata feature on canary for 2 days.
    Will revert this CL in 2 days. Will analyze crash reports and
    uma to see how the feature affects chrome.
    Change-Id: I707d48a31e44400c927e481bfe352fb72f04d52c
    Reviewed-by: Yuki Shiino <yukis...@chromium.org>
    Commit-Queue: Takashi Sakamoto <ta...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1503158}
    Files:
    • M base/allocator/partition_allocator/partition_alloc.gni
    Change size: XS
    Delta: 1 file changed, 2 insertions(+), 3 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Yuki Shiino
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I707d48a31e44400c927e481bfe352fb72f04d52c
    Gerrit-Change-Number: 6857387
    Gerrit-PatchSet: 2
    Gerrit-Owner: Takashi Sakamoto <ta...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Takashi Sakamoto <ta...@google.com>
    Gerrit-Reviewer: Yuki Shiino <yukis...@chromium.org>
    open
    diffy
    satisfied_requirement

    Takashi Sakamoto (Gerrit)

    unread,
    Aug 19, 2025, 2:36:25 AMAug 19
    to Chromium LUCI CQ, Yuki Shiino, chromium...@chromium.org, Kentaro Hara, bartek...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, wfh+...@chromium.org

    Takashi Sakamoto has created a revert of this change

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: revert
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages