Ash: Migrate DisplayPrefsBrowserTest off RunUntilIdle [chromium/src : main]

0 views

Skip to first unread message

Ahmed Fakhry (Gerrit)

unread,

Jul 20, 2026, 12:32:09 PM (yesterday) Jul 20

to Di Wu, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Di Wu

Ahmed Fakhry voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Di Wu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jul 20, 2026, 1:08:27 PM (yesterday) Jul 20

to Di Wu, Ahmed Fakhry, chromium...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Ash: Migrate DisplayPrefsBrowserTest off RunUntilIdle

This changelist is part of an ongoing series to modernize Ash tests by
migrating them away from RunUntilIdle() and toward targeted
synchronization with APIs such as RunUntil(), TestFuture, RunLoop
callbacks, observer waiters, or exact mock-time advancement.

DisplayPrefsBrowserTest now waits for the local-state pref store to
commit after changing display rotation. The test observes the pref write
that needs to persist into the next browser-test run instead of draining
unrelated queued work.

Bug: b:506794349

Test: CQ

Change-Id: Ie6d800820ab8187bdd3fb3c7a4083b443e0fa947

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7940791

Commit-Queue: Ahmed Fakhry <afa...@chromium.org>

Reviewed-by: Ahmed Fakhry <afa...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1664771}

Files:

M chrome/browser/ash/display/display_prefs_browsertest.cc

Change size: XS

Delta: 1 file changed, 3 insertions(+), 1 deletion(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Ahmed Fakhry

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages