[DBSC] Clean up signing quota feature flag [chromium/src : main]
Alex Ilin (Gerrit)
New activity on the change![]( "Open in Gerrit")
Related details
- Adam Rice
- Alex Rudenko
- Ali Hijazi
- Chromium IPC Reviews
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Alex Rudenko voted Code-Review+1![]( "Open in Gerrit")
- Adam Rice
- Alex Ilin
- Ali Hijazi
- Chromium IPC Reviews
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: kin...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): kin...@chromium.org
Reviewer source(s):
kin...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
- Adam Rice
- Alex Ilin
- Ali Hijazi
- Kinuko Yasuda
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Rice (Gerrit)
Adam Rice voted and added 4 comments![]( "Open in Gerrit")
Votes added by Adam Rice
| Code-Review | +1 |
4 comments
SchemefulSite site = SchemefulSite(fetcher_endpoint_);Nit (pre-existing issue): To avoid repeating yourself, it's better to write
```
auto site = SchemefulSite(fetcher_endpoint_);
```
or
```
SchemefulSite site(fetcher_endpoint_);
```
#include "base/test/scoped_feature_list.h"You can remove this #include.
if (ignore_refresh_quota_) {Maybe rename to `ignore_signing_quota_` now?
Related details
- Alex Ilin
- Ali Hijazi
- Kinuko Yasuda
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ali Hijazi (Gerrit)
Ali Hijazi voted Code-Review+1![]( "Open in Gerrit")
- Alex Ilin
- Kinuko Yasuda
Alex Ilin (Gerrit)
Alex Ilin voted and added 3 comments![]( "Open in Gerrit")
Votes added by Alex Ilin
| Commit-Queue | +1 |
3 comments
Nit (pre-existing issue): To avoid repeating yourself, it's better to write
```
auto site = SchemefulSite(fetcher_endpoint_);
```
or
```
SchemefulSite site(fetcher_endpoint_);
```
Done
You can remove this #include.
Thanks for spotting! Done
Maybe rename to `ignore_signing_quota_` now?
Done. I kept the original `RefreshQuota` parameter name for backwards compatibility though.
Related details
- Kinuko Yasuda
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |