media: Introduce VideoTransformation::IsOrthogonal() helper [chromium/src : main]

[Vikram Pasupathy (Gerrit)]

Attention needed from Ted (Chromium) Meyer

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

• Ted (Chromium) Meyer

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ibbda1db91fcb18f9ecacda0a7fc281619435ad1f

Gerrit-Change-Number: 8067023

Gerrit-PatchSet: 3

Gerrit-Owner: Vikram Pasupathy <vpasu...@chromium.org>

Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>

Gerrit-Reviewer: Vikram Pasupathy <vpasu...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ted (Chromium) Meyer <tmath...@chromium.org>

Gerrit-Comment-Date: Wed, 08 Jul 2026 22:41:50 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Ted (Chromium) Meyer (Gerrit)]

Attention needed from Vikram Pasupathy

Ted (Chromium) Meyer added 1 comment

File media/base/video_transformation.h

Line 78, Patchset 3 (Latest): // Returns true if the video is rotated 90 or 270 degrees (i.e., orthogonal),
// which swaps the width and height of the video frame during rendering.

Ted (Chromium) Meyer . unresolved

This definition part seems a bit unnecessary - also it doesn't swap them, it rotates them :)

Open in Gerrit

Related details

Attention is currently required from:

• Vikram Pasupathy

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ibbda1db91fcb18f9ecacda0a7fc281619435ad1f

Gerrit-Change-Number: 8067023

Gerrit-PatchSet: 3

Gerrit-Owner: Vikram Pasupathy <vpasu...@chromium.org>

Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>

Gerrit-Reviewer: Vikram Pasupathy <vpasu...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Vikram Pasupathy <vpasu...@chromium.org>

Gerrit-Comment-Date: Wed, 08 Jul 2026 23:26:07 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Ted (Chromium) Meyer (Gerrit)]

Attention needed from Vikram Pasupathy

Ted (Chromium) Meyer voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Vikram Pasupathy

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ibbda1db91fcb18f9ecacda0a7fc281619435ad1f

Gerrit-Change-Number: 8067023

Gerrit-PatchSet: 3

Gerrit-Owner: Vikram Pasupathy <vpasu...@chromium.org>

Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>

Gerrit-Reviewer: Vikram Pasupathy <vpasu...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Vikram Pasupathy <vpasu...@chromium.org>

Gerrit-Comment-Date: Wed, 08 Jul 2026 23:26:15 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Vikram Pasupathy (Gerrit)]

Vikram Pasupathy added 1 comment

File media/base/video_transformation.h

Line 78, Patchset 3: // Returns true if the video is rotated 90 or 270 degrees (i.e., orthogonal),


// which swaps the width and height of the video frame during rendering.

Ted (Chromium) Meyer . resolved

This definition part seems a bit unnecessary - also it doesn't swap them, it rotates them :)

Vikram Pasupathy

Removed the extra wording, and yeah good point.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ibbda1db91fcb18f9ecacda0a7fc281619435ad1f

Gerrit-Change-Number: 8067023

Gerrit-PatchSet: 4

Gerrit-Owner: Vikram Pasupathy <vpasu...@chromium.org>

Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>

Gerrit-Reviewer: Vikram Pasupathy <vpasu...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Wed, 08 Jul 2026 23:32:13 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Ted (Chromium) Meyer <tmath...@chromium.org>

[Vikram Pasupathy (Gerrit)]

Vikram Pasupathy voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ibbda1db91fcb18f9ecacda0a7fc281619435ad1f

Gerrit-Change-Number: 8067023

Gerrit-PatchSet: 4

Gerrit-Owner: Vikram Pasupathy <vpasu...@chromium.org>

Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>

Gerrit-Reviewer: Vikram Pasupathy <vpasu...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Wed, 08 Jul 2026 23:32:20 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes