Remove ProbeServiceAsh crosapi. [chromium/src : main]
0 views
Skip to first unread message
Hidehiko Abe (Gerrit)
Jun 16, 2026, 3:52:13 AM (8 days ago) Jun 16
to Georg Neis, chromium...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chungshe...@google.com, dennyh...@google.com, extension...@chromium.org, ffred...@chromium.org, menghua...@google.com, oshima...@chromium.org, tluk+...@chromium.org, weiluanw...@google.com
Attention needed from Georg Neis
Hidehiko Abe voted and added 1 comment![]( "Open in Gerrit")
Votes added by Hidehiko Abe
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Georg Neis
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Georg Neis (Gerrit)
Jun 16, 2026, 4:46:27 AM (8 days ago) Jun 16
to Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chungshe...@google.com, dennyh...@google.com, extension...@chromium.org, ffred...@chromium.org, menghua...@google.com, oshima...@chromium.org, tluk+...@chromium.org, weiluanw...@google.com
Attention needed from Hidehiko Abe
Georg Neis added 2 comments![]( "Open in Gerrit")
File chrome/browser/chromeos/extensions/telemetry/api/common/base_telemetry_extension_api_guard_function_browsertest.cc
Line 805, Patchset 1 (Latest):
// will be made.Georg Neis . unresolved
The test no longer checks that. Either preserve the check or update the comment or remove the test since it's disabled. BTW, I'm wondering if we can reenable them again (also above).
File chromeos/ash/components/telemetry_extension/telemetry/BUILD.gn
Line 10, Patchset 1 (Latest):
"probe_service_converters.h",Georg Neis . unresolved
Isn't this also dead code now?
Related details
Attention is currently required from:
- Hidehiko Abe
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hidehiko Abe (Gerrit)
Jun 16, 2026, 6:00:23 AM (8 days ago) Jun 16
to Chromium LUCI CQ, Georg Neis, chromium...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chungshe...@google.com, dennyh...@google.com, extension...@chromium.org, ffred...@chromium.org, menghua...@google.com, oshima...@chromium.org, tluk+...@chromium.org, weiluanw...@google.com
Attention needed from Georg Neis
Hidehiko Abe added 3 comments![]( "Open in Gerrit")
Patchset-level comments
Hidehiko Abe . resolved
Thank you for review.
File chrome/browser/chromeos/extensions/telemetry/api/common/base_telemetry_extension_api_guard_function_browsertest.cc
Line 805, Patchset 1 (Latest):
// will be made.Georg Neis . resolved
The test no longer checks that. Either preserve the check or update the comment or remove the test since it's disabled. BTW, I'm wondering if we can reenable them again (also above).
Hidehiko Abe
Let's split the fix in another CL.
crrev.com/c/7949958
File chromeos/ash/components/telemetry_extension/telemetry/BUILD.gn
Line 10, Patchset 1 (Latest):
"probe_service_converters.h",Georg Neis . resolved
Isn't this also dead code now?
Hidehiko Abe
they look still used. I'll remove it later after other clean up CLs.
Related details
Attention is currently required from:
- Georg Neis
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hidehiko Abe (Gerrit)
Jun 16, 2026, 6:07:10 AM (8 days ago) Jun 16
to Chromium LUCI CQ, Georg Neis, chromium...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chungshe...@google.com, dennyh...@google.com, extension...@chromium.org, ffred...@chromium.org, menghua...@google.com, oshima...@chromium.org, tluk+...@chromium.org, weiluanw...@google.com
Attention needed from Georg Neis
Hidehiko Abe added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Hidehiko Abe . resolved
Ah, sorry for confusion. With more thinking, probably we should merge these two CLs conceptually. I'll update the CL shortly, then let you know.
Related details
Attention is currently required from:
- Georg Neis
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hidehiko Abe (Gerrit)
Jun 16, 2026, 6:57:20 AM (8 days ago) Jun 16
to Chromium LUCI CQ, Georg Neis, chromium...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chungshe...@google.com, dennyh...@google.com, extension...@chromium.org, ffred...@chromium.org, menghua...@google.com, oshima...@chromium.org, tluk+...@chromium.org, weiluanw...@google.com
Attention needed from Georg Neis
Hidehiko Abe added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Georg Neis
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Georg Neis (Gerrit)
Jun 17, 2026, 9:28:58 PM (7 days ago) Jun 17
to Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chungshe...@google.com, dennyh...@google.com, extension...@chromium.org, ffred...@chromium.org, menghua...@google.com, oshima...@chromium.org, tluk+...@chromium.org, weiluanw...@google.com
Attention needed from Hidehiko Abe
Georg Neis voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Hidehiko Abe
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hidehiko Abe (Gerrit)
Jun 18, 2026, 2:05:08 AM (6 days ago) Jun 18
to Georg Neis, Chromium LUCI CQ, chromium...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chungshe...@google.com, dennyh...@google.com, extension...@chromium.org, ffred...@chromium.org, menghua...@google.com, oshima...@chromium.org, tluk+...@chromium.org, weiluanw...@google.com
Hidehiko Abe voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 18, 2026, 2:36:50 AM (6 days ago) Jun 18
to Hidehiko Abe, Georg Neis, chromium...@chromium.org, byronle...@chromium.org, chromium-a...@chromium.org, chungshe...@google.com, dennyh...@google.com, extension...@chromium.org, ffred...@chromium.org, menghua...@google.com, oshima...@chromium.org, tluk+...@chromium.org, weiluanw...@google.com
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove ProbeServiceAsh crosapi.
The API is no longer used.
BUG=510951937
TEST=Tryjob
Change-Id: I0c53604efa5fb598e58d2a8a313fb68ef8b62605
Reviewed-by: Georg Neis <ne...@chromium.org>
Commit-Queue: Hidehiko Abe <hide...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1648824}
Files:
- M chrome/browser/ash/crosapi/BUILD.gn
- M chrome/browser/ash/crosapi/crosapi_ash.cc
- M chrome/browser/ash/crosapi/crosapi_ash.h
- M chrome/browser/chromeos/extensions/telemetry/api/common/BUILD.gn
- M chrome/browser/chromeos/extensions/telemetry/api/common/base_telemetry_extension_api_guard_function_browsertest.cc
- D chrome/browser/chromeos/extensions/telemetry/api/common/remote_probe_service_strategy.cc
- D chrome/browser/chromeos/extensions/telemetry/api/common/remote_probe_service_strategy.h
- M chrome/browser/chromeos/extensions/telemetry/api/telemetry/BUILD.gn
- M chrome/browser/chromeos/extensions/telemetry/api/telemetry/telemetry_api_browsertest.cc
- M chromeos/ash/components/telemetry_extension/telemetry/BUILD.gn
- D chromeos/ash/components/telemetry_extension/telemetry/probe_service_ash.cc
- D chromeos/ash/components/telemetry_extension/telemetry/probe_service_ash.h
- D chromeos/ash/components/telemetry_extension/telemetry/probe_service_ash_unittest.cc
Change size: L
Delta: 13 files changed, 54 insertions(+), 319 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Georg Neis
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages