[AtMemory] Control PCService request timeout with a feature param [chromium/src : main]
0 views
Skip to first unread message
Karol Sygiet (Gerrit)
7:47 AM (6 hours ago) 7:47 AM
to Jan Keitel, chromium...@chromium.org, browser-comp...@chromium.org
Attention needed from Jan Keitel
Karol Sygiet added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Jan Keitel
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jan Keitel (Gerrit)
8:49 AM (5 hours ago) 8:49 AM
to Karol Sygiet, chromium...@chromium.org, browser-comp...@chromium.org
Attention needed from Karol Sygiet
Jan Keitel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jan Keitel
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Karol Sygiet
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Karol Sygiet (Gerrit)
8:49 AM (5 hours ago) 8:49 AM
to Jan Keitel, chromium...@chromium.org, browser-comp...@chromium.org
Karol Sygiet voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
9:43 AM (4 hours ago) 9:43 AM
to Karol Sygiet, Jan Keitel, chromium...@chromium.org, browser-comp...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[AtMemory] Control PCService request timeout with a feature param
This CL adds an kAutofillAtMemory feature param that controls the
timeout used for requests made to PersonalContextService. Since the
default timeout value is non changing this CL should be a noop.
Bug: 525668259
Change-Id: I3f1c6b334273166043e59dec7a581cfbb500a260
Reviewed-by: Jan Keitel <jke...@google.com>
Commit-Queue: Karol Sygiet <syg...@google.com>
Cr-Commit-Position: refs/heads/main@{#1658697}
Files:
- M components/autofill/core/browser/integrators/at_memory/at_memory_query_service.cc
- M components/autofill/core/browser/integrators/at_memory/at_memory_query_service_unittest.cc
- M components/autofill/core/common/autofill_features.cc
- M components/autofill/core/common/autofill_features.h
Change size: S
Delta: 4 files changed, 34 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jan Keitel
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages