net/disk_cache/sql: Add skeleton SqlSharedCacheIsolatedDatabase [chromium/src : main]
0 views
Skip to first unread message
Tsuyoshi Horo (Gerrit)
Jun 18, 2026, 12:38:22 AM (9 days ago) Jun 18
to Mingyu Lei, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, gavin...@chromium.org, net-r...@chromium.org
Attention needed from Mingyu Lei
Tsuyoshi Horo added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 10 (Latest):
Tsuyoshi Horo . resolved
leimy@
Could you please review this?
Thank you.
Related details
Attention is currently required from:
- Mingyu Lei
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tsuyoshi Horo (Gerrit)
Jun 18, 2026, 4:27:48 AM (9 days ago) Jun 18
to Greg Thompson, Mingyu Lei, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, gavin...@chromium.org, net-r...@chromium.org
Attention needed from Greg Thompson and Mingyu Lei
Tsuyoshi Horo added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 13 (Latest):
Tsuyoshi Horo . resolved
grt@ Could you please review following files:
- components/sqlite_vfs/client.h
- components/sqlite_vfs/metrics_util.cc
- tools/metrics/histograms/metadata/persistent_cache/histograms.xml
Thank you.
Related details
Attention is currently required from:
- Greg Thompson
- Mingyu Lei
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tsuyoshi Horo (Gerrit)
Jun 18, 2026, 4:29:47 AM (9 days ago) Jun 18
to Fergal Daly, Greg Thompson, Mingyu Lei, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, gavin...@chromium.org, net-r...@chromium.org
Attention needed from Greg Thompson and Mingyu Lei
Tsuyoshi Horo voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tsuyoshi Horo
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Tsuyoshi Horo . resolved
olivierli@
Could you please review tools/metrics/histograms/metadata/sql/histograms.xml?
Thank you.
Greg Thompson (Gerrit)
Jun 18, 2026, 8:16:41 AM (8 days ago) Jun 18
to Tsuyoshi Horo, Fergal Daly, Mingyu Lei, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, gavin...@chromium.org, net-r...@chromium.org
Attention needed from Mingyu Lei and Tsuyoshi Horo
Greg Thompson voted and added 4 comments![]( "Open in Gerrit")
Votes added by Greg Thompson
| Code-Review | +1 |
4 comments
Patchset-level comments
Greg Thompson . resolved
//components/sqlite_vfs lgtm
File components/sqlite_vfs/metrics_util.cc
Line 40, Patchset 13 (Latest):
case Client::kHttpCache:Greg Thompson . unresolved
could/should this be `kSharedCacheIsolated` (and `".SharedCacheIsolated"` below) to match the tag used for the database? this is the pattern used for `CodeCache` and `ShaderCache`.
File net/BUILD.gn
Line 3679, Patchset 13 (Latest):
"//components/sqlite_vfs:pending_file_set",Greg Thompson . unresolved
not needed -- this is in the `public_deps` of `//components/sqlite_vfs`
File tools/metrics/histograms/metadata/persistent_cache/histograms.xml
Line 54, Patchset 13 (Latest):
<variant name="Test"/>Greg Thompson . unresolved
while you're here, could you remove this line for `"Test"`? it's not used in production code, so having it here just adds a useless item in the uma dashboard. thanks!
Related details
Attention is currently required from:
- Mingyu Lei
- Tsuyoshi Horo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tsuyoshi Horo (Gerrit)
Jun 18, 2026, 7:31:05 PM (8 days ago) Jun 18
to Greg Thompson, Fergal Daly, Mingyu Lei, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, gavin...@chromium.org, net-r...@chromium.org
Attention needed from Mingyu Lei
Tsuyoshi Horo added 4 comments![]( "Open in Gerrit")
Patchset-level comments
File components/sqlite_vfs/metrics_util.cc
could/should this be `kSharedCacheIsolated` (and `".SharedCacheIsolated"` below) to match the tag used for the database? this is the pattern used for `CodeCache` and `ShaderCache`.
Tsuyoshi Horo
Done
File net/BUILD.gn
not needed -- this is in the `public_deps` of `//components/sqlite_vfs`
Tsuyoshi Horo
Done
File tools/metrics/histograms/metadata/persistent_cache/histograms.xml
while you're here, could you remove this line for `"Test"`? it's not used in production code, so having it here just adds a useless item in the uma dashboard. thanks!
Tsuyoshi Horo
Done
Related details
Attention is currently required from:
- Mingyu Lei
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tsuyoshi Horo (Gerrit)
Jun 19, 2026, 5:24:39 AM (8 days ago) Jun 19
to Olivier Li, Greg Thompson, Fergal Daly, Mingyu Lei, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, gavin...@chromium.org, net-r...@chromium.org
Attention needed from Mingyu Lei and Olivier Li
Tsuyoshi Horo added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 17 (Latest):
Tsuyoshi Horo . resolved
Could you please review tools/metrics/histograms/metadata/sql/histograms.xml?
Thank you.
Related details
Attention is currently required from:
- Mingyu Lei
- Olivier Li
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivier Li (Gerrit)
Jun 19, 2026, 11:25:15 AM (7 days ago) Jun 19
to Tsuyoshi Horo, Greg Thompson, Fergal Daly, Mingyu Lei, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, gavin...@chromium.org, net-r...@chromium.org
Attention needed from Mingyu Lei and Tsuyoshi Horo
Olivier Li voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Mingyu Lei
- Tsuyoshi Horo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mingyu Lei (Gerrit)
Jun 22, 2026, 4:37:48 AM (5 days ago) Jun 22
to Tsuyoshi Horo, Olivier Li, Greg Thompson, Fergal Daly, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, gavin...@chromium.org, net-r...@chromium.org
Attention needed from Tsuyoshi Horo
Mingyu Lei voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mingyu Lei
| Code-Review | +1 |
1 comment
File net/disk_cache/sql/sql_shared_cache_isolated_database.cc
Line 49, Patchset 18 (Latest):
[](auto) { return nullptr; });Mingyu Lei . unresolved
What is the `auto` in the argument list? Why is it not appearing in the next `ASSIGN_OR_RETURN`?
Related details
Attention is currently required from:
- Tsuyoshi Horo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tsuyoshi Horo (Gerrit)
Jun 22, 2026, 5:14:45 AM (5 days ago) Jun 22
to Mingyu Lei, Olivier Li, Greg Thompson, Fergal Daly, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, gavin...@chromium.org, net-r...@chromium.org
Tsuyoshi Horo voted and added 2 comments![]( "Open in Gerrit")
Votes added by Tsuyoshi Horo
| Commit-Queue | +2 |
2 comments
Patchset-level comments
File net/disk_cache/sql/sql_shared_cache_isolated_database.cc
Line 49, Patchset 18 (Latest):
[](auto) { return nullptr; });Mingyu Lei . resolved
What is the `auto` in the argument list? Why is it not appearing in the next `ASSIGN_OR_RETURN`?
Tsuyoshi Horo
MakePendingFileSet() returns base::expected<PendingFileSet, FileSetError> , so ASSIGN_OR_RETURN passes the error object to the lambda.
On the other hand, SqliteVfsFileSet::Bind() returns std::optional<SqliteVfsFileSet> , which doesn't have an error object, so the lambda takes no arguments.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 22, 2026, 5:22:54 AM (5 days ago) Jun 22
to Tsuyoshi Horo, Mingyu Lei, Olivier Li, Greg Thompson, Fergal Daly, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, gavin...@chromium.org, net-r...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
net/disk_cache/sql: Add skeleton SqlSharedCacheIsolatedDatabase
Add the initial skeleton of SqlSharedCacheIsolatedDatabase to handle
schema creation and initialization for the SQL shared cache backend.
Currently implements Init() and verifies database creation via
sqlite_vfs.
OBSOLETE_HISTOGRAMS=Deleted `SandboxedVfs.*.Test` histograms are used only in tests. So they are useless in the uma dashboard.
Bug: 473666511
Change-Id: I43ea3208b63e53eefb385fa893cb8b9d4e3d3c45
Commit-Queue: Tsuyoshi Horo <ho...@chromium.org>
Reviewed-by: Mingyu Lei <le...@chromium.org>
Reviewed-by: Olivier Li <oliv...@chromium.org>
Reviewed-by: Greg Thompson <g...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1650187}
Files:
- M components/sqlite_vfs/client.h
- M components/sqlite_vfs/metrics_util.cc
- M net/BUILD.gn
- M net/disk_cache/sql/DEPS
- M net/disk_cache/sql/sql_backend_constants.h
- A net/disk_cache/sql/sql_shared_cache_isolated_database.cc
- A net/disk_cache/sql/sql_shared_cache_isolated_database.h
- A net/disk_cache/sql/sql_shared_cache_isolated_database_queries.h
- A net/disk_cache/sql/sql_shared_cache_isolated_database_unittest.cc
- M tools/metrics/histograms/metadata/persistent_cache/histograms.xml
- M tools/metrics/histograms/metadata/sql/histograms.xml
Change size: L
Delta: 11 files changed, 433 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mingyu Lei, +1 by Greg Thompson, +1 by Olivier Li
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages