[XDeviceSignin] Fix pixel test for new badge [chromium/src : main]

0 views
Skip to first unread message

Ryan Sultanem (Gerrit)

unread,
5:28 AM (2 hours ago) 5:28 AM
to Pâris Meuleman, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Pâris Meuleman

Ryan Sultanem voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Pâris Meuleman
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3cfc3d1a07550f5c98e6727a549eb8145160b008
Gerrit-Change-Number: 8063500
Gerrit-PatchSet: 3
Gerrit-Owner: Pâris Meuleman <pmeu...@chromium.org>
Gerrit-Reviewer: Pâris Meuleman <pmeu...@chromium.org>
Gerrit-Reviewer: Ryan Sultanem <rs...@google.com>
Gerrit-Attention: Pâris Meuleman <pmeu...@chromium.org>
Gerrit-Comment-Date: Fri, 10 Jul 2026 09:27:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Ryan Sultanem (Gerrit)

unread,
5:30 AM (2 hours ago) 5:30 AM
to Pâris Meuleman, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Pâris Meuleman

Ryan Sultanem added 1 comment

Commit Message
Line 10, Patchset 3 (Latest):
Ryan Sultanem . unresolved

Note that it seems to be also making to overall row slightly bigger (height), is this expected?

https://chrome-public-gold.skia.org/search?corpus=gtest-pixeltests&crs=gerrit&issue=8063500&patchsets=2&positive=true&untriaged=false

Open in Gerrit

Related details

Attention is currently required from:
  • Pâris Meuleman
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3cfc3d1a07550f5c98e6727a549eb8145160b008
    Gerrit-Change-Number: 8063500
    Gerrit-PatchSet: 3
    Gerrit-Owner: Pâris Meuleman <pmeu...@chromium.org>
    Gerrit-Reviewer: Pâris Meuleman <pmeu...@chromium.org>
    Gerrit-Reviewer: Ryan Sultanem <rs...@google.com>
    Gerrit-Attention: Pâris Meuleman <pmeu...@chromium.org>
    Gerrit-Comment-Date: Fri, 10 Jul 2026 09:29:41 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Pâris Meuleman (Gerrit)

    unread,
    5:44 AM (2 hours ago) 5:44 AM
    to Ryan Sultanem, Chromium LUCI CQ, chromium...@chromium.org
    Attention needed from Ryan Sultanem

    Pâris Meuleman added 1 comment

    Commit Message
    Ryan Sultanem . unresolved

    Note that it seems to be also making to overall row slightly bigger (height), is this expected?

    https://chrome-public-gold.skia.org/search?corpus=gtest-pixeltests&crs=gerrit&issue=8063500&patchsets=2&positive=true&untriaged=false

    Pâris Meuleman

    ah thanks, I should tweak the badge to be slightly smaller I think

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ryan Sultanem
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3cfc3d1a07550f5c98e6727a549eb8145160b008
    Gerrit-Change-Number: 8063500
    Gerrit-PatchSet: 3
    Gerrit-Owner: Pâris Meuleman <pmeu...@chromium.org>
    Gerrit-Reviewer: Pâris Meuleman <pmeu...@chromium.org>
    Gerrit-Reviewer: Ryan Sultanem <rs...@google.com>
    Gerrit-Attention: Ryan Sultanem <rs...@google.com>
    Gerrit-Comment-Date: Fri, 10 Jul 2026 09:43:55 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Ryan Sultanem <rs...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages