Activate SurfaceLayer before processing transform of the first frame [chromium/src : main]
0 views
Skip to first unread message
Vasiliy Telezhnikov (Gerrit)
Jul 7, 2026, 4:50:09 PM (17 hours ago) Jul 7
to Guido Urdaneta, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, tommyw+w...@chromium.org
Attention needed from Guido Urdaneta
Vasiliy Telezhnikov added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Guido Urdaneta
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Guido Urdaneta (Gerrit)
2:49 AM (7 hours ago) 2:49 AM
to Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, tommyw+w...@chromium.org
Attention needed from Vasiliy Telezhnikov
Guido Urdaneta voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
9:07 AM (1 hour ago) 9:07 AM
to Guido Urdaneta, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, tommyw+w...@chromium.org
Vasiliy Telezhnikov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Vasiliy Telezhnikov . resolved
Thanks for the review.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
9:09 AM (1 hour ago) 9:09 AM
to Guido Urdaneta, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, tommyw+w...@chromium.org
Vasiliy Telezhnikov voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
9:14 AM (1 hour ago) 9:14 AM
to Vasiliy Telezhnikov, Guido Urdaneta, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, tommyw+w...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Activate SurfaceLayer before processing transform of the first frame
Before this CL we call OnTransformChanged before switching to the
SurfaceLayer for video, this triggers creation of the VideoLayer, which
is immediately destroyed afterwards if we're in SurfaceLayer mode.
To avoid this back and forth and simplify clean-ups, we should first
try surface layer and go VideoLayer only if SurfaceLayer is not
enabled.
Bug: 400514120
Change-Id: I5e8d83c249111c25ff1d63007fc967edabcad477
Commit-Queue: Vasiliy Telezhnikov <vas...@chromium.org>
Reviewed-by: Guido Urdaneta <gui...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1658682}
Files:
- M third_party/blink/renderer/modules/mediastream/web_media_player_ms.cc
Change size: XS
Delta: 1 file changed, 3 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Guido Urdaneta
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages