[FedCM] Remove `rp_mode` from FetchConfig() [chromium/src : main]

0 views
Skip to first unread message

Nicolás Peña (Gerrit)

unread,
Jan 13, 2026, 2:36:58 PMJan 13
to Christian Biesinger, chromium...@chromium.org, Kaan Icer, npm+...@chromium.org, yigu+...@chromium.org
Attention needed from Christian Biesinger

Nicolás Peña voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Christian Biesinger
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1d44ff92a648d6fe89910d245e1eaf0a4001d121
Gerrit-Change-Number: 7466183
Gerrit-PatchSet: 1
Gerrit-Owner: Nicolás Peña <n...@chromium.org>
Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
Gerrit-Reviewer: Nicolás Peña <n...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-Attention: Christian Biesinger <cbies...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 19:36:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Christian Biesinger (Gerrit)

unread,
Jan 13, 2026, 2:39:10 PMJan 13
to Nicolás Peña, Christian Biesinger, Chromium LUCI CQ, chromium...@chromium.org, Kaan Icer, npm+...@chromium.org, yigu+...@chromium.org
Attention needed from Nicolás Peña

Christian Biesinger voted and added 1 comment

Votes added by Christian Biesinger

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Christian Biesinger . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Nicolás Peña
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1d44ff92a648d6fe89910d245e1eaf0a4001d121
    Gerrit-Change-Number: 7466183
    Gerrit-PatchSet: 1
    Gerrit-Owner: Nicolás Peña <n...@chromium.org>
    Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
    Gerrit-Reviewer: Nicolás Peña <n...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-Attention: Nicolás Peña <n...@chromium.org>
    Gerrit-Comment-Date: Tue, 13 Jan 2026 19:38:56 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Nicolás Peña (Gerrit)

    unread,
    Jan 13, 2026, 2:41:03 PMJan 13
    to Christian Biesinger, Chromium LUCI CQ, chromium...@chromium.org, Kaan Icer, npm+...@chromium.org, yigu+...@chromium.org

    Nicolás Peña voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1d44ff92a648d6fe89910d245e1eaf0a4001d121
    Gerrit-Change-Number: 7466183
    Gerrit-PatchSet: 1
    Gerrit-Owner: Nicolás Peña <n...@chromium.org>
    Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
    Gerrit-Reviewer: Nicolás Peña <n...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-Comment-Date: Tue, 13 Jan 2026 19:40:51 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 13, 2026, 4:38:30 PMJan 13
    to Nicolás Peña, Christian Biesinger, chromium...@chromium.org, Kaan Icer, npm+...@chromium.org, yigu+...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [FedCM] Remove `rp_mode` from FetchConfig()
    Change-Id: I1d44ff92a648d6fe89910d245e1eaf0a4001d121
    Auto-Submit: Nicolás Peña <n...@chromium.org>
    Reviewed-by: Christian Biesinger <cbies...@chromium.org>
    Commit-Queue: Nicolás Peña <n...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1568689}
    Files:
    • M content/browser/webid/accounts_fetcher.cc
    • M content/browser/webid/config_fetcher.cc
    • M content/browser/webid/config_fetcher.h
    • M content/browser/webid/config_fetcher_unittest.cc
    • M content/browser/webid/disconnect_request.cc
    • M content/browser/webid/disconnect_request_unittest.cc
    • M content/browser/webid/idp_network_request_manager.cc
    • M content/browser/webid/idp_network_request_manager.h
    • M content/browser/webid/idp_network_request_manager_unittest.cc
    • M content/browser/webid/idp_registration_handler.cc
    • M content/browser/webid/request_service_multiple_frames_unittest.cc
    • M content/browser/webid/request_service_registry_unittest.cc
    • M content/browser/webid/request_service_unittest.cc
    • M content/browser/webid/test/delegated_idp_network_request_manager.cc
    • M content/browser/webid/test/delegated_idp_network_request_manager.h
    • M content/browser/webid/test/mock_idp_network_request_manager.h
    • M content/browser/webid/user_info_request.cc
    • M content/browser/webid/user_info_request_unittest.cc
    Change size: M
    Delta: 18 files changed, 24 insertions(+), 48 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Christian Biesinger
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1d44ff92a648d6fe89910d245e1eaf0a4001d121
    Gerrit-Change-Number: 7466183
    Gerrit-PatchSet: 2
    Gerrit-Owner: Nicolás Peña <n...@chromium.org>
    Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Nicolás Peña <n...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages