Bugfix: This CL fixes a bug reported in crbug.com/497499482 [chromium/src : main]

0 views
Skip to first unread message

Minoru Chikamune (Gerrit)

unread,
Jun 5, 2026, 7:06:17 AMJun 5
to Minoru Chikamune, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Minoru Chikamune

Message from Minoru Chikamune

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • Minoru Chikamune
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id044fb53cb0a265c2c96d37267244a422aa6abd0
Gerrit-Change-Number: 7902624
Gerrit-PatchSet: 1
Gerrit-Owner: Minoru Chikamune <chik...@chromium.org>
Gerrit-Reviewer: Minoru Chikamune <chik...@chromium.org>
Gerrit-Attention: Minoru Chikamune <chik...@chromium.org>
Gerrit-Comment-Date: Fri, 05 Jun 2026 11:05:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kouhei Ueno (Gerrit)

unread,
Jun 17, 2026, 7:50:33 AMJun 17
to Minoru Chikamune, Hiroki Nakagawa, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Hiroki Nakagawa and Minoru Chikamune

Kouhei Ueno voted and added 1 comment

Votes added by Kouhei Ueno

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Kouhei Ueno . resolved

nhiroki: PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Hiroki Nakagawa
  • Minoru Chikamune
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id044fb53cb0a265c2c96d37267244a422aa6abd0
    Gerrit-Change-Number: 7902624
    Gerrit-PatchSet: 1
    Gerrit-Owner: Minoru Chikamune <chik...@chromium.org>
    Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
    Gerrit-Reviewer: Minoru Chikamune <chik...@chromium.org>
    Gerrit-Attention: Minoru Chikamune <chik...@chromium.org>
    Gerrit-Attention: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-Comment-Date: Wed, 17 Jun 2026 11:49:57 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Hiroki Nakagawa (Gerrit)

    unread,
    Jun 18, 2026, 12:51:08 AMJun 18
    to Minoru Chikamune, Kouhei Ueno, Chromium LUCI CQ, chromium...@chromium.org
    Attention needed from Minoru Chikamune

    Hiroki Nakagawa voted and added 2 comments

    Votes added by Hiroki Nakagawa

    Code-Review+1

    2 comments

    Patchset-level comments
    Hiroki Nakagawa . resolved

    LGTM, thanks!

    File components/no_state_prefetch/browser/no_state_prefetch_manager.cc
    Line 237, Patchset 1 (Latest): // to the prefetch renderer.
    Hiroki Nakagawa . unresolved

    Can you add a link to the crbug for posterity?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Minoru Chikamune
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id044fb53cb0a265c2c96d37267244a422aa6abd0
    Gerrit-Change-Number: 7902624
    Gerrit-PatchSet: 1
    Gerrit-Owner: Minoru Chikamune <chik...@chromium.org>
    Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
    Gerrit-Reviewer: Minoru Chikamune <chik...@chromium.org>
    Gerrit-Attention: Minoru Chikamune <chik...@chromium.org>
    Gerrit-Comment-Date: Thu, 18 Jun 2026 04:50:35 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Minoru Chikamune (Gerrit)

    unread,
    Jul 1, 2026, 2:34:24 AM (3 days ago) Jul 1
    to Minoru Chikamune, Hiroki Nakagawa, Kouhei Ueno, Chromium LUCI CQ, chromium...@chromium.org
    Attention needed from Hiroki Nakagawa

    Minoru Chikamune added 1 comment

    File components/no_state_prefetch/browser/no_state_prefetch_manager.cc
    Line 237, Patchset 1 (Latest): // to the prefetch renderer.
    Hiroki Nakagawa . unresolved

    Can you add a link to the crbug for posterity?

    Minoru Chikamune

    Sure. Will do.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Hiroki Nakagawa
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id044fb53cb0a265c2c96d37267244a422aa6abd0
    Gerrit-Change-Number: 7902624
    Gerrit-PatchSet: 1
    Gerrit-Owner: Minoru Chikamune <chik...@chromium.org>
    Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
    Gerrit-Reviewer: Minoru Chikamune <chik...@chromium.org>
    Gerrit-Attention: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-Comment-Date: Wed, 01 Jul 2026 06:33:52 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Hiroki Nakagawa <nhi...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Minoru Chikamune (Gerrit)

    unread,
    Jul 3, 2026, 12:18:56 AM (yesterday) Jul 3
    to Minoru Chikamune, Hiroki Nakagawa, Kouhei Ueno, Chromium LUCI CQ, chromium...@chromium.org
    Attention needed from Hiroki Nakagawa

    Minoru Chikamune added 1 comment

    File components/no_state_prefetch/browser/no_state_prefetch_manager.cc
    Line 237, Patchset 1 (Latest): // to the prefetch renderer.
    Hiroki Nakagawa . unresolved

    Can you add a link to the crbug for posterity?

    Minoru Chikamune

    Sure. Will do.

    Gerrit-Comment-Date: Fri, 03 Jul 2026 04:18:36 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Minoru Chikamune <chik...@chromium.org>
    Comment-In-Reply-To: Hiroki Nakagawa <nhi...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages