[Autofill] Do not use kAtMemory trigger source for keyboard shortcut [chromium/src : main]

0 views
Skip to first unread message

Christoph Schwering (Gerrit)

unread,
4:29 AM (9 hours ago) 4:29 AM
to Jan Keitel, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org
Attention needed from Jan Keitel

Christoph Schwering voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jan Keitel
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id4d036d55a81d2151d2f38cca3b585feeede6dbd
Gerrit-Change-Number: 8136927
Gerrit-PatchSet: 1
Gerrit-Owner: Christoph Schwering <schw...@google.com>
Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
Gerrit-Reviewer: Jan Keitel <jke...@google.com>
Gerrit-Attention: Jan Keitel <jke...@google.com>
Gerrit-Comment-Date: Fri, 24 Jul 2026 08:29:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jan Keitel (Gerrit)

unread,
5:10 AM (8 hours ago) 5:10 AM
to Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org
Attention needed from Christoph Schwering

Jan Keitel added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Jan Keitel . unresolved

Tests seem unhappy. :/

Open in Gerrit

Related details

Attention is currently required from:
  • Christoph Schwering
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id4d036d55a81d2151d2f38cca3b585feeede6dbd
    Gerrit-Change-Number: 8136927
    Gerrit-PatchSet: 1
    Gerrit-Owner: Christoph Schwering <schw...@google.com>
    Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
    Gerrit-Reviewer: Jan Keitel <jke...@google.com>
    Gerrit-Attention: Christoph Schwering <schw...@google.com>
    Gerrit-Comment-Date: Fri, 24 Jul 2026 09:10:14 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Christoph Schwering (Gerrit)

    unread,
    6:37 AM (7 hours ago) 6:37 AM
    to Jan Keitel, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org
    Attention needed from Jan Keitel

    Christoph Schwering voted and added 1 comment

    Votes added by Christoph Schwering

    Auto-Submit+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 1:
    Jan Keitel . resolved

    Tests seem unhappy. :/

    Christoph Schwering

    Should work now, if Jetski did its job

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jan Keitel
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id4d036d55a81d2151d2f38cca3b585feeede6dbd
      Gerrit-Change-Number: 8136927
      Gerrit-PatchSet: 2
      Gerrit-Owner: Christoph Schwering <schw...@google.com>
      Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
      Gerrit-Reviewer: Jan Keitel <jke...@google.com>
      Gerrit-Attention: Jan Keitel <jke...@google.com>
      Gerrit-Comment-Date: Fri, 24 Jul 2026 10:37:15 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Jan Keitel <jke...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Jan Keitel (Gerrit)

      unread,
      7:24 AM (6 hours ago) 7:24 AM
      to Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org
      Attention needed from Christoph Schwering

      Jan Keitel voted

      Code-Review+1
      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Christoph Schwering
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Id4d036d55a81d2151d2f38cca3b585feeede6dbd
        Gerrit-Change-Number: 8136927
        Gerrit-PatchSet: 2
        Gerrit-Owner: Christoph Schwering <schw...@google.com>
        Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
        Gerrit-Reviewer: Jan Keitel <jke...@google.com>
        Gerrit-Attention: Christoph Schwering <schw...@google.com>
        Gerrit-Comment-Date: Fri, 24 Jul 2026 11:24:31 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        8:03 AM (5 hours ago) 8:03 AM
        to Jan Keitel, chromium...@chromium.org, browser-comp...@chromium.org

        Chromium LUCI CQ submitted the change

        Unreviewed changes

        2 is the latest approved patch-set.
        No files were changed between the latest approved patch-set and the submitted one.

        Change information

        Commit message:
        [Autofill] Do not use kAtMemory trigger source for keyboard shortcut

        The renderer will maintain the information whether it needs to erase
        a trigger string. For the shortcut, it should not.

        A followup CL will introduce a proper new trigger source.
        Bug: 494158096
        Change-Id: Id4d036d55a81d2151d2f38cca3b585feeede6dbd
        Commit-Queue: Jan Keitel <jke...@google.com>
        Reviewed-by: Jan Keitel <jke...@google.com>
        Auto-Submit: Christoph Schwering <schw...@google.com>
        Commit-Queue: Christoph Schwering <schw...@google.com>
        Cr-Commit-Position: refs/heads/main@{#1667786}
        Files:
        • M components/autofill/content/renderer/autofill_agent.cc
        • M components/autofill/content/renderer/autofill_agent_browsertest.cc
        Change size: M
        Delta: 2 files changed, 35 insertions(+), 18 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Jan Keitel
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Id4d036d55a81d2151d2f38cca3b585feeede6dbd
        Gerrit-Change-Number: 8136927
        Gerrit-PatchSet: 4
        Gerrit-Owner: Christoph Schwering <schw...@google.com>
        Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Jan Keitel <jke...@google.com>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages