[ash] input_method: Drop dead chrome/browser/policy include [chromium/src : main]
0 views
Skip to first unread message
Tiago Vignatti (Gerrit)
Jul 8, 2026, 1:28:53 PM (22 hours ago) Jul 8
to Hidehiko Abe, Thomas Lukaszewicz, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, keithle...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Hidehiko Abe
Tiago Vignatti added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Hidehiko Abe
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hidehiko Abe (Gerrit)
Jul 8, 2026, 9:20:39 PM (14 hours ago) Jul 8
to Tiago Vignatti, Thomas Lukaszewicz, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, keithle...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Tiago Vignatti
Hidehiko Abe voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Tiago Vignatti
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tiago Vignatti (Gerrit)
7:59 AM (4 hours ago) 7:59 AM
to Hidehiko Abe, Thomas Lukaszewicz, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, keithle...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Tiago Vignatti voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
8:16 AM (3 hours ago) 8:16 AM
to Tiago Vignatti, Hidehiko Abe, Thomas Lukaszewicz, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, keithle...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[ash] input_method: Drop dead chrome/browser/policy include
editor_switch.cc included
chrome/browser/policy/profile_policy_connector.h but never referenced
ProfilePolicyConnector, so both the include and the general DEPS
exemption were dead for production. The unittest that still uses the
connector is already covered by the existing test-scoped include rule.
#ai-assisted
Bug: 353332589
Change-Id: If4f3f6f9584f2eb76f95a645b41d21927d15c607
Reviewed-by: Hidehiko Abe <hide...@chromium.org>
Commit-Queue: Tiago Vignatti <tvig...@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1659479}
Files:
- M chrome/browser/ash/input_method/DEPS
- M chrome/browser/ash/input_method/editor_switch.cc
Change size: XS
Delta: 2 files changed, 0 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Hidehiko Abe
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages