[Persist] Convert TabCreator to interface. [chromium/src : main]

0 views
Skip to first unread message

Sky Malice (Gerrit)

unread,
4:24 PM (4 hours ago) 4:24 PM
to Fiaz Muhammad, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Fiaz Muhammad

Sky Malice added 1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Fiaz Muhammad
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I798600d2e0f759ff7ec8e91cfdbaa37c481eb8cd
Gerrit-Change-Number: 7064490
Gerrit-PatchSet: 1
Gerrit-Owner: Sky Malice <sk...@chromium.org>
Gerrit-Reviewer: Fiaz Muhammad <mf...@google.com>
Gerrit-Reviewer: Sky Malice <sk...@chromium.org>
Gerrit-Attention: Fiaz Muhammad <mf...@google.com>
Gerrit-Comment-Date: Mon, 20 Oct 2025 20:24:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Fiaz Muhammad (Gerrit)

unread,
4:56 PM (3 hours ago) 4:56 PM
to Sky Malice, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Sky Malice

Fiaz Muhammad voted and added 1 comment

Votes added by Fiaz Muhammad

Code-Review+1

1 comment

File chrome/browser/tabmodel/android/java/src/org/chromium/chrome/browser/tabmodel/TabCreator.java
Line 23, Patchset 1 (Latest):public interface TabCreator {
Fiaz Muhammad . resolved

This is awesome!

Open in Gerrit

Related details

Attention is currently required from:
  • Sky Malice
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I798600d2e0f759ff7ec8e91cfdbaa37c481eb8cd
    Gerrit-Change-Number: 7064490
    Gerrit-PatchSet: 1
    Gerrit-Owner: Sky Malice <sk...@chromium.org>
    Gerrit-Reviewer: Fiaz Muhammad <mf...@google.com>
    Gerrit-Reviewer: Sky Malice <sk...@chromium.org>
    Gerrit-Attention: Sky Malice <sk...@chromium.org>
    Gerrit-Comment-Date: Mon, 20 Oct 2025 20:56:44 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages