Revert "[ActorOTP] Allow PSL sender match for login flows" [chromium/src : main]
0 views
Skip to first unread message
luci-bisection@appspot.gserviceaccount.com (Gerrit)
5:10 AM (3 hours ago) 5:10 AM
to Trang Mai, Kevin McNee, Chromium LUCI CQ, Ioana Treib, chromium...@chromium.org
Attention needed from Ioana Treib, Kevin McNee and Trang Mai
luci-bi...@appspot.gserviceaccount.com has uploaded the change for review![]( "Open in Gerrit")
luci-bi...@appspot.gserviceaccount.com would like Trang Mai, Kevin McNee, Chromium LUCI CQ and Ioana Treib to review this change.
Commit message
Revert "[ActorOTP] Allow PSL sender match for login flows"
This reverts commit dbae942aa8316c2d450e5243a12482358809d292.
Reason for revert:
LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8675407965181265041
Sample failed build: https://ci.chromium.org/b/8675407965181265041
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F8103527&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8675407965181265041&type=BUG
Original change's description:
> [ActorOTP] Allow PSL sender match for login flows
>
> We know that the frame to fill is trustworthy since a login was
> allowed there.
>
> Bug: 526619811,526615169
> Change-Id: I264d12850f09bbdfdd7136e502a3c7e6282a05b6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8103527
> Reviewed-by: Kevin McNee <mc...@chromium.org>
> Reviewed-by: Trang Mai <tra...@google.com>
> Commit-Queue: Ioana Treib <ioa...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1667722}
>
Bug: 526619811,526615169
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Ic571a674b4a87b7aa75ec565962665740904fe96
Change diff
Change information
Files:
- M chrome/browser/actor/tools/attempt_otp_filling_tool.cc
- M chrome/browser/actor/tools/attempt_otp_filling_tool_unittest.cc
- M chrome/browser/autofill/actor/one_time_tokens/actor_one_time_token_filling_service.h
- M chrome/browser/autofill/actor/one_time_tokens/actor_one_time_token_filling_service_impl.cc
- M chrome/browser/autofill/actor/one_time_tokens/actor_one_time_token_filling_service_impl.h
- M chrome/browser/autofill/actor/one_time_tokens/actor_one_time_token_filling_service_impl_unittest.cc
Change size: M
Delta: 6 files changed, 28 insertions(+), 108 deletions(-)
Related details
Attention is currently required from:
- Ioana Treib
- Kevin McNee
- Trang Mai
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
luci-bisection@appspot.gserviceaccount.com (Gerrit)
5:11 AM (3 hours ago) 5:11 AM
to Aisulu Rakhmetullina, Trang Mai, Kevin McNee, Chromium LUCI CQ, Ioana Treib, chromium...@chromium.org
Attention needed from Ioana Treib, Kevin McNee and Trang Mai
luci-bi...@appspot.gserviceaccount.com voted![]( "Open in Gerrit")
LUCI Bisection is automatically submitting this revert.
| Bot-Commit | +1 |
| Commit-Queue | +2 |
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Ioana Treib
- Kevin McNee
- Trang Mai
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
5:11 AM (3 hours ago) 5:11 AM
to luci-bi...@appspot.gserviceaccount.com, Aisulu Rakhmetullina, Trang Mai, Kevin McNee, Ioana Treib, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "[ActorOTP] Allow PSL sender match for login flows"
This reverts commit dbae942aa8316c2d450e5243a12482358809d292.
Reason for revert:
LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8675407965181265041
Sample failed build: https://ci.chromium.org/b/8675407965181265041
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F8103527&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8675407965181265041&type=BUG
Original change's description:
> [ActorOTP] Allow PSL sender match for login flows
>
> We know that the frame to fill is trustworthy since a login was
> allowed there.
>
> Bug: 526619811,526615169
> Change-Id: I264d12850f09bbdfdd7136e502a3c7e6282a05b6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8103527
> Reviewed-by: Kevin McNee <mc...@chromium.org>
> Reviewed-by: Trang Mai <tra...@google.com>
> Commit-Queue: Ioana Treib <ioa...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1667722}
>
Bug: 526619811,526615169
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Ic571a674b4a87b7aa75ec565962665740904fe96
Cr-Commit-Position: refs/heads/main@{#1667727}
Files:
- M chrome/browser/actor/tools/attempt_otp_filling_tool.cc
- M chrome/browser/actor/tools/attempt_otp_filling_tool_unittest.cc
- M chrome/browser/autofill/actor/one_time_tokens/actor_one_time_token_filling_service.h
- M chrome/browser/autofill/actor/one_time_tokens/actor_one_time_token_filling_service_impl.cc
- M chrome/browser/autofill/actor/one_time_tokens/actor_one_time_token_filling_service_impl.h
- M chrome/browser/autofill/actor/one_time_tokens/actor_one_time_token_filling_service_impl_unittest.cc
Change size: M
Delta: 6 files changed, 28 insertions(+), 108 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: Bot-Commit+1 by luci-bi...@appspot.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ioana Treib (Gerrit)
6:26 AM (2 hours ago) 6:26 AM
to luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Aisulu Rakhmetullina, Trang Mai, Kevin McNee, chromium...@chromium.org, browser-comp...@chromium.org, mfoltz+wa...@chromium.org
Ioana Treib has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages