[spc][clank] Update ChromePaymentRequestService with the SPC Controller [chromium/src : main]
1 view
Skip to first unread message
Darwin Yang (Gerrit)
Jun 10, 2025, 12:31:29 PM6/10/25
to Slobodan Pejic, Chromium Payments Reviews, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, gogerald+pa...@chromium.org, npnavarro+p...@chromium.org, rouslan+...@chromium.org, sloboda...@chromium.org
Attention needed from Slobodan Pejic
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Slobodan Pejic
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Slobodan Pejic (Gerrit)
Jun 11, 2025, 9:33:44 AM6/11/25
to Darwin Yang, Chromium Payments Reviews, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, gogerald+pa...@chromium.org, npnavarro+p...@chromium.org, rouslan+...@chromium.org, sloboda...@chromium.org
Attention needed from Darwin Yang
Slobodan Pejic voted and added 4 comments![]( "Open in Gerrit")
Votes added by Slobodan Pejic
| Code-Review | +1 |
4 comments
Patchset-level comments
File chrome/android/java/src/org/chromium/chrome/browser/payments/ChromePaymentRequestService.java
File-level comment, Patchset 1 (Latest):
Slobodan Pejic . resolved
Noting that test coverage for ChromePaymentRequestService's SPC flows are tracked in https://crbug.com/407538847.
Line 122, Patchset 1 (Latest):
// mSpcController is null when it is closed and before it is shown.Slobodan Pejic . unresolved
nit: Add a note above mScpAuthnUiController and mNoMatchingController that they are being replaced by mSpcController.
Line 583, Patchset 1 (Latest):
if (mSpcController.show()) {
mJourneyLogger.setShown();
mPaymentRequestService.onUiDisplayed();
return null;
} else {
mSpcController = null;
return ErrorStrings.SPC_AUTHN_UI_SUPPRESSED;
}Slobodan Pejic . unresolved
Can we share the lines 655-662, instead of duplicating here?
Related details
Attention is currently required from:
- Darwin Yang
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darwin Yang (Gerrit)
Jun 11, 2025, 3:08:49 PM6/11/25
to Slobodan Pejic, Chromium Payments Reviews, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, gogerald+pa...@chromium.org, npnavarro+p...@chromium.org, rouslan+...@chromium.org, sloboda...@chromium.org
Darwin Yang added 2 comments![]( "Open in Gerrit")
File chrome/android/java/src/org/chromium/chrome/browser/payments/ChromePaymentRequestService.java
Line 122, Patchset 1:
// mSpcController is null when it is closed and before it is shown.Slobodan Pejic . resolved
nit: Add a note above mScpAuthnUiController and mNoMatchingController that they are being replaced by mSpcController.
Darwin Yang
Done
Line 583, Patchset 1:
if (mSpcController.show()) {
mJourneyLogger.setShown();
mPaymentRequestService.onUiDisplayed();
return null;
} else {
mSpcController = null;
return ErrorStrings.SPC_AUTHN_UI_SUPPRESSED;
}Slobodan Pejic . resolved
Can we share the lines 655-662, instead of duplicating here?
Darwin Yang
Discussed offline. There isn't a simple solution to dedupe the code here due to the different controllers involved in the code.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darwin Yang (Gerrit)
Jun 11, 2025, 3:09:48 PM6/11/25
to Ted Choc, Slobodan Pejic, Chromium Payments Reviews, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, gogerald+pa...@chromium.org, npnavarro+p...@chromium.org, rouslan+...@chromium.org, sloboda...@chromium.org
Attention needed from Ted Choc
Darwin Yang added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Darwin Yang . resolved
Hi @ted...@chromium.org I'm adding you for an OWNERS review on `content_feature_map.cc`.
Related details
Attention is currently required from:
- Ted Choc
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ted Choc (Gerrit)
Jun 11, 2025, 5:40:58 PM6/11/25
to Darwin Yang, Slobodan Pejic, Chromium Payments Reviews, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, gogerald+pa...@chromium.org, npnavarro+p...@chromium.org, rouslan+...@chromium.org, sloboda...@chromium.org
Attention needed from Darwin Yang
Ted Choc voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Darwin Yang
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darwin Yang (Gerrit)
Jun 12, 2025, 9:17:43 AM6/12/25
to Ted Choc, Slobodan Pejic, Chromium Payments Reviews, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, gogerald+pa...@chromium.org, npnavarro+p...@chromium.org, rouslan+...@chromium.org, sloboda...@chromium.org
Darwin Yang voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 12, 2025, 9:22:56 AM6/12/25
to Darwin Yang, Ted Choc, Slobodan Pejic, Chromium Payments Reviews, AyeAye, chromium...@chromium.org, gogerald+pa...@chromium.org, npnavarro+p...@chromium.org, rouslan+...@chromium.org, sloboda...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[spc][clank] Update ChromePaymentRequestService with the SPC Controller
Use the new SPC Controller in ChromePaymentRequestService if the
SecurePaymentConfirmationUxRefresh flag is on.
Replace usages of `assert != null` with `assertNonNull()` in
ChromePaymentRequestService.
Bug: 416516524
Change-Id: I3915042190c273cd8c5770b0b98bc594cd3b4de2
Reviewed-by: Ted Choc <ted...@chromium.org>
Reviewed-by: Slobodan Pejic <slob...@chromium.org>
Commit-Queue: Darwin Yang <darwi...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473002}
Files:
- M chrome/android/BUILD.gn
- M chrome/android/java/src/org/chromium/chrome/browser/payments/ChromePaymentRequestService.java
- M components/payments/content/android/spc/java/src/org/chromium/components/payments/secure_payment_confirmation/SecurePaymentConfirmationController.java
- M content/browser/android/content_feature_map.cc
Change size: M
Delta: 4 files changed, 173 insertions(+), 30 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ted Choc, +1 by Slobodan Pejic
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages