Migrate factory methods in `image_button_factory.h` to ui::ColorVariant [chromium/src : main]

0 views
Skip to first unread message

Zoraiz Naeem (Gerrit)

unread,
Oct 28, 2025, 3:21:01 PM10/28/25
to Sylvain Defresne, AyeAye, Hidehiko Abe, Elly FJ, chromium...@chromium.org, Permissions Reviews, ajayramamurt...@google.com, crisrael+...@google.com, derinel+wat...@google.com, feature-me...@chromium.org, gcasto+w...@chromium.org, jackshira+...@google.com, jdonnel...@chromium.org, jonmann+w...@chromium.org, omnibox-...@chromium.org, pushi+wa...@google.com, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, sloboda...@chromium.org, storage...@chromium.org, tbarzi...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org
Attention needed from Elly FJ and Hidehiko Abe

Zoraiz Naeem added 1 comment

Commit Message
Line 7, Patchset 2:Migrate factory methods from `image_button_factory.h` to ui::ColorVariant
Sylvain Defresne . resolved

from -> in ?

Zoraiz Naeem

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Elly FJ
  • Hidehiko Abe
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4601a9cf4a1dff3cd1f25748bfa622f3183cef7f
Gerrit-Change-Number: 7089438
Gerrit-PatchSet: 3
Gerrit-Owner: Zoraiz Naeem <zorai...@chromium.org>
Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Sylvain Defresne <sdef...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-Attention: Elly FJ <elly...@chromium.org>
Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
Gerrit-Comment-Date: Tue, 28 Oct 2025 19:20:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sylvain Defresne <sdef...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Hidehiko Abe (Gerrit)

unread,
Oct 29, 2025, 12:44:04 AM10/29/25
to Zoraiz Naeem, Sylvain Defresne, AyeAye, Elly FJ, chromium...@chromium.org, Permissions Reviews, ajayramamurt...@google.com, crisrael+...@google.com, derinel+wat...@google.com, feature-me...@chromium.org, gcasto+w...@chromium.org, jackshira+...@google.com, jdonnel...@chromium.org, jonmann+w...@chromium.org, omnibox-...@chromium.org, pushi+wa...@google.com, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, sloboda...@chromium.org, storage...@chromium.org, tbarzi...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org
Attention needed from Elly FJ and Zoraiz Naeem

Hidehiko Abe voted and added 1 comment

Votes added by Hidehiko Abe

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Hidehiko Abe . resolved

LGTM for ash/.

Note: while I'm also an owner of chrome/*, please double check chrome/* files are reviewed by some other web browser OWNERs properly.

Open in Gerrit

Related details

Attention is currently required from:
  • Elly FJ
  • Zoraiz Naeem
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4601a9cf4a1dff3cd1f25748bfa622f3183cef7f
Gerrit-Change-Number: 7089438
Gerrit-PatchSet: 3
Gerrit-Owner: Zoraiz Naeem <zorai...@chromium.org>
Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Sylvain Defresne <sdef...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-Attention: Zoraiz Naeem <zorai...@chromium.org>
Gerrit-Attention: Elly FJ <elly...@chromium.org>
Gerrit-Comment-Date: Wed, 29 Oct 2025 04:43:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Elly FJ (Gerrit)

unread,
Oct 29, 2025, 12:39:48 PM10/29/25
to Zoraiz Naeem, Elly FJ, Chromium LUCI CQ, Hidehiko Abe, Sylvain Defresne, AyeAye, chromium...@chromium.org, Permissions Reviews, ajayramamurt...@google.com, crisrael+...@google.com, derinel+wat...@google.com, feature-me...@chromium.org, gcasto+w...@chromium.org, jackshira+...@google.com, jdonnel...@chromium.org, jonmann+w...@chromium.org, omnibox-...@chromium.org, pushi+wa...@google.com, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, sloboda...@chromium.org, storage...@chromium.org, tbarzi...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org
Attention needed from Zoraiz Naeem

Elly FJ voted and added 1 comment

Votes added by Elly FJ

Code-Review+1

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Zoraiz Naeem
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4601a9cf4a1dff3cd1f25748bfa622f3183cef7f
Gerrit-Change-Number: 7089438
Gerrit-PatchSet: 5
Gerrit-Owner: Zoraiz Naeem <zorai...@chromium.org>
Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Sylvain Defresne <sdef...@chromium.org>
Gerrit-Reviewer: Zoraiz Naeem <zorai...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-Attention: Zoraiz Naeem <zorai...@chromium.org>
Gerrit-Comment-Date: Wed, 29 Oct 2025 16:39:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Elly FJ (Gerrit)

unread,
Jan 13, 2026, 1:33:09 PM (14 hours ago) Jan 13
to Zoraiz Naeem, Elly FJ, Chromium LUCI CQ, Hidehiko Abe, Sylvain Defresne, AyeAye, chromium...@chromium.org, Permissions Reviews, jonmann+wat...@chromium.org, joeantonetti+...@google.com, jackshira+wa...@google.com, ajayramamurthy...@google.com, hansberry+wa...@chromium.org, crisrael+wa...@google.com, pushi+watc...@google.com, ajayramamurt...@google.com, crisrael+...@google.com, derinel+wat...@google.com, feature-me...@chromium.org, gcasto+w...@chromium.org, jackshira+...@google.com, jdonnel...@chromium.org, jonmann+w...@chromium.org, omnibox-...@chromium.org, pushi+wa...@google.com, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, sloboda...@chromium.org, storage...@chromium.org, tbarzi...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org
Attention needed from Hidehiko Abe, Sylvain Defresne and Zoraiz Naeem

Elly FJ voted and added 1 comment

Votes added by Elly FJ

Code-Review+1

1 comment

Patchset-level comments
Elly FJ . resolved

lgtm!

Open in Gerrit

Related details

Attention is currently required from:
  • Hidehiko Abe
  • Sylvain Defresne
  • Zoraiz Naeem
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4601a9cf4a1dff3cd1f25748bfa622f3183cef7f
Gerrit-Change-Number: 7089438
Gerrit-PatchSet: 11
Gerrit-Owner: Zoraiz Naeem <zorai...@chromium.org>
Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Sylvain Defresne <sdef...@chromium.org>
Gerrit-Reviewer: Zoraiz Naeem <zorai...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-Attention: Zoraiz Naeem <zorai...@chromium.org>
Gerrit-Attention: Sylvain Defresne <sdef...@chromium.org>
Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 18:32:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Zoraiz Naeem (Gerrit)

unread,
Jan 13, 2026, 7:05:07 PM (8 hours ago) Jan 13
to Elly FJ, Chromium LUCI CQ, Hidehiko Abe, Sylvain Defresne, AyeAye, chromium...@chromium.org, Permissions Reviews, jonmann+wat...@chromium.org, joeantonetti+...@google.com, jackshira+wa...@google.com, ajayramamurthy...@google.com, hansberry+wa...@chromium.org, crisrael+wa...@google.com, pushi+watc...@google.com, ajayramamurt...@google.com, crisrael+...@google.com, derinel+wat...@google.com, feature-me...@chromium.org, gcasto+w...@chromium.org, jackshira+...@google.com, jdonnel...@chromium.org, jonmann+w...@chromium.org, omnibox-...@chromium.org, pushi+wa...@google.com, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, sloboda...@chromium.org, storage...@chromium.org, tbarzi...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org
Attention needed from Hidehiko Abe and Sylvain Defresne

Zoraiz Naeem added 1 comment

Patchset-level comments
File-level comment, Patchset 13 (Latest):
Zoraiz Naeem . resolved

PTAL again!

Open in Gerrit

Related details

Attention is currently required from:
  • Hidehiko Abe
  • Sylvain Defresne
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4601a9cf4a1dff3cd1f25748bfa622f3183cef7f
Gerrit-Change-Number: 7089438
Gerrit-PatchSet: 13
Gerrit-Owner: Zoraiz Naeem <zorai...@chromium.org>
Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Sylvain Defresne <sdef...@chromium.org>
Gerrit-Reviewer: Zoraiz Naeem <zorai...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-Attention: Sylvain Defresne <sdef...@chromium.org>
Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
Gerrit-Comment-Date: Wed, 14 Jan 2026 00:04:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Hidehiko Abe (Gerrit)

unread,
12:36 AM (3 hours ago) 12:36 AM
to Zoraiz Naeem, Elly FJ, Chromium LUCI CQ, Sylvain Defresne, AyeAye, chromium...@chromium.org, Permissions Reviews, jonmann+wat...@chromium.org, joeantonetti+...@google.com, jackshira+wa...@google.com, ajayramamurthy...@google.com, hansberry+wa...@chromium.org, crisrael+wa...@google.com, pushi+watc...@google.com, ajayramamurt...@google.com, crisrael+...@google.com, derinel+wat...@google.com, feature-me...@chromium.org, gcasto+w...@chromium.org, jackshira+...@google.com, jdonnel...@chromium.org, jonmann+w...@chromium.org, omnibox-...@chromium.org, pushi+wa...@google.com, roblia...@chromium.org, rrsilva+wat...@google.com, sky+...@chromium.org, sloboda...@chromium.org, storage...@chromium.org, tbarzi...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org
Attention needed from Sylvain Defresne and Zoraiz Naeem

Hidehiko Abe voted and added 1 comment

Votes added by Hidehiko Abe

Code-Review+1

1 comment

Patchset-level comments
Hidehiko Abe . resolved

ash/ LGTM.

Open in Gerrit

Related details

Attention is currently required from:
  • Sylvain Defresne
  • Zoraiz Naeem
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4601a9cf4a1dff3cd1f25748bfa622f3183cef7f
Gerrit-Change-Number: 7089438
Gerrit-PatchSet: 13
Gerrit-Owner: Zoraiz Naeem <zorai...@chromium.org>
Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Sylvain Defresne <sdef...@chromium.org>
Gerrit-Reviewer: Zoraiz Naeem <zorai...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-Attention: Zoraiz Naeem <zorai...@chromium.org>
Gerrit-Attention: Sylvain Defresne <sdef...@chromium.org>
Gerrit-Comment-Date: Wed, 14 Jan 2026 05:35:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages