Reland "[ttc] Structure WebUI resources and add internal DEPS hook" [chromium/src : main]
0 views
Skip to first unread message
Gary Klassen (Gerrit)
9:46 AM (5 hours ago) 9:46 AM
to Siddhartha S, Rick Byers, Samuel Huang, chromium...@chromium.org
Attention needed from Rick Byers, Samuel Huang and Siddhartha S
Gary Klassen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Gary Klassen . resolved
It seems that I missed an important line that caused a revert. Would you be willing to review again?
Related details
Attention is currently required from:
- Rick Byers
- Samuel Huang
- Siddhartha S
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gary Klassen (Gerrit)
9:48 AM (5 hours ago) 9:48 AM
to Yue She, Siddhartha S, Rick Byers, Samuel Huang, chromium...@chromium.org
Attention needed from Rick Byers, Samuel Huang, Siddhartha S and Yue She
Gary Klassen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Gary Klassen . resolved
Adding Yue for onwners review for private_code_test.gni
Related details
Attention is currently required from:
- Rick Byers
- Samuel Huang
- Siddhartha S
- Yue She
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yue She (Gerrit)
10:15 AM (4 hours ago) 10:15 AM
to Gary Klassen, Andrew Grieve, Miguel Ruiz, Daniel Mendez, Siddhartha S, Rick Byers, Samuel Huang, chromium...@chromium.org
Attention needed from Andrew Grieve, Gary Klassen, Rick Byers, Samuel Huang and Siddhartha S
Yue She added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Gary Klassen . resolved
Adding Yue for onwners review for private_code_test.gni
Yue She
sorry I do not think I'm the right owner for reviewing this change. Looks like Andrew has made changes to this file quite a bit. So adding him as the reviewer instead
Related details
Attention is currently required from:
- Andrew Grieve
- Gary Klassen
- Rick Byers
- Samuel Huang
- Siddhartha S
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrew Grieve (Gerrit)
10:26 AM (4 hours ago) 10:26 AM
to Gary Klassen, Andrew Grieve, Miguel Ruiz, Daniel Mendez, Siddhartha S, Rick Byers, Samuel Huang, chromium...@chromium.org
Attention needed from Gary Klassen, Rick Byers, Samuel Huang and Siddhartha S
Andrew Grieve voted and added 1 comment![]( "Open in Gerrit")
Votes added by Andrew Grieve
| Code-Review | +1 |
1 comment
File build/private_code_test/private_code_test.gni
Line 16, Patchset 1 (Latest):
"../../chrome/browser/ttc/resources/internal/*",Andrew Grieve . unresolved
Will this have a .grd that mirrors a public one, or is it just extra .ts source files?
If just the .ts files, can you make a new section:
```
# Internal-only webui resources (but no .grd)
```
Related details
Attention is currently required from:
- Gary Klassen
- Rick Byers
- Samuel Huang
- Siddhartha S
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Huang (Gerrit)
10:40 AM (4 hours ago) 10:40 AM
to Gary Klassen, Andrew Grieve, Miguel Ruiz, Daniel Mendez, Siddhartha S, Rick Byers, chromium...@chromium.org
Attention needed from Gary Klassen, Rick Byers and Siddhartha S
Samuel Huang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Samuel Huang
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Gary Klassen
- Rick Byers
- Siddhartha S
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rick Byers (Gerrit)
11:11 AM (4 hours ago) 11:11 AM
to Gary Klassen, Samuel Huang, Andrew Grieve, Miguel Ruiz, Daniel Mendez, Siddhartha S, chromium...@chromium.org
Attention needed from Gary Klassen and Siddhartha S
Rick Byers voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Gary Klassen
- Siddhartha S
Gary Klassen (Gerrit)
11:31 AM (3 hours ago) 11:31 AM
to Rick Byers, Samuel Huang, Andrew Grieve, Miguel Ruiz, Daniel Mendez, Siddhartha S, chromium...@chromium.org
Attention needed from Siddhartha S
Gary Klassen added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Gary Klassen . resolved
Thanks for the reviews, comment addressed with thanks!
File build/private_code_test/private_code_test.gni
Will this have a .grd that mirrors a public one, or is it just extra .ts source files?
If just the .ts files, can you make a new section:
```
# Internal-only webui resources (but no .grd)
```
Attention is currently required from:
- Siddhartha S
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages