[Settings Search] Set max length for title and summary [chromium/src : main]

0 views

Skip to first unread message

Moe Adel (Gerrit)

unread,

3:02 PM (6 hours ago) 3:02 PM

to Jinsuk Kim, chromium...@chromium.org

Attention needed from Jinsuk Kim

Moe Adel voted and added 1 comment

Votes added by Moe Adel

Commit-Queue

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Moe Adel . resolved

Hi, please take a look :)

Open in Gerrit

Related details

Attention is currently required from:

Jinsuk Kim

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jinsuk Kim (Gerrit)

unread,

6:32 PM (2 hours ago) 6:32 PM

to Moe Adel, Chromium LUCI CQ, chromium...@chromium.org

Attention needed from Moe Adel

Jinsuk Kim voted and added 2 comments

Votes added by Jinsuk Kim

Code-Review

2 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Jinsuk Kim . resolved

Nice fix. Thanks! LGTM % one suggestion

File chrome/android/java/src/org/chromium/chrome/browser/settings/search/SearchResultsPreferenceFragment.java

Line 144, Patchset 3 (Latest): }

Jinsuk Kim . unresolved

Please remove the listener here.