Support wasm for ssh in Terminal [chromium/src : main]

Joel Hockey (Gerrit)

unread,

Aug 9, 2022, 1:05:03 AM8/9/22

to Joel Hockey, chromium-a...@chromium.org, extension...@chromium.org, Xiyuan Xia, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury

Attention is currently required from: Xiyuan Xia.

View Change

To view, visit change 3818745. To unsubscribe, or for help writing mail filters, visit settings.

Xiyuan Xia (Gerrit)

unread,

Aug 9, 2022, 12:35:45 PM8/9/22

to Joel Hockey, chromium-a...@chromium.org, extension...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury

Attention is currently required from: Joel Hockey.

Patch set 1:Code-Review +1

View Change

2 comments:

Patchset:
- Patch Set #1:
  lgtm % 2 requests
File extensions/browser/api/socket/socket_api.cc:
- Patch Set #1, Line 176: DCHECK_EQ(url::Origin::Create(source_url()),
  I wonder whether we should enforce it in production, here and in `CheckRequest`.
  e.g.
```
```
    return url::Origin::Create(source_url()) ==
        url::Origin::Create(GURL("chrome-untrusted://terminal")));
```
```

To view, visit change 3818745. To unsubscribe, or for help writing mail filters, visit settings.

Joel Hockey (Gerrit)

unread,

Aug 9, 2022, 7:40:41 PM8/9/22

to Joel Hockey, chromium-a...@chromium.org, extension...@chromium.org, Xiyuan Xia, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury

View Change

1 comment:

File extensions/browser/api/socket/socket_api.cc:

- Patch Set #1, Line 176: DCHECK_EQ(url::Origin::Create(source_url()),

- I wonder whether we should enforce it in production, here and in `CheckRequest`. […]
  Done, also added IS_CHROMEOS_ASH guards.

To view, visit change 3818745. To unsubscribe, or for help writing mail filters, visit settings.

Xiyuan Xia (Gerrit)

unread,

Aug 9, 2022, 8:56:26 PM8/9/22

to Joel Hockey, chromium-a...@chromium.org, extension...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury

Attention is currently required from: Joel Hockey.

Patch set 4:Code-Review +1

View Change

1 comment:

Patchset:
- Patch Set #4:
  slgtm
  Thanks.

To view, visit change 3818745. To unsubscribe, or for help writing mail filters, visit settings.

Joel Hockey (Gerrit)

unread,

Aug 9, 2022, 9:04:51 PM8/9/22

to Joel Hockey, chromium-a...@chromium.org, extension...@chromium.org, Xiyuan Xia, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury

Attention is currently required from: Joel Hockey.

Patch set 4:Commit-Queue +2

View Change

To view, visit change 3818745. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Aug 9, 2022, 10:10:22 PM8/9/22

to Joel Hockey, chromium-a...@chromium.org, extension...@chromium.org, Xiyuan Xia, chromium...@chromium.org, Sadrul Chowdhury

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Xiyuan Xia: Looks good to me
  Joel Hockey: Commit

Support wasm for ssh in Terminal

Wasm SSH requires update to CSP:
* script-src 'self' 'wasm-unsafe-eval';
* worker-src 'self';

And also access to chrome.sockets.tcp. The sockets API code currently
assumes that it is always running inside an extension, so some
refactoring is required to run inside webui.

Bug: 1350479
Change-Id: I84c70ad87aadfdedb5091903387b8048542b2ddd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3818745
Commit-Queue: Joel Hockey <joelh...@chromium.org>
Reviewed-by: Xiyuan Xia <xiy...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1033315}
---
M chrome/browser/ash/web_applications/terminal_source.cc
M extensions/browser/api/socket/socket_api.cc
M extensions/browser/api/socket/socket_api.h
M extensions/browser/api/sockets_tcp/sockets_tcp_api.cc
M extensions/common/api/_api_features.json
5 files changed, 106 insertions(+), 29 deletions(-)

To view, visit change 3818745. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward