[DCSI] Implement CompoundImagebacking::GetNativePixmap(). [chromium/src : main]
0 views
Skip to first unread message
Vikas Soni (Gerrit)
Dec 11, 2025, 4:08:25 PM (5 days ago) Dec 11
to Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Vasiliy Telezhnikov
Vikas Soni voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vikas Soni
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
Dec 12, 2025, 9:55:16 AM (4 days ago) Dec 12
to Vikas Soni, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Vikas Soni
Vasiliy Telezhnikov voted and added 2 comments![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Code-Review | +1 |
2 comments
Patchset-level comments
Vasiliy Telezhnikov . resolved
lgtm % nit, thanks.
File gpu/command_buffer/service/shared_image/compound_image_backing.cc
Line 949, Patchset 1 (Latest):
// Note that there are only 2 backings which currently has pixmaps,i.e.,Vasiliy Telezhnikov . unresolved
nit: The purpose of this function is to get NativePixmap for overlay testing, so it needs be the same NativePixmap that we would later get from the ProduceOverlay representation (otherwise test might pass, but real commit fail).
Can we just get backing for overlay stream here?
Related details
Attention is currently required from:
- Vikas Soni
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vikas Soni (Gerrit)
Dec 15, 2025, 1:32:47 PM (20 hours ago) Dec 15
to Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org
Vikas Soni voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vikas Soni
| Auto-Submit | +1 |
| Commit-Queue | +2 |
1 comment
File gpu/command_buffer/service/shared_image/compound_image_backing.cc
Line 949, Patchset 1:
// Note that there are only 2 backings which currently has pixmaps,i.e.,Vasiliy Telezhnikov . resolved
nit: The purpose of this function is to get NativePixmap for overlay testing, so it needs be the same NativePixmap that we would later get from the ProduceOverlay representation (otherwise test might pass, but real commit fail).
Can we just get backing for overlay stream here?
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 15, 2025, 2:52:41 PM (19 hours ago) Dec 15
to Vikas Soni, Vasiliy Telezhnikov, chromium...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: gpu/command_buffer/service/shared_image/compound_image_backing.cc
Insertions: 6, Deletions: 12.
@@ -946,19 +946,13 @@
}
scoped_refptr<gfx::NativePixmap> CompoundImageBacking::GetNativePixmap() {
- // Note that there are only 2 backings which currently has pixmaps,i.e.,
- // OzoneImageBacking and ExternalVkImageBacking. Currently
- // CompoundImageBacking only allocates 1 gpu backing at max. So only one of
- // them will be ever allocated.
- // TODO(crbug.com/448962784): In future with DCSI, multiple backings of
- // different types can be allocated. If there are multiple backing which
- // supports GetNativePixmap(), then we will need to update this code to get
- // the pixmap from the correct backing.
+ // The purpose of this function is to get NativePixmap for overlay testing,
+ // so it needs be the same NativePixmap that we would later get from the
+ // ProduceOverlay representation. Hence using Overlay stream backing here.
for (const auto& element : elements_) {
- if (element.backing) {
- if (auto pixmap = element.backing->GetNativePixmap()) {
- return pixmap;
- }
+ if (element.access_streams.Has(SharedImageAccessStream::kOverlay) &&
+ element.backing) {
+ return element.backing->GetNativePixmap();
}
}
return nullptr;
```
Change information
Commit message:
[DCSI] Implement CompoundImagebacking::GetNativePixmap().
Implement CompoundImagebacking::GetNativePixmap(). This iterates over
all the underlying backings and returns a valid pixmap if any.
It is needed to support future architecture where CompoundImageBacking
will wrap one or more underlying backings and be the primary backing
itself.
Bug: 448962784
Change-Id: Iec3fdbea9ccd6171ac521deda2a80f12626be9ab
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Auto-Submit: Vikas Soni <vika...@chromium.org>
Commit-Queue: Vikas Soni <vika...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1558899}
Files:
- M gpu/command_buffer/service/shared_image/compound_image_backing.cc
- M gpu/command_buffer/service/shared_image/compound_image_backing.h
Change size: S
Delta: 2 files changed, 14 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Vasiliy Telezhnikov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages