Add libu2f-udev as a Recommends on Debian builds. [chromium/src : master]
Philipp Kern (Gerrit)
This change is ready for review.
To view, visit change 924193. To unsubscribe, or for help writing mail filters, visit settings.
Michael Moss (Gerrit)
Patch set 1:Code-Review +1
1 comment:
File extensions/shell/installer/linux/debian/build.sh:
Patch Set #1, Line 293:
COMMON_RECOMMENDS="${ADDITIONAL_RECOMMENDS}"Nit: I don't think this needs the separate COMMON and ADDITIONAL vars. ADDITIONAL_DEPS only exists because it's added to the calculated DPKG_SHLIB_DEPS, but that's not the case with RECOMMENDS. Just add the libu2f stuff directly to COMMON_RECOMMENDS.
To view, visit change 924193. To unsubscribe, or for help writing mail filters, visit settings.
Michael Giuffrida (Gerrit)
1 comment:
File extensions/shell/installer/linux/debian/build.sh:
Patch Set #1, Line 279:
ADDITIONAL_RECOMMENDS="libu2f-udev"I doubt this is necessary. Think of AppShell like CrOS kiosk mode -- AppShell users won't be registering security keys, and it's up to system administrators to decide what packages to install.
Unless GVC actually uses 2FA somewhere?
To view, visit change 924193. To unsubscribe, or for help writing mail filters, visit settings.
Philipp Kern
Philipp Kern (Gerrit)
They do. You need the Corp account to install a GVC.
Philipp Kern (Gerrit)
Patch Set 1:
They do. You need the Corp account to install a GVC.
And to be a little less terse: You also need u2f to enterprise enroll a Chromebox for Meetings if the GSuite account requires that for sign-in. In this case there's of course the point that GVC is unlikely to rebase onto a distribution that has this split. But it also shouldn't hurt given that it's an optional dependency.
Michael Giuffrida (Gerrit)
Patch Set 1:
Patch Set 1:
They do. You need the Corp account to install a GVC.
And to be a little less terse: You also need u2f to enterprise enroll a Chromebox for Meetings if the GSuite account requires that for sign-in. In this case there's of course the point that GVC is unlikely to rebase onto a distribution that has this split. But it also shouldn't hurt given that it's an optional dependency.
GVC setup will still be done with Chrome, but ideally we could make that work in AppShell so I see your point.
Patch set 2:Code-Review +1
Philipp Kern (Gerrit)
Patch set 2:Commit-Queue +2
Commit Bot (Gerrit)
Commit Bot merged this change by Philipp Kern.
Add libu2f-udev as a Recommends on Debian builds.
u2f udev rules have moved from being installed by default by systemd
on Debian systems to a separate package called libu2f-udev. This change
pulls the package onto the system if it is available (= Recommends).
Bug: 813501
Change-Id: I02c05317ad00acc3efd0273769ec415ad61b8af6
Reviewed-on: https://chromium-review.googlesource.com/924193
Reviewed-by: Michael Giuffrida <mich...@chromium.org>
Reviewed-by: Michael Moss <mm...@chromium.org>
Commit-Queue: Philipp Kern <pk...@google.com>
Cr-Commit-Position: refs/heads/master@{#538050}
---
M chrome/installer/linux/common/installer.include
M chrome/installer/linux/debian/build.sh
M chrome/installer/linux/debian/control.template
M extensions/shell/installer/linux/debian/build.sh
4 files changed, 6 insertions(+), 0 deletions(-)