Lei Zhang (Gerrit)

unread,

Dec 5, 2025, 4:09:37 PM (12 hours ago) Dec 5

to Lei Zhang, Daniel Cheng, Chromium LUCI CQ, Andrew Williams, chromium...@chromium.org, Dustin Mitchell, (Julie)Jeongeun Kim, Permissions Reviews, Rijubrata Bhaumik, Sadrul Chowdhury, James Su, aakalla...@chromium.org, abigailbk...@google.com, antoniosarto...@chromium.org, arthursonzog...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, cfredri...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, cros-print...@google.com, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, ipc-securi...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kinuko+...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, mfoltz+wa...@chromium.org, mkwst+w...@chromium.org, msrame...@chromium.org, nektar...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, ortuno...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, print-rev...@chromium.org, rizvis...@google.com, shuche...@chromium.org, storage...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, yuzo+...@chromium.org

Attention needed from Daniel Cheng

Lei Zhang added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Lei Zhang . resolved

Please OO+1. Will rebase after the is_callback.h cleanup CL lands.

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Dec 5, 2025, 4:12:22 PM (12 hours ago) Dec 5

to Lei Zhang, Daniel Cheng, Chromium LUCI CQ, Andrew Williams, chromium...@chromium.org, Dustin Mitchell, (Julie)Jeongeun Kim, Permissions Reviews, Rijubrata Bhaumik, Sadrul Chowdhury, James Su, aakalla...@chromium.org, abigailbk...@google.com, antoniosarto...@chromium.org, arthursonzog...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, cfredri...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, cros-print...@google.com, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, ipc-securi...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kinuko+...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, mfoltz+wa...@chromium.org, mkwst+w...@chromium.org, msrame...@chromium.org, nektar...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, ortuno...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, print-rev...@chromium.org, rizvis...@google.com, shuche...@chromium.org, storage...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, yuzo+...@chromium.org

Attention needed from Lei Zhang

Daniel Cheng voted

Code-Review	+1
Owners-Override	+1

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Dec 5, 2025, 9:28:50 PM (6 hours ago) Dec 5

to Lei Zhang, Daniel Cheng, Chromium LUCI CQ, Andrew Williams, chromium...@chromium.org, Dustin Mitchell, (Julie)Jeongeun Kim, Permissions Reviews, Rijubrata Bhaumik, Sadrul Chowdhury, James Su, aakalla...@chromium.org, abigailbk...@google.com, antoniosarto...@chromium.org, arthursonzog...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, cfredri...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, cros-print...@google.com, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, ipc-securi...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kinuko+...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, mfoltz+wa...@chromium.org, mkwst+w...@chromium.org, msrame...@chromium.org, nektar...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, ortuno...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, print-rev...@chromium.org, rizvis...@google.com, shuche...@chromium.org, storage...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, yuzo+...@chromium.org

Lei Zhang voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Dec 5, 2025, 9:32:56 PM (6 hours ago) Dec 5

to Lei Zhang, Daniel Cheng, Akihiro Ota, Andrew Williams, chromium...@chromium.org, Dustin Mitchell, (Julie)Jeongeun Kim, Permissions Reviews, Rijubrata Bhaumik, Sadrul Chowdhury, James Su, aakalla...@chromium.org, abigailbk...@google.com, antoniosarto...@chromium.org, arthursonzog...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, cfredri...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, cros-print...@google.com, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, ipc-securi...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kinuko+...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, mfoltz+wa...@chromium.org, mkwst+w...@chromium.org, msrame...@chromium.org, nektar...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, ortuno...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, print-rev...@chromium.org, rizvis...@google.com, shuche...@chromium.org, storage...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org, yuzo+...@chromium.org

Chromium LUCI CQ submitted the change

Unreviewed changes

3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

Do IWYU for base/notreached.h in various files

Selectively add notreached.h to some files that use it. This is split
off from an upcoming //mojo change that breaks the build for the files
in this CL.

Change-Id: I2c44fa85752b0ce4d124ad8ef726872ae5656123

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7225565

Commit-Queue: Lei Zhang <the...@chromium.org>

Reviewed-by: Daniel Cheng <dch...@chromium.org>

Owners-Override: Daniel Cheng <dch...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1555036}

Files:

M cc/mojom/hit_test_opaqueness_mojom_traits.h
M cc/mojom/paint_flags_mojom_traits.h
M cc/tiles/image_decode_cache_utils.cc
M chrome/browser/download/download_item_warning_data.cc
M chrome/browser/permissions/quiet_permission_prompt_model_android.cc
M chrome/browser/permissions/system/system_permission_settings_default.cc
M chrome/browser/privacy_sandbox/notice/notice_model.cc
M chrome/browser/ui/safety_hub/revoked_permissions_result.cc
M chrome/browser/ui/views/screen_sharing_util.cc
M chrome/browser/ui/webui/tabs/tabs_mojom_traits.cc
M chrome/common/extensions/permissions/chrome_permission_message_rules.cc
M chrome/common/extensions/sync_helper.cc
M chromeos/ui/base/display_util.cc
M components/account_id/mojom/account_id_traits.h
M components/content_settings/core/browser/permission_settings_info.cc
M components/favicon/content/favicon_url_util.cc
M components/remote_cocoa/common/font_mojom_traits.h
M extensions/common/api/extension_action/action_info.cc
M extensions/common/extension.cc
M extensions/common/utils/extension_types_utils.cc
M gpu/ipc/common/device_perf_info_mojom_traits.cc
M gpu/ipc/common/generate_vulkan_types.py
M gpu/ipc/common/vulkan_types_mojom_traits.h
M media/capture/mojom/video_capture_types_mojom_traits.cc
M mojo/public/cpp/base/application_state_mojom_traits.cc
M mojo/public/cpp/base/memory_pressure_level_mojom_traits.cc
M mojo/public/cpp/base/message_pump_type_mojom_traits.cc
M mojo/public/cpp/base/text_direction_mojom_traits.cc
M mojo/public/cpp/bindings/lib/native_handle_type_converters.cc
M mojo/public/cpp/bindings/lib/pipe_control_message_handler.cc
M printing/backend/mojom/print_backend_mojom_traits.cc
M printing/print_settings_unittest.cc
M services/network/public/cpp/address_family_mojom_traits.cc
M services/network/public/cpp/content_security_policy/csp_context.cc
M services/network/public/cpp/first_party_sets_mojom_traits.cc
M services/network/public/cpp/request_mode.cc
M services/network/public/cpp/source_type_mojom_traits.cc
M services/network/public/cpp/url_request_param_mojom_traits.cc
M services/viz/public/cpp/compositing/begin_frame_args_mojom_traits.cc
M services/viz/public/cpp/compositing/shared_image_format_mojom_traits.cc
M services/viz/public/cpp/compositing/thread_mojom_traits.cc
M storage/browser/file_system/file_system_url.cc
M third_party/blink/common/fenced_frame/redacted_fenced_frame_config_mojom_traits.cc
M third_party/blink/common/safe_url_pattern_mojom_traits.cc
M ui/accessibility/ax_enum_localization_util.cc
M ui/accessibility/ax_enum_test_util.cc
M ui/accessibility/mojom/ax_tree_id_mojom_traits.cc
M ui/base/accelerators/mojom/accelerator_mojom_traits.h
M ui/base/ime/mojom/ime_types_mojom_traits.cc
M ui/base/ime/mojom/text_edit_command_mojom_traits.cc
M ui/display/display_util.cc
M ui/display/mojom/display_constants_mojom_traits.cc
M ui/display/mojom/display_layout_mojom_traits.cc
M ui/display/screen_info.cc
M ui/gfx/linux/client_native_pixmap_factory_dmabuf.cc
M ui/gfx/mojom/ca_layer_result_mojom_traits.cc
M ui/latency/mojom/latency_info_mojom_traits.cc

Change size: M

Delta: 57 files changed, 78 insertions(+), 2 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Daniel Cheng

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Do IWYU for base/notreached.h in various files [chromium/src : main]

Lei Zhang (Gerrit)

Lei Zhang added 1 comment

Related details

Daniel Cheng (Gerrit)

Daniel Cheng voted

Related details

Lei Zhang (Gerrit)

Lei Zhang voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Unreviewed changes

Change information