Retain V8 session while building objects for event listeners [chromium/src : main]

0 views

Skip to first unread message

AI Code Reviewer (Gerrit)

unread,

2:40 PM (6 hours ago) 2:40 PM

to Andrey Kosyakov, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, devtools...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, dmurph+wa...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org

AI Code Reviewer added 1 comment

File third_party/blink/renderer/core/inspector/inspector_base_agent.h

Line 97, Patchset 1 (Latest): V8SessionHolder v8_session() const { return v8_session_; }

AI Code Reviewer . unresolved

nit: Blink Style Guide: Naming - Use 'CamelCase' for all function names. Consider renaming `v8_session` to `V8Session`.

To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason

_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Andrey Kosyakov (Gerrit)

unread,

7:19 PM (2 hours ago) 7:19 PM

to Alex Rudenko, Philip Pfaffe, AI Code Reviewer, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, devtools...@chromium.org, Olga Gerchikov, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, dmurph+wa...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org

Attention needed from Alex Rudenko and Philip Pfaffe

Andrey Kosyakov voted and added 1 comment

Votes added by Andrey Kosyakov

Commit-Queue

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Andrey Kosyakov . resolved

PTAL. There will be some V8-side fixes too, as we're not supposed to run custom formatters in this scenario.

Open in Gerrit

Related details

Attention is currently required from:

Alex Rudenko
Philip Pfaffe

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages