Glic: Restrict OnMemoryPressure refills to memory pressure recovery [chromium/src : main]
0 views
Skip to first unread message
Patrick Monette (Gerrit)
10:54 AM (8 hours ago) 10:54 AM
to Bryant Chandler, Chromium LUCI CQ, chromium...@chromium.org, dewitt...@chromium.org
Attention needed from Bryant Chandler
Patrick Monette added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Patrick Monette . resolved
Sorry I made some mistakes in the previous CL. PTAL
Related details
Attention is currently required from:
- Bryant Chandler
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Bryant Chandler (Gerrit)
12:58 PM (6 hours ago) 12:58 PM
to Patrick Monette, Chromium LUCI CQ, chromium...@chromium.org, dewitt...@chromium.org
Attention needed from Patrick Monette
Bryant Chandler added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Bryant Chandler . unresolved
I think we want to hold something more like a variable that tells us if we had a warmed container (or an attempt to warm a container) before experiencing memory pressure. It seems like that would generalize the best.
Related details
Attention is currently required from:
- Patrick Monette
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Monette (Gerrit)
2:49 PM (4 hours ago) 2:49 PM
to Bryant Chandler, Chromium LUCI CQ, chromium...@chromium.org, dewitt...@chromium.org
Attention needed from Bryant Chandler
Patrick Monette added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Bryant Chandler . unresolved
I think we want to hold something more like a variable that tells us if we had a warmed container (or an attempt to warm a container) before experiencing memory pressure. It seems like that would generalize the best.
Patrick Monette
I went with an is_active_ boolean that indicates that we wanna have a prewarmed container at all time if permitted by memory pressure. WDYT?
Related details
Attention is currently required from:
- Bryant Chandler
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages