chromiumdash_promoter - use recipe modules api instead of raw git command [infra/infra : main]
Alex Kravchuk (Gerrit)
Alex Kravchuk added 2 comments![]( "Open in Gerrit")
from PB.recipe_engine.result import RawResultNit: looks like the imports are not sorted. Probably something git cl format can handle?
return RawResult(status=common_pb2.SUCCESS, summary_markdown=summary)I think we should keep the summary short, because it should ideally be readable from the builder page, without the need to expand the build.
I think we can omit "executed successfully", because this is something we can see from the build status anyway.
I would suggest either "Nothing to deploy" or "Created <link to CL>" for the result depending on the outcome.
Related details
- Olek Nuszel
- Vadim Shtayura
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olek Nuszel (Gerrit)
Olek Nuszel added 2 comments![]( "Open in Gerrit")
from PB.recipe_engine.result import RawResultNit: looks like the imports are not sorted. Probably something git cl format can handle?
Mine doesn't seem to do that. I left it the same way we have in recipe_promoter
return RawResult(status=common_pb2.SUCCESS, summary_markdown=summary)I think we should keep the summary short, because it should ideally be readable from the builder page, without the need to expand the build.
I think we can omit "executed successfully", because this is something we can see from the build status anyway.
I would suggest either "Nothing to deploy" or "Created <link to CL>" for the result depending on the outcome.
Ok, I kept short now. I'm not adding the link now since we don't have direct access to that in code and it's need to be parsed. I'll add that to the followup task from TODO: b/451878525. Anyway, we'll get notified with the CL from gerrit directly.
Related details
- Alex Kravchuk
- Vadim Shtayura
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Kravchuk (Gerrit)
Alex Kravchuk added 2 comments![]( "Open in Gerrit")
from PB.recipe_engine.result import RawResultOlek NuszelNit: looks like the imports are not sorted. Probably something git cl format can handle?
Mine doesn't seem to do that. I left it the same way we have in recipe_promoter
This is how Cider sorts it:
```
import base64
import json
from PB.go.chromium.org.luci.buildbucket.proto import common as common_pb2
from PB.recipe_engine.result import RawResult
from recipe_engine import post_process
```
return RawResult(status=common_pb2.SUCCESS, summary_markdown=summary)Olek NuszelI think we should keep the summary short, because it should ideally be readable from the builder page, without the need to expand the build.
I think we can omit "executed successfully", because this is something we can see from the build status anyway.
I would suggest either "Nothing to deploy" or "Created <link to CL>" for the result depending on the outcome.
Ok, I kept short now. I'm not adding the link now since we don't have direct access to that in code and it's need to be parsed. I'll add that to the followup task from TODO: b/451878525. Anyway, we'll get notified with the CL from gerrit directly.
I think it should be pretty easy to do with `git_cl.issue`, but leaving it up to you.
Related details
- Olek Nuszel
- Vadim Shtayura
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olek Nuszel (Gerrit)
Olek Nuszel added 2 comments![]( "Open in Gerrit")
from PB.recipe_engine.result import RawResultOlek NuszelNit: looks like the imports are not sorted. Probably something git cl format can handle?
Alex KravchukMine doesn't seem to do that. I left it the same way we have in recipe_promoter
This is how Cider sorts it:
```
import base64
import jsonfrom PB.go.chromium.org.luci.buildbucket.proto import common as common_pb2
from PB.recipe_engine.result import RawResult
from recipe_engine import post_process
```
Done
return RawResult(status=common_pb2.SUCCESS, summary_markdown=summary)Olek NuszelI think we should keep the summary short, because it should ideally be readable from the builder page, without the need to expand the build.
I think we can omit "executed successfully", because this is something we can see from the build status anyway.
I would suggest either "Nothing to deploy" or "Created <link to CL>" for the result depending on the outcome.
Alex KravchukOk, I kept short now. I'm not adding the link now since we don't have direct access to that in code and it's need to be parsed. I'll add that to the followup task from TODO: b/451878525. Anyway, we'll get notified with the CL from gerrit directly.
I think it should be pretty easy to do with `git_cl.issue`, but leaving it up to you.
- Alex Kravchuk
- Vadim Shtayura
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Kravchuk (Gerrit)
Alex Kravchuk voted Code-Review+1![]( "Open in Gerrit")
- Olek Nuszel
- Vadim Shtayura
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vadim Shtayura (Gerrit)
Vadim Shtayura voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
- Olek Nuszel
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olek Nuszel (Gerrit)
Olek Nuszel voted Commit-Queue+2![]( "Open in Gerrit")
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
LUCI CQ (Gerrit)
LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
chromiumdash_promoter - use recipe modules api instead of raw git command
This change fixes chromiumdash_promoter as raw git command doesnt contain allow 'cl upload'. Also it includes minor changes on luci-notifications
- M recipes/README.recipes.md
- M recipes/recipes/chromiumdash_promoter.py
Code-Review: +1 by Vadim Shtayura, +1 by Alex Kravchuk
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |