[AutofillAi - PI] Implement Android private inference notice. [chromium/src : main]

0 views
Skip to first unread message

Norge Vizcay (Gerrit)

unread,
Jul 7, 2026, 9:01:03 AM (yesterday) Jul 7
to Timofey Chudakov, Chromium LUCI CQ, Moe Adel, Chromium Metrics Reviews, chromium...@chromium.org, Jinsuk Kim, armalhotra+a...@google.com, asvitkine...@chromium.org, browser-comp...@chromium.org, osaul+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com
Attention needed from Timofey Chudakov

Norge Vizcay voted and added 1 comment

Votes added by Norge Vizcay

Code-Review+1

1 comment

File components/autofill_strings.grdp
Line 1385, Patchset 1 (Latest): To improve suggestions and fill forms faster, the content and URLs of the pages you visit can be processed in a private space in the cloud.
Norge Vizcay . unresolved

Is this the final string? The mocks show a different string. https://screenshot.googleplex.com/h5Mjw4JYddnbgKz

Open in Gerrit

Related details

Attention is currently required from:
  • Timofey Chudakov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2f39372ad99400481c0c5057acab3f0bd1442ae3
Gerrit-Change-Number: 8036906
Gerrit-PatchSet: 1
Gerrit-Owner: Timofey Chudakov <tchu...@google.com>
Gerrit-Reviewer: Norge Vizcay <viz...@google.com>
Gerrit-Reviewer: Timofey Chudakov <tchu...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Jinsuk Kim <jins...@chromium.org>
Gerrit-CC: Moe Adel <ad...@google.com>
Gerrit-Attention: Timofey Chudakov <tchu...@google.com>
Gerrit-Comment-Date: Tue, 07 Jul 2026 13:00:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Timofey Chudakov (Gerrit)

unread,
Jul 7, 2026, 9:07:04 AM (yesterday) Jul 7
to Bruno Braga, Lijin Shen, Michael van Ouwerkerk, Norge Vizcay, Chromium LUCI CQ, Moe Adel, Chromium Metrics Reviews, chromium...@chromium.org, Jinsuk Kim, armalhotra+a...@google.com, asvitkine...@chromium.org, browser-comp...@chromium.org, osaul+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com
Attention needed from Bruno Braga, Lijin Shen, Michael van Ouwerkerk and Norge Vizcay

Timofey Chudakov added 1 comment

File components/autofill_strings.grdp
Line 1385, Patchset 1 (Latest): To improve suggestions and fill forms faster, the content and URLs of the pages you visit can be processed in a private space in the cloud.
Norge Vizcay . unresolved

Is this the final string? The mocks show a different string. https://screenshot.googleplex.com/h5Mjw4JYddnbgKz

Timofey Chudakov

Yes, this should be the final string from the document: http://shortn/_STb44kLRJY

Open in Gerrit

Related details

Attention is currently required from:
  • Bruno Braga
  • Lijin Shen
  • Michael van Ouwerkerk
  • Norge Vizcay
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2f39372ad99400481c0c5057acab3f0bd1442ae3
Gerrit-Change-Number: 8036906
Gerrit-PatchSet: 1
Gerrit-Owner: Timofey Chudakov <tchu...@google.com>
Gerrit-Reviewer: Bruno Braga <bruno...@google.com>
Gerrit-Reviewer: Lijin Shen <laz...@google.com>
Gerrit-Reviewer: Michael van Ouwerkerk <mvanou...@chromium.org>
Gerrit-Reviewer: Norge Vizcay <viz...@google.com>
Gerrit-Reviewer: Timofey Chudakov <tchu...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Jinsuk Kim <jins...@chromium.org>
Gerrit-CC: Moe Adel <ad...@google.com>
Gerrit-Attention: Lijin Shen <laz...@google.com>
Gerrit-Attention: Norge Vizcay <viz...@google.com>
Gerrit-Attention: Bruno Braga <bruno...@google.com>
Gerrit-Attention: Michael van Ouwerkerk <mvanou...@chromium.org>
Gerrit-Comment-Date: Tue, 07 Jul 2026 13:06:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Norge Vizcay <viz...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael van Ouwerkerk (Gerrit)

unread,
Jul 7, 2026, 9:08:15 AM (yesterday) Jul 7
to Timofey Chudakov, Michael van Ouwerkerk, Bruno Braga, Lijin Shen, Norge Vizcay, Chromium LUCI CQ, Moe Adel, Chromium Metrics Reviews, chromium...@chromium.org, Jinsuk Kim, armalhotra+a...@google.com, asvitkine...@chromium.org, browser-comp...@chromium.org, osaul+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com
Attention needed from Bruno Braga, Lijin Shen, Norge Vizcay and Timofey Chudakov

Michael van Ouwerkerk voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Bruno Braga
  • Lijin Shen
  • Norge Vizcay
  • Timofey Chudakov
Gerrit-Attention: Timofey Chudakov <tchu...@google.com>
Gerrit-Attention: Bruno Braga <bruno...@google.com>
Gerrit-Comment-Date: Tue, 07 Jul 2026 13:07:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Bruno Braga (Gerrit)

unread,
Jul 7, 2026, 9:40:04 AM (yesterday) Jul 7
to Timofey Chudakov, Michael van Ouwerkerk, Lijin Shen, Norge Vizcay, Chromium LUCI CQ, Moe Adel, Chromium Metrics Reviews, chromium...@chromium.org, Jinsuk Kim, armalhotra+a...@google.com, asvitkine...@chromium.org, browser-comp...@chromium.org, osaul+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com
Attention needed from Lijin Shen, Norge Vizcay and Timofey Chudakov

Bruno Braga voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
Gerrit-Comment-Date: Tue, 07 Jul 2026 13:39:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Lijin Shen (Gerrit)

unread,
Jul 7, 2026, 12:30:02 PM (21 hours ago) Jul 7
to Timofey Chudakov, Bruno Braga, Michael van Ouwerkerk, Norge Vizcay, Chromium LUCI CQ, Moe Adel, Chromium Metrics Reviews, chromium...@chromium.org, Jinsuk Kim, armalhotra+a...@google.com, asvitkine...@chromium.org, browser-comp...@chromium.org, osaul+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com
Attention needed from Norge Vizcay and Timofey Chudakov

Lijin Shen voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Norge Vizcay
  • Timofey Chudakov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2f39372ad99400481c0c5057acab3f0bd1442ae3
Gerrit-Change-Number: 8036906
Gerrit-PatchSet: 1
Gerrit-Owner: Timofey Chudakov <tchu...@google.com>
Gerrit-Reviewer: Bruno Braga <bruno...@google.com>
Gerrit-Reviewer: Lijin Shen <laz...@google.com>
Gerrit-Reviewer: Michael van Ouwerkerk <mvanou...@chromium.org>
Gerrit-Reviewer: Norge Vizcay <viz...@google.com>
Gerrit-Reviewer: Timofey Chudakov <tchu...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Jinsuk Kim <jins...@chromium.org>
Gerrit-CC: Moe Adel <ad...@google.com>
Gerrit-Attention: Norge Vizcay <viz...@google.com>
Gerrit-Attention: Timofey Chudakov <tchu...@google.com>
Gerrit-Comment-Date: Tue, 07 Jul 2026 16:29:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Norge Vizcay (Gerrit)

unread,
3:07 AM (7 hours ago) 3:07 AM
to Timofey Chudakov, Lijin Shen, Bruno Braga, Michael van Ouwerkerk, Chromium LUCI CQ, Moe Adel, Chromium Metrics Reviews, chromium...@chromium.org, Jinsuk Kim, armalhotra+a...@google.com, asvitkine...@chromium.org, browser-comp...@chromium.org, osaul+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com
Attention needed from Timofey Chudakov

Norge Vizcay added 1 comment

File components/autofill_strings.grdp
Line 1385, Patchset 1 (Latest): To improve suggestions and fill forms faster, the content and URLs of the pages you visit can be processed in a private space in the cloud.
Norge Vizcay . resolved

Is this the final string? The mocks show a different string. https://screenshot.googleplex.com/h5Mjw4JYddnbgKz

Timofey Chudakov

Yes, this should be the final string from the document: http://shortn/_STb44kLRJY

Norge Vizcay

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:
  • Timofey Chudakov
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2f39372ad99400481c0c5057acab3f0bd1442ae3
    Gerrit-Change-Number: 8036906
    Gerrit-PatchSet: 1
    Gerrit-Owner: Timofey Chudakov <tchu...@google.com>
    Gerrit-Reviewer: Bruno Braga <bruno...@google.com>
    Gerrit-Reviewer: Lijin Shen <laz...@google.com>
    Gerrit-Reviewer: Michael van Ouwerkerk <mvanou...@chromium.org>
    Gerrit-Reviewer: Norge Vizcay <viz...@google.com>
    Gerrit-Reviewer: Timofey Chudakov <tchu...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Jinsuk Kim <jins...@chromium.org>
    Gerrit-CC: Moe Adel <ad...@google.com>
    Gerrit-Attention: Timofey Chudakov <tchu...@google.com>
    Gerrit-Comment-Date: Wed, 08 Jul 2026 07:07:39 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Norge Vizcay <viz...@google.com>
    Comment-In-Reply-To: Timofey Chudakov <tchu...@google.com>
    satisfied_requirement
    open
    diffy

    Timofey Chudakov (Gerrit)

    unread,
    3:56 AM (6 hours ago) 3:56 AM
    to Lijin Shen, Bruno Braga, Michael van Ouwerkerk, Norge Vizcay, Chromium LUCI CQ, Moe Adel, Chromium Metrics Reviews, chromium...@chromium.org, Jinsuk Kim, armalhotra+a...@google.com, asvitkine...@chromium.org, browser-comp...@chromium.org, osaul+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com

    Timofey Chudakov voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2f39372ad99400481c0c5057acab3f0bd1442ae3
    Gerrit-Change-Number: 8036906
    Gerrit-PatchSet: 1
    Gerrit-Owner: Timofey Chudakov <tchu...@google.com>
    Gerrit-Reviewer: Bruno Braga <bruno...@google.com>
    Gerrit-Reviewer: Lijin Shen <laz...@google.com>
    Gerrit-Reviewer: Michael van Ouwerkerk <mvanou...@chromium.org>
    Gerrit-Reviewer: Norge Vizcay <viz...@google.com>
    Gerrit-Reviewer: Timofey Chudakov <tchu...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Jinsuk Kim <jins...@chromium.org>
    Gerrit-CC: Moe Adel <ad...@google.com>
    Gerrit-Comment-Date: Wed, 08 Jul 2026 07:56:17 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    4:49 AM (5 hours ago) 4:49 AM
    to Timofey Chudakov, Lijin Shen, Bruno Braga, Michael van Ouwerkerk, Norge Vizcay, Moe Adel, Chromium Metrics Reviews, chromium...@chromium.org, Jinsuk Kim, armalhotra+a...@google.com, asvitkine...@chromium.org, browser-comp...@chromium.org, osaul+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [AutofillAi - PI] Implement Android private inference notice.

    Mocks: screen/h5Mjw4JYddnbgKz
    Implementation: screen/3s7iW6meSswsgXd
    Bug: 530174611
    Change-Id: I2f39372ad99400481c0c5057acab3f0bd1442ae3
    Commit-Queue: Timofey Chudakov <tchu...@google.com>
    Reviewed-by: Norge Vizcay <viz...@google.com>
    Reviewed-by: Michael van Ouwerkerk <mvanou...@chromium.org>
    Reviewed-by: Bruno Braga <bruno...@google.com>
    Reviewed-by: Lijin Shen <laz...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1658581}
    Files:
    • M chrome/browser/ui/autofill/autofill_message_model.cc
    • M chrome/browser/ui/autofill/autofill_message_model.h
    • M chrome/browser/ui/autofill/chrome_autofill_client.cc
    • M chrome/browser/ui/autofill/chrome_autofill_client.h
    • M components/autofill/core/browser/foundations/autofill_client.cc
    • M components/autofill/core/browser/foundations/autofill_client.h
    • M components/autofill_strings.grdp
    • A components/autofill_strings_grdp/IDS_AUTOFILL_AI_PRIVATE_INFERENCE_NOTICE_DESCRIPTION.png.sha1
    • A components/autofill_strings_grdp/IDS_AUTOFILL_AI_PRIVATE_INFERENCE_NOTICE_PRIMARY_BUTTON_TEXT.png.sha1
    • A components/autofill_strings_grdp/IDS_AUTOFILL_AI_PRIVATE_INFERENCE_NOTICE_TITLE.png.sha1
    • M components/messages/android/java/src/org/chromium/components/messages/MessagesMetrics.java
    • M components/messages/android/message_enums.h
    • M tools/metrics/histograms/metadata/android/enums.xml
    • M tools/metrics/histograms/metadata/android/histograms.xml
    Change size: M
    Delta: 14 files changed, 64 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Michael van Ouwerkerk, +1 by Bruno Braga, +1 by Lijin Shen, +1 by Norge Vizcay
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2f39372ad99400481c0c5057acab3f0bd1442ae3
    Gerrit-Change-Number: 8036906
    Gerrit-PatchSet: 2
    Gerrit-Owner: Timofey Chudakov <tchu...@google.com>
    Gerrit-Reviewer: Bruno Braga <bruno...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Lijin Shen <laz...@google.com>
    Gerrit-Reviewer: Michael van Ouwerkerk <mvanou...@chromium.org>
    Gerrit-Reviewer: Norge Vizcay <viz...@google.com>
    Gerrit-Reviewer: Timofey Chudakov <tchu...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages