Disallow base::Contains() when contains() or find() methods available [chromium/src : main]

0 views

Skip to first unread message

Victor Vianna (Gerrit)

unread,

Jan 9, 2026, 5:20:44 PM (2 days ago) Jan 9

to Chromium LUCI CQ, chromium...@chromium.org

Victor Vianna added 1 comment

File base/containers/contains.h

Line 42, Patchset 8 (Latest): return std::ranges::find(container, value) != std::ranges::end(container);

Victor Vianna . unresolved

Before this CL we might wanna land the one that allows std::ranges::contains() and uses it here. So that when we migrate the remaining base::Contains() to std::ranges::contains(), we can reference this CL as the one that aliased the former to the latter

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Victor Vianna (Gerrit)

unread,

3:23 AM (14 hours ago) 3:23 AM

to Chromium LUCI CQ, chromium...@chromium.org

Victor Vianna added 1 comment

File base/containers/contains.h

Line 42, Patchset 8: return std::ranges::find(container, value) != std::ranges::end(container);

Victor Vianna . resolved

Before this CL we might wanna land the one that allows std::ranges::contains() and uses it here. So that when we migrate the remaining base::Contains() to std::ranges::contains(), we can reference this CL as the one that aliased the former to the latter

Victor Vianna

Done