Wallet API: Feature guard uploading a session ID [chromium/src : main]
0 views
Skip to first unread message
Florian Leimgruber (Gerrit)
9:28 AM (2 hours ago) 9:28 AM
to Norge Vizcay, chromium...@chromium.org
Attention needed from Norge Vizcay
Florian Leimgruber voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Norge Vizcay
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Norge Vizcay (Gerrit)
9:50 AM (2 hours ago) 9:50 AM
to Florian Leimgruber, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Florian Leimgruber
Norge Vizcay voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Florian Leimgruber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Florian Leimgruber (Gerrit)
9:51 AM (2 hours ago) 9:51 AM
to Norge Vizcay, Chromium LUCI CQ, chromium...@chromium.org
Florian Leimgruber voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
10:12 AM (2 hours ago) 10:12 AM
to Florian Leimgruber, Norge Vizcay, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Wallet API: Feature guard uploading a session ID
crrev.com/c/7680076 modified the Upsert API to require a session ID
for the creation of a new pass. This CL flag guards the new logic,
omitting the session ID from the Upsert request if disabled. This
derisks the launch, should the code to log a consent not make it on
time. In this case, by keeping the new feature flag disabled, no
nonsensical session IDs are uploaded to Wallet.
Note that the components/autofill code that actually logs a consent
will likely be feature guarded as well with an Autofill feature flag.
Having a separate feature flag in components/wallet allows us to keep
the API in its intended long-term state, where a session ID needs to be
provided during saves.
Bug: 489354073
Change-Id: I7b338fddcd74e32ffa39068faa4e756c633d41af
Commit-Queue: Florian Leimgruber <fleim...@google.com>
Reviewed-by: Norge Vizcay <viz...@google.com>
Cr-Commit-Position: refs/heads/main@{#1603447}
Files:
- M components/wallet/core/browser/network/upsert_private_pass_request.cc
- M components/wallet/core/browser/network/upsert_private_pass_request_unittest.cc
- M components/wallet/core/common/wallet_features.cc
- M components/wallet/core/common/wallet_features.h
Change size: S
Delta: 4 files changed, 14 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Norge Vizcay
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages