Remove UNSAFE_BUFFERS use from string_view_util.h [chromium/src : main]

0 views
Skip to first unread message

Daniel Cheng (Gerrit)

unread,
4:18 PM (4 hours ago) 4:18 PM
to Daniel Cheng, Tom Sepez, Chromium LUCI CQ, chromium...@chromium.org, Hongchan Choi, Luna Lu, blink-rev...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, dmurph+watch...@chromium.org, dtapuska+ch...@chromium.org, feature-me...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, max+watc...@igalia.com, net-r...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org, spang...@chromium.org, tracing...@chromium.org, webap...@microsoft.com, wfh+...@chromium.org
Attention needed from Tom Sepez

Daniel Cheng added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Daniel Cheng . resolved

Random cleanup

Open in Gerrit

Related details

Attention is currently required from:
  • Tom Sepez
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iebc4f1b677bbfacdc04b9a25f3c4259629d1fb32
Gerrit-Change-Number: 7487235
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Luna Lu <loon...@chromium.org>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-Attention: Tom Sepez <tse...@chromium.org>
Gerrit-Comment-Date: Thu, 15 Jan 2026 21:18:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Tom Sepez (Gerrit)

unread,
4:20 PM (4 hours ago) 4:20 PM
to Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, Hongchan Choi, Luna Lu, blink-rev...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, dmurph+watch...@chromium.org, dtapuska+ch...@chromium.org, feature-me...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, max+watc...@igalia.com, net-r...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org, spang...@chromium.org, tracing...@chromium.org, webap...@microsoft.com, wfh+...@chromium.org
Attention needed from Daniel Cheng

Tom Sepez voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iebc4f1b677bbfacdc04b9a25f3c4259629d1fb32
    Gerrit-Change-Number: 7487235
    Gerrit-PatchSet: 1
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-CC: Hongchan Choi <hong...@chromium.org>
    Gerrit-CC: Luna Lu <loon...@chromium.org>
    Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 21:20:24 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    6:21 PM (2 hours ago) 6:21 PM
    to Daniel Cheng, Tom Sepez, Chromium LUCI CQ, chromium...@chromium.org, Hongchan Choi, Luna Lu, blink-rev...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, dmurph+watch...@chromium.org, dtapuska+ch...@chromium.org, feature-me...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, max+watc...@igalia.com, net-r...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org, spang...@chromium.org, tracing...@chromium.org, webap...@microsoft.com, wfh+...@chromium.org

    Daniel Cheng voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iebc4f1b677bbfacdc04b9a25f3c4259629d1fb32
    Gerrit-Change-Number: 7487235
    Gerrit-PatchSet: 2
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-CC: Hongchan Choi <hong...@chromium.org>
    Gerrit-CC: Luna Lu <loon...@chromium.org>
    Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 23:21:06 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    6:24 PM (2 hours ago) 6:24 PM
    to Daniel Cheng, Tom Sepez, chromium...@chromium.org, Hongchan Choi, Luna Lu, blink-rev...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, dmurph+watch...@chromium.org, dtapuska+ch...@chromium.org, feature-me...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, max+watc...@igalia.com, net-r...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org, spang...@chromium.org, tracing...@chromium.org, webap...@microsoft.com, wfh+...@chromium.org

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    1 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    Remove UNSAFE_BUFFERS use from string_view_util.h

    With C++23, this can use std::string_view's range constructor.
    Change-Id: Iebc4f1b677bbfacdc04b9a25f3c4259629d1fb32
    Commit-Queue: Daniel Cheng <dch...@chromium.org>
    Reviewed-by: Tom Sepez <tse...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1570054}
    Files:
    • M base/strings/string_view_util.h
    Change size: S
    Delta: 1 file changed, 3 insertions(+), 9 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Tom Sepez
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iebc4f1b677bbfacdc04b9a25f3c4259629d1fb32
    Gerrit-Change-Number: 7487235
    Gerrit-PatchSet: 3
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages