[Masonry] Update remaining comments referring to masonry [chromium/src : main]

0 views
Skip to first unread message

Alison Maher (Gerrit)

unread,
Dec 15, 2025, 1:39:00 PM (20 hours ago) Dec 15
to Kurt Catti-Schmidt, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Kurt Catti-Schmidt

Alison Maher voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kurt Catti-Schmidt
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie36f868235389d82d477adad8bf86b51e7a41ef2
Gerrit-Change-Number: 7262405
Gerrit-PatchSet: 1
Gerrit-Owner: Alison Maher <alm...@microsoft.com>
Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
Gerrit-Attention: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-Comment-Date: Mon, 15 Dec 2025 18:38:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Celeste Pan (Gerrit)

unread,
Dec 15, 2025, 1:59:06 PM (20 hours ago) Dec 15
to Alison Maher, Chromium LUCI CQ, Kurt Catti-Schmidt, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Alison Maher and Kurt Catti-Schmidt

Celeste Pan voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alison Maher
  • Kurt Catti-Schmidt
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie36f868235389d82d477adad8bf86b51e7a41ef2
    Gerrit-Change-Number: 7262405
    Gerrit-PatchSet: 1
    Gerrit-Owner: Alison Maher <alm...@microsoft.com>
    Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
    Gerrit-Reviewer: Celeste Pan <celes...@microsoft.com>
    Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
    Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
    Gerrit-Attention: Alison Maher <alm...@microsoft.com>
    Gerrit-Attention: Kurt Catti-Schmidt <ksc...@microsoft.com>
    Gerrit-Comment-Date: Mon, 15 Dec 2025 18:58:57 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Kurt Catti-Schmidt (Gerrit)

    unread,
    Dec 15, 2025, 2:34:35 PM (19 hours ago) Dec 15
    to Alison Maher, Celeste Pan, Chromium LUCI CQ, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
    Attention needed from Alison Maher

    Kurt Catti-Schmidt voted

    Code-Review+1
    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alison Maher
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie36f868235389d82d477adad8bf86b51e7a41ef2
    Gerrit-Change-Number: 7262405
    Gerrit-PatchSet: 1
    Gerrit-Owner: Alison Maher <alm...@microsoft.com>
    Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
    Gerrit-Reviewer: Celeste Pan <celes...@microsoft.com>
    Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
    Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
    Gerrit-Attention: Alison Maher <alm...@microsoft.com>
    Gerrit-Comment-Date: Mon, 15 Dec 2025 19:34:24 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Dec 15, 2025, 2:55:19 PM (19 hours ago) Dec 15
    to Alison Maher, Kurt Catti-Schmidt, Celeste Pan, chromium...@chromium.org, Javier Fernandez, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [Masonry] Update remaining comments referring to masonry

    I noticed there were a hanful of comments that still reference
    "masonry" that I missed. Update to use the grid-lanes naming.

    This change should have no functional effect.
    Bug: 343257585
    Change-Id: Ie36f868235389d82d477adad8bf86b51e7a41ef2
    Commit-Queue: Kurt Catti-Schmidt <ksc...@microsoft.com>
    Reviewed-by: Kurt Catti-Schmidt <ksc...@microsoft.com>
    Auto-Submit: Alison Maher <alm...@microsoft.com>
    Reviewed-by: Celeste Pan <celes...@microsoft.com>
    Cr-Commit-Position: refs/heads/main@{#1558903}
    Files:
    • M third_party/blink/renderer/core/layout/flex/flex_gap_accumulator.h
    • M third_party/blink/renderer/core/layout/gap/README.md
    • M third_party/blink/renderer/core/layout/grid/grid_baseline_accumulator.h
    • M third_party/blink/renderer/core/layout/grid/grid_item.h
    • M third_party/blink/renderer/core/layout/grid/grid_track_collection_test.cc
    • M third_party/blink/renderer/core/layout/grid/layout_grid.h
    Change size: S
    Delta: 6 files changed, 16 insertions(+), 15 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Kurt Catti-Schmidt, +1 by Celeste Pan
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie36f868235389d82d477adad8bf86b51e7a41ef2
    Gerrit-Change-Number: 7262405
    Gerrit-PatchSet: 2
    Gerrit-Owner: Alison Maher <alm...@microsoft.com>
    Gerrit-Reviewer: Alison Maher <alm...@microsoft.com>
    Gerrit-Reviewer: Celeste Pan <celes...@microsoft.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages