WebMCP: Rename some user counters [chromium/src : main]

0 views

Skip to first unread message

Dominic Farolino (Gerrit)

unread,

Jul 7, 2026, 11:34:56 PM (10 hours ago) Jul 7

to Chris Harrelson, Fr, Chromium Metrics Reviews, chromium...@chromium.org, Khushal Sagar, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Chris Harrelson and Fr

Dominic Farolino voted and added 1 comment

Votes added by Dominic Farolino

Commit-Queue

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Dominic Farolino . resolved

+chrishtr@ for webdx_feature_maps.cc again

Open in Gerrit

Related details

Attention is currently required from:

Chris Harrelson
Fr

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Fr (Gerrit)

unread,

3:07 AM (7 hours ago) 3:07 AM

to Dominic Farolino, Chromium LUCI CQ, Chris Harrelson, Chromium Metrics Reviews, chromium...@chromium.org, Khushal Sagar, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Chris Harrelson and Dominic Farolino

Fr added 1 comment

File third_party/blink/web_tests/fast/webmcp/usecounter.https.html

Line 15, Patchset 1 (Latest):const kModelContextRegisterToolIDL = 5791;

Fr . unresolved

I'd argue that the `IDL` part doesn't seem necessary anymore:

IDL match method names and map to `WebDXFeature::kNavigatorModelcontext`:

`kModelContextRegisterTool` => `document.modelContext.registerTool()`
`kModelContextGetTools` => `document.modelContext.getTools()`
`kModelContextExecuteTool` => `document.modelContext.executeTool()`

while internals have specific names:

`kModelContextRegisterDeclarativeTool` maps to `WebDXFeature::kDeclarativeWebmcp`
`kModelContextExecuteV8Tool` (or `kModelContextExecuteImperativeTool` FWIW)
`kModelContextExecuteDeclarativeTool`
`kModelContextExecuteDeclarativeAutosubmit`