crowbar: pass metadata as commit message footer to Copybara [infra/infra : main]
Jiewei Qian (Gerrit)
New activity on the change![]( "Open in Gerrit")
Related details
- Chenlin Fan
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chenlin Fan (Gerrit)
Chenlin Fan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Chenlin Fan
| Code-Review | +1 |
1 comment
Chenlin Fanfancl: want opinion :)
i'm contemplating if this is better or worse than implement a README.chromium parse + update in CLI.
^ if we need to cater for dependencies where the metadata files are derived based on requirements.txt / package.json / package-lock.json.
If i guess correctly, the multi-dependency README.chromium needs to be derived per package ecosystem. Not sure if we want to do this in go, or give owners an option to DIY.
if they have a standard lock file we can implement the generator for them since it could be shared. I'm fine with starting with this and decide later when we actually need to handle multi-dependency README.chromium.
Just add a comment that if we have multi-dependency README.chromium then consider remove this implementation.
Related details
- Jiewei Qian
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jiewei Qian (Gerrit)
Jiewei Qian added 1 comment![]( "Open in Gerrit")
Chenlin Fanfancl: want opinion :)
i'm contemplating if this is better or worse than implement a README.chromium parse + update in CLI.
^ if we need to cater for dependencies where the metadata files are derived based on requirements.txt / package.json / package-lock.json.
If i guess correctly, the multi-dependency README.chromium needs to be derived per package ecosystem. Not sure if we want to do this in go, or give owners an option to DIY.
if they have a standard lock file we can implement the generator for them since it could be shared. I'm fine with starting with this and decide later when we actually need to handle multi-dependency README.chromium.
Just add a comment that if we have multi-dependency README.chromium then consider remove this implementation.
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jiewei Qian (Gerrit)
Jiewei Qian voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
LUCI CQ (Gerrit)
LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: go/src/infra/tools/crowbar/pkg/spec/metadata.go
Insertions: 5, Deletions: 1.
@@ -10,7 +10,11 @@
"strings"
)
-// Metadata Git footer names. They're passed to Copybara as the origin's message.
+// Metadata Git footer names. They're passed to Copybara as the origin's message
+// and allows generating or updating README.chromium files in `copy.bara.sky`.
+//
+// TODO(b/524446296): Remove this if we decide to let Crowbar CLI to handle
+// README.chromium file updates.
const (
MetadataGitRepo = "Crowbar-Git-Repo"
MetadataGitCommit = "Crowbar-Git-Commit"
```
Change information
crowbar: pass metadata as commit message footer to Copybara
This CL adds logic to generate a "stub" origin message and pass it to
Copybara to serve as the missing message that describes a git commit or
gerrit change.
This would allow us to use them in Copybara workflow, for tasks like
generating or updating readme files.
The alternative approach is to implement a README.chromium parser /
replacement logic and handle funny multi-dependencies cases.
- M go/src/infra/tools/crowbar/internal/utilities/assets/copybara.java
- A go/src/infra/tools/crowbar/pkg/spec/metadata.go
- A go/src/infra/tools/crowbar/pkg/spec/metadata_test.go
- M go/src/infra/tools/crowbar/pkg/spec/package.go
- M go/src/infra/tools/crowbar/pkg/spec/stages.go
- M go/src/infra/tools/crowbar/pkg/spec/stages_test.go
Code-Review: +1 by Chenlin Fan
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |