Roll cxx: 1.0.184 => 1.0.185 in //third_party/rust. [chromium/src : main]
0 views
Skip to first unread message
Daniel Rubery (Gerrit)
Sep 23, 2025, 8:35:04 PM (2 days ago) Sep 23
to chrome-third-pa...@google.com, Chromium LUCI CQ, chromium...@chromium.org, chrome-rust-exper...@google.com
Attention needed from Daniel Rubery and chrome-third-pa...@google.com
Daniel Rubery voted and added 1 comment![]( "Open in Gerrit")
Votes added by Daniel Rubery
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Daniel Rubery . resolved
After I get a +1 I'll set `No-Presubmit: true` since this roll also falls afoul of https://crbug.com/443275577
Related details
Attention is currently required from:
- Daniel Rubery
- chrome-third-pa...@google.com
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Sep 23, 2025, 8:38:41 PM (2 days ago) Sep 23
to Daniel Rubery, chrome-third-pa...@google.com, Łukasz Anforowicz, Chromium LUCI CQ, chromium...@chromium.org, chrome-rust-exper...@google.com
Attention needed from Daniel Rubery and Łukasz Anforowicz
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/third_party/rust/config.gwsq:
third-party-rust: luk...@chromium.org
It looks like you’re modifying `//third_party/rust`. An appropriate reviewer has been automatically added to this CL.
`//third_party/rust` reviewer(s): luk...@chromium.org
Reviewer source(s):
luk...@chromium.org is from context(googleclient/chrome/chromium_gwsq/third_party/rust/config.gwsq)
Related details
Attention is currently required from:
- Daniel Rubery
- Łukasz Anforowicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Rubery (Gerrit)
Sep 25, 2025, 12:29:35 PM (15 hours ago) Sep 25
to chrome-third-pa...@google.com, Łukasz Anforowicz, Chromium LUCI CQ, chromium...@chromium.org, chrome-rust-exper...@google.com
Attention needed from Łukasz Anforowicz
Daniel Rubery added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Daniel Rubery . resolved
Okay I've done enough manual testing that I think we can land this with No-Presubmit and see what happens with https://crrev.com/c/6980526. lukasza@ - can you give another +1?
Related details
Attention is currently required from:
- Łukasz Anforowicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Łukasz Anforowicz (Gerrit)
Sep 25, 2025, 12:41:25 PM (15 hours ago) Sep 25
to Daniel Rubery, chrome-third-pa...@google.com, Chromium LUCI CQ, chromium...@chromium.org, chrome-rust-exper...@google.com
Attention needed from Daniel Rubery
Łukasz Anforowicz voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Daniel Rubery
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Rubery (Gerrit)
Sep 25, 2025, 1:00:01 PM (14 hours ago) Sep 25
to Łukasz Anforowicz, chrome-third-pa...@google.com, Chromium LUCI CQ, chromium...@chromium.org, chrome-rust-exper...@google.com
Attention needed from Łukasz Anforowicz
Daniel Rubery voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Łukasz Anforowicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 25, 2025, 2:11:48 PM (13 hours ago) Sep 25
to Daniel Rubery, Łukasz Anforowicz, chrome-third-pa...@google.com, chromium...@chromium.org, chrome-rust-exper...@google.com
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Roll cxx: 1.0.184 => 1.0.185 in //third_party/rust.
This CL has been created semi-automatically. The expected review
process and other details can be found at
//tools/crates/create_update_cl.md
Updated crates:
* cxx-build: 1.0.184 => 1.0.185; https://docs.rs/crate/cxx-build/1.0.185
* cxx: 1.0.184 => 1.0.185; https://docs.rs/crate/cxx/1.0.185
* cxxbridge-cmd: 1.0.184 => 1.0.185;
https://docs.rs/crate/cxxbridge-cmd/1.0.185
* cxxbridge-flags: 1.0.184 => 1.0.185;
https://docs.rs/crate/cxxbridge-flags/1.0.185
* cxxbridge-macro: 1.0.184 => 1.0.185;
https://docs.rs/crate/cxxbridge-macro/1.0.185
Bypassing the presubmit because the crate has includes that
make checkdeps unhappy. This is tracked in
https://crbug.com/443275577.
Bug: None
Cq-Include-Trybots: chromium/try:android-rust-arm32-rel
Cq-Include-Trybots: chromium/try:android-rust-arm64-dbg
Cq-Include-Trybots: chromium/try:android-rust-arm64-rel
Cq-Include-Trybots: chromium/try:linux-rust-x64-dbg
Cq-Include-Trybots: chromium/try:linux-rust-x64-rel
Cq-Include-Trybots: chromium/try:win-rust-x64-dbg
Cq-Include-Trybots: chromium/try:win-rust-x64-rel
No-Presubmit: true
Disable-Rts: True
Change-Id: I61ee028b8973238d434787755ff8147c73195917
Reviewed-by: Łukasz Anforowicz <luk...@chromium.org>
Commit-Queue: Daniel Rubery <dru...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1520756}
Files:
- M third_party/rust/chromium_crates_io/Cargo.lock
- M third_party/rust/chromium_crates_io/supply-chain/config.toml
- M third_party/rust/chromium_crates_io/vendor/cxx-build-v1/Cargo.toml
- M third_party/rust/chromium_crates_io/vendor/cxx-build-v1/src/lib.rs
- M third_party/rust/chromium_crates_io/vendor/cxx-v1/.cargo_vcs_info.json
- M third_party/rust/chromium_crates_io/vendor/cxx-v1/Cargo.lock
- M third_party/rust/chromium_crates_io/vendor/cxx-v1/Cargo.toml
- M third_party/rust/chromium_crates_io/vendor/cxx-v1/Cargo.toml.orig
- M third_party/rust/chromium_crates_io/vendor/cxx-v1/MODULE.bazel
- M third_party/rust/chromium_crates_io/vendor/cxx-v1/MODULE.bazel.lock
- M third_party/rust/chromium_crates_io/vendor/cxx-v1/src/cxx_vector.rs
- M third_party/rust/chromium_crates_io/vendor/cxx-v1/src/lib.rs
- M third_party/rust/chromium_crates_io/vendor/cxx-v1/tests/test.rs
- M third_party/rust/chromium_crates_io/vendor/cxxbridge-cmd-v1/.cargo_vcs_info.json
- M third_party/rust/chromium_crates_io/vendor/cxxbridge-cmd-v1/Cargo.lock
- M third_party/rust/chromium_crates_io/vendor/cxxbridge-cmd-v1/Cargo.toml
- M third_party/rust/chromium_crates_io/vendor/cxxbridge-cmd-v1/Cargo.toml.orig
- M third_party/rust/chromium_crates_io/vendor/cxxbridge-cmd-v1/src/gen/builtin.rs
- A third_party/rust/chromium_crates_io/vendor/cxxbridge-cmd-v1/src/gen/builtin/vector.h
- M third_party/rust/chromium_crates_io/vendor/cxxbridge-cmd-v1/src/gen/write.rs
- M third_party/rust/chromium_crates_io/vendor/cxxbridge-flags-v1/.cargo_vcs_info.json
- M third_party/rust/chromium_crates_io/vendor/cxxbridge-flags-v1/Cargo.lock
- M third_party/rust/chromium_crates_io/vendor/cxxbridge-flags-v1/Cargo.toml
- M third_party/rust/chromium_crates_io/vendor/cxxbridge-flags-v1/Cargo.toml.orig
- M third_party/rust/chromium_crates_io/vendor/cxxbridge-macro-v1/.cargo_vcs_info.json
- M third_party/rust/chromium_crates_io/vendor/cxxbridge-macro-v1/Cargo.lock
- M third_party/rust/chromium_crates_io/vendor/cxxbridge-macro-v1/Cargo.toml
- M third_party/rust/chromium_crates_io/vendor/cxxbridge-macro-v1/Cargo.toml.orig
- M third_party/rust/chromium_crates_io/vendor/cxxbridge-macro-v1/src/expand.rs
- M third_party/rust/cxx/v1/BUILD.gn
- M third_party/rust/cxx/v1/README.chromium
- M third_party/rust/cxxbridge_cmd/v1/BUILD.gn
- M third_party/rust/cxxbridge_cmd/v1/README.chromium
- M third_party/rust/cxxbridge_flags/v1/BUILD.gn
- M third_party/rust/cxxbridge_flags/v1/README.chromium
- M third_party/rust/cxxbridge_macro/v1/BUILD.gn
- M third_party/rust/cxxbridge_macro/v1/README.chromium
Change size: L
Delta: 37 files changed, 253 insertions(+), 195 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Łukasz Anforowicz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages