[lensoverlay] Make more options menu keyboard navigable. [chromium/src : main]

1 view
Skip to first unread message

Bryan Nguyen (Gerrit)

unread,
Jul 26, 2024, 7:07:27 PM (13 hours ago) Jul 26
to Jason Hu, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Jason Hu

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Jason Hu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9e2ff88fc72406f30ca718e94382b63e6b10f76a
Gerrit-Change-Number: 5742626
Gerrit-PatchSet: 1
Gerrit-Owner: Bryan Nguyen <nguye...@google.com>
Gerrit-Reviewer: Bryan Nguyen <nguye...@google.com>
Gerrit-Reviewer: Jason Hu <huja...@google.com>
Gerrit-Attention: Jason Hu <huja...@google.com>
Gerrit-Comment-Date: Fri, 26 Jul 2024 23:07:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Bryan Nguyen (Gerrit)

unread,
Jul 26, 2024, 7:51:01 PM (12 hours ago) Jul 26
to Jason Hu, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Jason Hu

Bryan Nguyen voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jason Hu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9e2ff88fc72406f30ca718e94382b63e6b10f76a
Gerrit-Change-Number: 5742626
Gerrit-PatchSet: 2
Gerrit-Owner: Bryan Nguyen <nguye...@google.com>
Gerrit-Reviewer: Bryan Nguyen <nguye...@google.com>
Gerrit-Reviewer: Jason Hu <huja...@google.com>
Gerrit-Attention: Jason Hu <huja...@google.com>
Gerrit-Comment-Date: Fri, 26 Jul 2024 23:50:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jason Hu (Gerrit)

unread,
Jul 26, 2024, 8:02:14 PM (12 hours ago) Jul 26
to Bryan Nguyen, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Bryan Nguyen

Jason Hu voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Bryan Nguyen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9e2ff88fc72406f30ca718e94382b63e6b10f76a
Gerrit-Change-Number: 5742626
Gerrit-PatchSet: 2
Gerrit-Owner: Bryan Nguyen <nguye...@google.com>
Gerrit-Reviewer: Bryan Nguyen <nguye...@google.com>
Gerrit-Reviewer: Jason Hu <huja...@google.com>
Gerrit-Attention: Bryan Nguyen <nguye...@google.com>
Gerrit-Comment-Date: Sat, 27 Jul 2024 00:02:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Bryan Nguyen (Gerrit)

unread,
Jul 26, 2024, 8:10:48 PM (12 hours ago) Jul 26
to Jason Hu, Chromium LUCI CQ, chromium...@chromium.org

Bryan Nguyen voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9e2ff88fc72406f30ca718e94382b63e6b10f76a
Gerrit-Change-Number: 5742626
Gerrit-PatchSet: 2
Gerrit-Owner: Bryan Nguyen <nguye...@google.com>
Gerrit-Reviewer: Bryan Nguyen <nguye...@google.com>
Gerrit-Reviewer: Jason Hu <huja...@google.com>
Gerrit-Comment-Date: Sat, 27 Jul 2024 00:10:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jul 26, 2024, 10:08:28 PM (10 hours ago) Jul 26
to Bryan Nguyen, Jason Hu, chromium...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[lensoverlay] Make more options menu keyboard navigable.
Bug: b:342212505
Change-Id: I9e2ff88fc72406f30ca718e94382b63e6b10f76a
Reviewed-by: Jason Hu <huja...@google.com>
Commit-Queue: Bryan Nguyen <nguye...@google.com>
Cr-Commit-Position: refs/heads/main@{#1333861}
Files:
  • M chrome/browser/resources/lens/overlay/lens_overlay_app.html
  • M chrome/browser/resources/lens/overlay/lens_overlay_app.ts
  • M chrome/test/data/webui/lens/overlay/overlay_more_options_button_test.ts
Change size: M
Delta: 3 files changed, 35 insertions(+), 18 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Jason Hu
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9e2ff88fc72406f30ca718e94382b63e6b10f76a
Gerrit-Change-Number: 5742626
Gerrit-PatchSet: 3
Gerrit-Owner: Bryan Nguyen <nguye...@google.com>
Gerrit-Reviewer: Bryan Nguyen <nguye...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Jason Hu <huja...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages