feedback: hide preview image file container for non-image file [chromium/src : main]

Xiangdong Kong (Gerrit)

unread,

Aug 5, 2022, 6:54:19 PM8/5/22

to oshima...@chromium.org, Gavin Williams, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Gavin Williams.

Patch set 2:Commit-Queue +1

View Change

To view, visit change 3812188. To unsubscribe, or for help writing mail filters, visit settings.

Gavin Williams (Gerrit)

unread,

Aug 8, 2022, 6:07:08 PM8/8/22

to Xiangdong Kong, oshima...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Xiangdong Kong.

Patch set 2:Code-Review +1

View Change

To view, visit change 3812188. To unsubscribe, or for help writing mail filters, visit settings.

Xiangdong Kong (Gerrit)

unread,

Aug 8, 2022, 6:21:33 PM8/8/22

to oshima...@chromium.org, Gavin Williams, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Xiangdong Kong.

Patch set 2:Commit-Queue +2

View Change

To view, visit change 3812188. To unsubscribe, or for help writing mail filters, visit settings.

Xiangdong Kong (Gerrit)

unread,

Aug 9, 2022, 12:29:25 AM8/9/22

to oshima...@chromium.org, Gavin Williams, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Xiangdong Kong.

Patch set 2:Commit-Queue +2

View Change

To view, visit change 3812188. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Aug 9, 2022, 2:08:15 AM8/9/22

to Xiangdong Kong, oshima...@chromium.org, Gavin Williams, chromium...@chromium.org

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Gavin Williams: Looks good to me
  Xiangdong Kong: Commit

feedback: hide preview image file container for non-image file

Before the change, only the img element inside the container is hidden
for non image files. The container still take up space.

Screenshots:

- Before: http://screen/8n5qwxbZWa4aJge.
- After: http://screen/4S7C9buGRgeYT3G.

Bug: b:185624798
Test: --gtest_filter=ChromeOsFeedbackDelegateTest.*;
Change-Id: I48d2332522caf693296d36ab9bba768c69f45518
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3812188
Reviewed-by: Gavin Williams <gavi...@chromium.org>
Commit-Queue: Xiangdong Kong <xiangd...@google.com>
Cr-Commit-Position: refs/heads/main@{#1032883}
---
M ash/webui/os_feedback_ui/resources/file_attachment.html
M chrome/test/data/webui/chromeos/os_feedback_ui/file_attachment_test.js
2 files changed, 33 insertions(+), 4 deletions(-)

To view, visit change 3812188. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward