[SxS] Show view source domain label [chromium/src : main]
0 views
Skip to first unread message
Alison Gale (Gerrit)
Jan 7, 2026, 11:32:13 AMJan 7
to Chris Thompson, Chromium LUCI CQ, chromium...@chromium.org, srahim...@chromium.org
Attention needed from Chris Thompson
Alison Gale added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Alison Gale . resolved
Does this approach seem like a reasonable solution?
Related details
Attention is currently required from:
- Chris Thompson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chris Thompson (Gerrit)
Jan 9, 2026, 12:21:16 PMJan 9
to Alison Gale, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, srahim...@chromium.org
Attention needed from Alison Gale
Chris Thompson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Chris Thompson
| Code-Review | +1 |
1 comment
Patchset-level comments
Alison Gale . resolved
Does this approach seem like a reasonable solution?
Chris Thompson
Sorry for missing this earlier. The approach here of making sure that we show _some_ Chrome-controlled string in the domain label for view-source URLs LGTM.
Related details
Attention is currently required from:
- Alison Gale
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alison Gale (Gerrit)
Jan 12, 2026, 11:31:08 AMJan 12
to Daniel Cheng, David Pennington, Chris Thompson, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, srahim...@chromium.org
Attention needed from Daniel Cheng and David Pennington
Alison Gale added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Daniel Cheng
- David Pennington
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Pennington (Gerrit)
Jan 12, 2026, 12:16:12 PMJan 12
to Alison Gale, Daniel Cheng, Chris Thompson, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, srahim...@chromium.org
Attention needed from Alison Gale and Daniel Cheng
David Pennington voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alison Gale
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Jan 12, 2026, 3:29:29 PMJan 12
to Alison Gale, David Pennington, Daniel Cheng, Chris Thompson, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, srahim...@chromium.org
Attention needed from Alison Gale
Daniel Cheng added 1 comment![]( "Open in Gerrit")
File url/gurl.h
Line 284, Patchset 2 (Latest):
bool SchemeIsViewSource() const { return SchemeIs(url::kViewSourceScheme); }Daniel Cheng . unresolved
I'd rather not add this and just use `SchemeIs(url::kViewSourceSceheme)`
It's a bit arbitrary but this doesn't feel "webby" to me (e.g. we don't have a SchemeIsSteam() for example)
Related details
Attention is currently required from:
- Alison Gale
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alison Gale (Gerrit)
Jan 12, 2026, 3:55:06 PMJan 12
to David Pennington, Daniel Cheng, Chris Thompson, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, srahim...@chromium.org
Attention needed from Chris Thompson, Daniel Cheng and David Pennington
Alison Gale added 1 comment![]( "Open in Gerrit")
File url/gurl.h
Line 284, Patchset 2:
bool SchemeIsViewSource() const { return SchemeIs(url::kViewSourceScheme); }Daniel Cheng . resolved
I'd rather not add this and just use `SchemeIs(url::kViewSourceSceheme)`
It's a bit arbitrary but this doesn't feel "webby" to me (e.g. we don't have a SchemeIsSteam() for example)
Attention is currently required from:
- Chris Thompson
- Daniel Cheng
- David Pennington
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Pennington (Gerrit)
Jan 12, 2026, 4:05:13 PMJan 12
to Alison Gale, Daniel Cheng, Chris Thompson, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, srahim...@chromium.org
Attention needed from Alison Gale, Chris Thompson and Daniel Cheng
David Pennington voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alison Gale
- Chris Thompson
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chris Thompson (Gerrit)
Jan 13, 2026, 12:17:42 PMJan 13
to Alison Gale, David Pennington, Daniel Cheng, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, srahim...@chromium.org
Attention needed from Alison Gale and Daniel Cheng
Chris Thompson added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File chrome/browser/ui/views/frame/multi_contents_view_drop_target_controller.cc
Line 92, Patchset 3 (Latest):
LOG(WARNING) << "**** OnTabDragUpdated";Chris Thompson . unresolved
Remove before submitting
Related details
Attention is currently required from:
- Alison Gale
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chris Thompson (Gerrit)
Jan 13, 2026, 12:17:50 PMJan 13
to Alison Gale, David Pennington, Daniel Cheng, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, srahim...@chromium.org
Attention needed from Alison Gale and Daniel Cheng
Chris Thompson voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Alison Gale (Gerrit)
Jan 13, 2026, 12:21:53 PMJan 13
to Chris Thompson, David Pennington, Daniel Cheng, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, srahim...@chromium.org
Attention needed from Chris Thompson, Daniel Cheng and David Pennington
Alison Gale added 1 comment![]( "Open in Gerrit")
File chrome/browser/ui/views/frame/multi_contents_view_drop_target_controller.cc
Line 92, Patchset 3:
LOG(WARNING) << "**** OnTabDragUpdated";Chris Thompson . resolved
Alison GaleRemove before submitting
Whoops, slipped in from another debug client
Related details
Attention is currently required from:
- Chris Thompson
- Daniel Cheng
- David Pennington
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Pennington (Gerrit)
Jan 13, 2026, 1:29:43 PMJan 13
to Alison Gale, Chris Thompson, Daniel Cheng, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, srahim...@chromium.org
Attention needed from Alison Gale, Chris Thompson and Daniel Cheng
David Pennington voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alison Gale
- Chris Thompson
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Jan 13, 2026, 2:47:05 PMJan 13
to Alison Gale, Daniel Cheng, David Pennington, Chris Thompson, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, srahim...@chromium.org
Attention needed from Alison Gale and Chris Thompson
Daniel Cheng voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Alison Gale
- Chris Thompson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alison Gale (Gerrit)
Jan 13, 2026, 2:50:44 PMJan 13
to Daniel Cheng, David Pennington, Chris Thompson, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, srahim...@chromium.org
Attention needed from Chris Thompson
Alison Gale voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Chris Thompson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 13, 2026, 2:54:14 PMJan 13
to Alison Gale, Daniel Cheng, David Pennington, Chris Thompson, Code Review Nudger, chromium...@chromium.org, srahim...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[SxS] Show view source domain label
This impacts hovercards, the mini toolbar, tab search, and the split new
tab page. Currently we just show the page title and no domain for
view-source pages. For view-source pages on a domain that doesn't
resolve, the title is just the domain. For ones where the page can be
loaded, it has a title of "view-source: page.com". This follows a
similar pattern as used in the blob and local file to make clear that it
is a view source. Another way of solving it would be to update the title
to have view-source but that would be off when the source can't be
viewed.
https://screenshot.googleplex.com/T3Ei2UcqLnDBFkh
Bug: 472376567
Change-Id: I4c87cf9a3e25a807a8556f8d9fb30675d31aa884
Reviewed-by: David Pennington <dpen...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Commit-Queue: Alison Gale <ag...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1568605}
Files:
- M chrome/app/generated_resources.grd
- A chrome/app/generated_resources_grd/IDS_HOVER_CARD_VIEW_SOURCE_URL_SOURCE.png.sha1
- M chrome/browser/resources/tab_search/tab_data.ts
- M chrome/browser/ui/views/frame/multi_contents_view_mini_toolbar.cc
- M chrome/browser/ui/views/tabs/tab_hover_card_bubble_view.cc
- M chrome/browser/ui/webui/tab_search/tab_search_ui.cc
- M url/url_constants.h
Change size: M
Delta: 7 files changed, 33 insertions(+), 23 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Daniel Cheng, +1 by David Pennington
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages