[WebUI] Register ThemeSource explicitly, part 7. [chromium/src : main]

0 views
Skip to first unread message

Mickey Burks (Gerrit)

unread,
Jul 16, 2026, 2:26:43 PM (3 days ago) Jul 16
to Justin DeWitt, David Pennington, chromium...@chromium.org, dewitt...@chromium.org
Attention needed from David Pennington and Justin DeWitt

Mickey Burks added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Mickey Burks . resolved

@dpen...@chromium.org just for c/b/u/w/BUILD.gn

Open in Gerrit

Related details

Attention is currently required from:
  • David Pennington
  • Justin DeWitt
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4f489ac8c0ccf7e660b3a1608fd921fb7ca7368a
Gerrit-Change-Number: 8104771
Gerrit-PatchSet: 1
Gerrit-Owner: Mickey Burks <micke...@chromium.org>
Gerrit-Reviewer: David Pennington <dpen...@chromium.org>
Gerrit-Reviewer: Justin DeWitt <dew...@chromium.org>
Gerrit-Attention: Justin DeWitt <dew...@chromium.org>
Gerrit-Attention: David Pennington <dpen...@chromium.org>
Gerrit-Comment-Date: Thu, 16 Jul 2026 18:26:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

David Pennington (Gerrit)

unread,
Jul 17, 2026, 1:06:46 PM (2 days ago) Jul 17
to Mickey Burks, Justin DeWitt, chromium...@chromium.org, dewitt...@chromium.org
Attention needed from Justin DeWitt and Mickey Burks

David Pennington voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Justin DeWitt
  • Mickey Burks
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4f489ac8c0ccf7e660b3a1608fd921fb7ca7368a
Gerrit-Change-Number: 8104771
Gerrit-PatchSet: 1
Gerrit-Owner: Mickey Burks <micke...@chromium.org>
Gerrit-Reviewer: David Pennington <dpen...@chromium.org>
Gerrit-Reviewer: Justin DeWitt <dew...@chromium.org>
Gerrit-Attention: Justin DeWitt <dew...@chromium.org>
Gerrit-Attention: Mickey Burks <micke...@chromium.org>
Gerrit-Comment-Date: Fri, 17 Jul 2026 17:06:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Justin DeWitt (Gerrit)

unread,
Jul 17, 2026, 7:54:22 PM (2 days ago) Jul 17
to Mickey Burks, David Pennington, chromium...@chromium.org, dewitt...@chromium.org
Attention needed from Mickey Burks

Justin DeWitt voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Mickey Burks
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4f489ac8c0ccf7e660b3a1608fd921fb7ca7368a
Gerrit-Change-Number: 8104771
Gerrit-PatchSet: 1
Gerrit-Owner: Mickey Burks <micke...@chromium.org>
Gerrit-Reviewer: David Pennington <dpen...@chromium.org>
Gerrit-Reviewer: Justin DeWitt <dew...@chromium.org>
Gerrit-Attention: Mickey Burks <micke...@chromium.org>
Gerrit-Comment-Date: Fri, 17 Jul 2026 23:54:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jul 18, 2026, 3:07:31 PM (17 hours ago) Jul 18
to Mickey Burks, Justin DeWitt, David Pennington, chromium...@chromium.org, dewitt...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[WebUI] Register ThemeSource explicitly, part 7.

In this part adding ThemeSource registration in
- Glic

For details, refer to go/chrome-webui-explicit-theme-source-analysis
Bug: 40757220
Change-Id: I4f489ac8c0ccf7e660b3a1608fd921fb7ca7368a
Reviewed-by: David Pennington <dpen...@chromium.org>
Reviewed-by: Justin DeWitt <dew...@chromium.org>
Commit-Queue: Mickey Burks <micke...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1664382}
Files:
  • M chrome/browser/glic/BUILD.gn
  • M chrome/browser/glic/host/glic_ui.cc
  • M chrome/browser/ui/webui/BUILD.gn
Change size: S
Delta: 3 files changed, 13 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by David Pennington, +1 by Justin DeWitt
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4f489ac8c0ccf7e660b3a1608fd921fb7ca7368a
Gerrit-Change-Number: 8104771
Gerrit-PatchSet: 2
Gerrit-Owner: Mickey Burks <micke...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: David Pennington <dpen...@chromium.org>
Gerrit-Reviewer: Justin DeWitt <dew...@chromium.org>
Gerrit-Reviewer: Mickey Burks <micke...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages