Convert RAW_PTR_EXCLUSION to raw_ptr<T, kUnprotectedInRelease> in extensions/browser [chromium/src : main]

0 views
Skip to first unread message

Keishi Hattori (Gerrit)

unread,
Jul 7, 2026, 11:56:18 PM (2 days ago) Jul 7
to Tim, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Tim

Keishi Hattori has uploaded the change for review

Keishi Hattori would like Tim to review this change.

Commit message

Convert RAW_PTR_EXCLUSION to raw_ptr<T, kUnprotectedInRelease> in extensions/browser

This replaces RAW_PTR_EXCLUSION with raw_ptr<T, kUnprotectedInRelease> in
extensions/browser to provide better safety in certain builds while avoiding
performance overhead in release builds.

This CL was uploaded by git cl split.

This CL was uploaded by git cl split.

R=tjud...@chromium.org
Bug: 382291410
Change-Id: I251646e1c06b9f884418cc67a0c00a9bad1b80cb

Change diff


Change information

Files:
  • M extensions/browser/lazy_context_task_queue.h
Change size: S
Delta: 1 file changed, 12 insertions(+), 9 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Tim
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I251646e1c06b9f884418cc67a0c00a9bad1b80cb
Gerrit-Change-Number: 8062607
Gerrit-PatchSet: 1
Gerrit-Owner: Keishi Hattori <kei...@chromium.org>
Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
Gerrit-Reviewer: Tim <tjud...@chromium.org>
Gerrit-Attention: Tim <tjud...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Keishi Hattori (Gerrit)

unread,
Jul 8, 2026, 12:24:43 AM (yesterday) Jul 8
to Tim, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Tim

Keishi Hattori voted and added 1 comment

Votes added by Keishi Hattori

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Keishi Hattori . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Tim
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I251646e1c06b9f884418cc67a0c00a9bad1b80cb
Gerrit-Change-Number: 8062607
Gerrit-PatchSet: 2
Gerrit-Owner: Keishi Hattori <kei...@chromium.org>
Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
Gerrit-Reviewer: Tim <tjud...@chromium.org>
Gerrit-Attention: Tim <tjud...@chromium.org>
Gerrit-Comment-Date: Wed, 08 Jul 2026 04:24:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Tim (Gerrit)

unread,
Jul 8, 2026, 5:20:24 PM (yesterday) Jul 8
to Keishi Hattori, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Keishi Hattori

Tim added 3 comments

Patchset-level comments
Tim . resolved

Thanks Keishi, just one question around if the performance statements of the comments being changed with this still hold true with the change.

Commit Message
Line 9, Patchset 2 (Latest):This replaces RAW_PTR_EXCLUSION with raw_ptr<T, kUnprotectedInRelease> in

extensions/browser to provide better safety in certain builds while avoiding
performance overhead in release builds.
Tim . unresolved

nit: Line wrapping.

File extensions/browser/lazy_context_task_queue.h
Line 35, Patchset 2 (Latest): // `render_process_host` uses kUnprotectedInRelease for performance reasons
// (based on analysis of sampling profiler data).
Tim . unresolved

Just to double check, using `raw_ptr<T, kUnprotectedInRelease>` still results in the performance protections this was getting previously by not using raw_ptr, right?

Open in Gerrit

Related details

Attention is currently required from:
  • Keishi Hattori
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I251646e1c06b9f884418cc67a0c00a9bad1b80cb
    Gerrit-Change-Number: 8062607
    Gerrit-PatchSet: 2
    Gerrit-Owner: Keishi Hattori <kei...@chromium.org>
    Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
    Gerrit-Reviewer: Tim <tjud...@chromium.org>
    Gerrit-Attention: Keishi Hattori <kei...@chromium.org>
    Gerrit-Comment-Date: Wed, 08 Jul 2026 21:20:01 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Keishi Hattori (Gerrit)

    unread,
    7:41 AM (12 hours ago) 7:41 AM
    to Tim, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
    Attention needed from Tim

    Keishi Hattori voted and added 2 comments

    Votes added by Keishi Hattori

    Auto-Submit+1

    2 comments

    Commit Message
    Line 9, Patchset 2:This replaces RAW_PTR_EXCLUSION with raw_ptr<T, kUnprotectedInRelease> in

    extensions/browser to provide better safety in certain builds while avoiding
    performance overhead in release builds.
    Tim . resolved

    nit: Line wrapping.

    Keishi Hattori

    Done

    File extensions/browser/lazy_context_task_queue.h
    Line 35, Patchset 2: // `render_process_host` uses kUnprotectedInRelease for performance reasons

    // (based on analysis of sampling profiler data).
    Tim . resolved

    Just to double check, using `raw_ptr<T, kUnprotectedInRelease>` still results in the performance protections this was getting previously by not using raw_ptr, right?

    Keishi Hattori

    Right, on release builds this will use RawPtrNoopImpl and the performance will be the same as a raw pointer.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Tim
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I251646e1c06b9f884418cc67a0c00a9bad1b80cb
      Gerrit-Change-Number: 8062607
      Gerrit-PatchSet: 2
      Gerrit-Owner: Keishi Hattori <kei...@chromium.org>
      Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
      Gerrit-Reviewer: Tim <tjud...@chromium.org>
      Gerrit-Attention: Tim <tjud...@chromium.org>
      Gerrit-Comment-Date: Thu, 09 Jul 2026 11:41:02 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Tim <tjud...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Tim (Gerrit)

      unread,
      1:22 PM (6 hours ago) 1:22 PM
      to Keishi Hattori, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
      Attention needed from Keishi Hattori

      Tim voted and added 1 comment

      Votes added by Tim

      Code-Review+1
      Commit-Queue+2

      1 comment

      Patchset-level comments
      File-level comment, Patchset 3 (Latest):
      Tim . resolved

      Thanks for confirming that. LGTM!

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Keishi Hattori
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I251646e1c06b9f884418cc67a0c00a9bad1b80cb
      Gerrit-Change-Number: 8062607
      Gerrit-PatchSet: 3
      Gerrit-Owner: Keishi Hattori <kei...@chromium.org>
      Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
      Gerrit-Reviewer: Tim <tjud...@chromium.org>
      Gerrit-Attention: Keishi Hattori <kei...@chromium.org>
      Gerrit-Comment-Date: Thu, 09 Jul 2026 17:22:23 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      2:44 PM (5 hours ago) 2:44 PM
      to Keishi Hattori, Tim, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      Convert RAW_PTR_EXCLUSION to raw_ptr<T, kUnprotectedInRelease> in extensions/browser


      This replaces RAW_PTR_EXCLUSION with raw_ptr<T, kUnprotectedInRelease>
      in extensions/browser to provide better safety in certain builds while
      avoiding performance overhead in release builds.

      This CL was uploaded by git cl split.

      R=tjud...@chromium.org
      Bug: 501113069
      Change-Id: I251646e1c06b9f884418cc67a0c00a9bad1b80cb
      Auto-Submit: Keishi Hattori <kei...@chromium.org>
      Reviewed-by: Tim <tjud...@chromium.org>
      Commit-Queue: Tim <tjud...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1659729}
      Files:
      • M extensions/browser/lazy_context_task_queue.h
      Change size: S
      Delta: 1 file changed, 12 insertions(+), 9 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Tim
       Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      


       Gerrit-MessageType: merged 
      

       Gerrit-Project: chromium/src 
      

       Gerrit-Branch: main 
      

       Gerrit-Change-Id: I251646e1c06b9f884418cc67a0c00a9bad1b80cb 
      

       Gerrit-Change-Number: 8062607 
      

       Gerrit-PatchSet: 4 
      

       Gerrit-Owner: Keishi Hattori <kei...@chromium.org> 
      

       Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com> 
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages