Add RunSkill API boilerplate code to skill service [chromium/src : main]

[Howard Chang (Gerrit)]

Howard Chang added 1 comment

File components/skills/internal/skills_service_impl.cc

Line 24, Patchset 2 (Latest): : browser_context_(browser_context) {

Howard Chang . resolved

The browser context is needed to open up glic as shown in the demo here: https://chromium-review.googlesource.com/c/chromium/src/+/7397669/5/chrome/browser/ui/webui/skills/skills_page_handler.cc

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I4f203f54a4875baf27afd42d5d26277f5de62e57

Gerrit-Change-Number: 7457940

Gerrit-PatchSet: 2

Gerrit-Owner: Howard Chang <howa...@google.com>

Gerrit-Reviewer: Howard Chang <howa...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Mon, 12 Jan 2026 23:22:39 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Howard Chang (Gerrit)]

Attention needed from Howard Chang, Rushan Suleymanov and Yiming Zhou

Howard Chang voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

• Howard Chang
• Rushan Suleymanov
• Yiming Zhou

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I4f203f54a4875baf27afd42d5d26277f5de62e57

Gerrit-Change-Number: 7457940

Gerrit-PatchSet: 2

Gerrit-Owner: Howard Chang <howa...@google.com>

Gerrit-Reviewer: Howard Chang <howa...@google.com>

Gerrit-Reviewer: Rushan Suleymanov <rus...@google.com>

Gerrit-Reviewer: Yiming Zhou <uwyi...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Po Hu <p...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Howard Chang <howa...@google.com>

Gerrit-Attention: Rushan Suleymanov <rus...@google.com>

Gerrit-Attention: Yiming Zhou <uwyi...@google.com>

Gerrit-Comment-Date: Mon, 12 Jan 2026 23:24:18 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Po Hu (Gerrit)]

Attention needed from Howard Chang, Rushan Suleymanov and Yiming Zhou

Po Hu added 1 comment

File components/skills/internal/skills_service_impl.cc

Line 24, Patchset 2 (Latest): : browser_context_(browser_context) {

Po Hu . unresolved

browser_context_ is used for toggling the glic side panel. Abe and I discussed earlier and decided to create a chrome side skills service to include chrome UI related methods. please bring this up in tomorrow's eng sync. for now, it'd be fine to add the skillToInvoke field and update method.

Open in Gerrit

Related details

Attention is currently required from:

• Howard Chang
• Rushan Suleymanov
• Yiming Zhou

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I4f203f54a4875baf27afd42d5d26277f5de62e57

Gerrit-Change-Number: 7457940

Gerrit-PatchSet: 2

Gerrit-Owner: Howard Chang <howa...@google.com>

Gerrit-Reviewer: Howard Chang <howa...@google.com>

Gerrit-Reviewer: Rushan Suleymanov <rus...@google.com>

Gerrit-Reviewer: Yiming Zhou <uwyi...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Po Hu <p...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Howard Chang <howa...@google.com>

Gerrit-Attention: Rushan Suleymanov <rus...@google.com>

Gerrit-Attention: Yiming Zhou <uwyi...@google.com>

Gerrit-Comment-Date: Mon, 12 Jan 2026 23:42:25 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Rushan Suleymanov (Gerrit)]

Attention needed from Howard Chang and Yiming Zhou

Rushan Suleymanov added 2 comments

File components/skills/internal/skills_service_impl.h

Line 44, Patchset 2 (Latest): void RunSkill(const std::string& id) override;

Rushan Suleymanov . unresolved

nit: string_view?

Line 33, Patchset 2 (Latest): SkillsServiceImpl(version_info::Channel channel,

Rushan Suleymanov . unresolved

Please add a comment that `browser_context must not be null and outlive this object`. Also is this needed now, could it be added later once used?

Open in Gerrit

Related details

Attention is currently required from:

• Howard Chang
• Yiming Zhou

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I4f203f54a4875baf27afd42d5d26277f5de62e57

Gerrit-Change-Number: 7457940

Gerrit-PatchSet: 2

Gerrit-Owner: Howard Chang <howa...@google.com>

Gerrit-Reviewer: Howard Chang <howa...@google.com>

Gerrit-Reviewer: Rushan Suleymanov <rus...@google.com>

Gerrit-Reviewer: Yiming Zhou <uwyi...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Po Hu <p...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Howard Chang <howa...@google.com>

Gerrit-Attention: Yiming Zhou <uwyi...@google.com>

Gerrit-Comment-Date: Tue, 13 Jan 2026 07:50:52 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Howard Chang (Gerrit)]

Attention needed from Po Hu, Rushan Suleymanov and Yiming Zhou

Howard Chang added 3 comments

File components/skills/internal/skills_service_impl.h

Line 44, Patchset 2 (Latest): void RunSkill(const std::string& id) override;

Rushan Suleymanov . resolved

nit: string_view?

Howard Chang

Acknowledged

Line 33, Patchset 2 (Latest): SkillsServiceImpl(version_info::Channel channel,

Rushan Suleymanov . resolved

Please add a comment that `browser_context must not be null and outlive this object`. Also is this needed now, could it be added later once used?

Howard Chang

Acknowledged

File components/skills/internal/skills_service_impl.cc

Line 24, Patchset 2 (Latest): : browser_context_(browser_context) {

Po Hu . resolved

browser_context_ is used for toggling the glic side panel. Abe and I discussed earlier and decided to create a chrome side skills service to include chrome UI related methods. please bring this up in tomorrow's eng sync. for now, it'd be fine to add the skillToInvoke field and update method.

Howard Chang

I will abandon this cl for now. As we discussed offline, this logic should be put inside ChromeSkillsService not in the skillsService.

Open in Gerrit

Related details

Attention is currently required from:

• Po Hu
• Rushan Suleymanov
• Yiming Zhou

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I4f203f54a4875baf27afd42d5d26277f5de62e57

Gerrit-Change-Number: 7457940

Gerrit-PatchSet: 2

Gerrit-Owner: Howard Chang <howa...@google.com>

Gerrit-Reviewer: Howard Chang <howa...@google.com>

Gerrit-Reviewer: Rushan Suleymanov <rus...@google.com>

Gerrit-Reviewer: Yiming Zhou <uwyi...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Po Hu <p...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Rushan Suleymanov <rus...@google.com>

Gerrit-Attention: Yiming Zhou <uwyi...@google.com>

Gerrit-Attention: Po Hu <p...@google.com>

Gerrit-Comment-Date: Tue, 13 Jan 2026 19:48:51 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Rushan Suleymanov <rus...@google.com>

Comment-In-Reply-To: Po Hu <p...@google.com>

[Howard Chang (Gerrit)]

Howard Chang abandoned this change.

View Change

Abandoned

Howard Chang abandoned this change

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: abandon