policy: Decouple LocalUserFilesPolicyObserver from g_browser_process [chromium/src : main]
0 views
Skip to first unread message
Jun Ishiguro (Gerrit)
5:19 AM (7 hours ago) 5:19 AM
to Hidehiko Abe, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, chromium-a...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org
Attention needed from Hidehiko Abe
Jun Ishiguro added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File chrome/browser/ash/extensions/file_manager/event_router.cc
Line 597, Patchset 1 (Latest):
// TODO(crbug.com/404131876): Avoid using g_browser_process.Jun Ishiguro . resolved
In this CL, I use TODOs to keep CL small. These TODOs will be addressed in separate CLs.
Related details
Attention is currently required from:
- Hidehiko Abe
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hidehiko Abe (Gerrit)
8:12 AM (4 hours ago) 8:12 AM
to Jun Ishiguro, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, chromium-a...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org
Attention needed from Jun Ishiguro
Hidehiko Abe voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jun Ishiguro
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jun Ishiguro (Gerrit)
9:39 AM (3 hours ago) 9:39 AM
to Hidehiko Abe, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, chromium-a...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org
Jun Ishiguro voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jun Ishiguro
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Jun Ishiguro . resolved
Thank you for the review! Submitting the chain.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
9:44 AM (3 hours ago) 9:44 AM
to Jun Ishiguro, Hidehiko Abe, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Enterprise Policy Reviews, chromium-a...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
policy: Decouple LocalUserFilesPolicyObserver from g_browser_process
Replace direct access to g_browser_process->local_state() in
LocalUserFilesPolicyObserver with explicit constructor dependency
injection of PrefService.
TAG=agy
Bug: b:404133022
Change-Id: I6f5c143d17044e474e11bddf02f2c6a3399cb7fa
Reviewed-by: Hidehiko Abe <hide...@chromium.org>
Commit-Queue: Jun Ishiguro <ju...@google.com>
Cr-Commit-Position: refs/heads/main@{#1658698}
Files:
- M chrome/browser/ash/extensions/file_manager/event_router.cc
- M chrome/browser/ash/file_manager/DEPS
- M chrome/browser/ash/file_manager/volume_manager.cc
- M chrome/browser/ash/policy/skyvault/local_files_cleanup.cc
- M chrome/browser/ash/policy/skyvault/local_files_migration_manager.cc
- M chrome/browser/ash/policy/skyvault/local_user_files_policy_observer.cc
- M chrome/browser/ash/policy/skyvault/local_user_files_policy_observer.h
- M chrome/browser/ash/policy/skyvault/local_user_files_policy_observer_browsertest.cc
Change size: M
Delta: 8 files changed, 47 insertions(+), 20 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Hidehiko Abe
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages