[ActorOTP] Allow PSL sender match for login flows [chromium/src : main]
0 views
Skip to first unread message
Ioana Treib (Gerrit)
Jul 23, 2026, 12:42:14 PM (20 hours ago) Jul 23
to Kevin McNee, Trang Mai, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Kevin McNee and Trang Mai
Ioana Treib added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Ioana Treib . resolved
Kevin, please take a look at chrome/browser/actor/tools/*.
Trang, please take a look at the rest.
Thank you,
Ioana
Related details
Attention is currently required from:
- Kevin McNee
- Trang Mai
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Trang Mai (Gerrit)
Jul 23, 2026, 3:40:37 PM (17 hours ago) Jul 23
to Ioana Treib, Kevin McNee, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Ioana Treib and Kevin McNee
Trang Mai voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Ioana Treib
- Kevin McNee
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin McNee (Gerrit)
Jul 23, 2026, 7:32:43 PM (13 hours ago) Jul 23
to Ioana Treib, Trang Mai, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Ioana Treib
Kevin McNee voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Ioana Treib
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ioana Treib (Gerrit)
4:43 AM (4 hours ago) 4:43 AM
to Kevin McNee, Trang Mai, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, mfoltz+wa...@chromium.org
Ioana Treib voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ioana Treib
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
4:52 AM (4 hours ago) 4:52 AM
to Ioana Treib, Kevin McNee, Trang Mai, chromium...@chromium.org, browser-comp...@chromium.org, mfoltz+wa...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[ActorOTP] Allow PSL sender match for login flows
We know that the frame to fill is trustworthy since a login was
allowed there.
Bug: 526619811,526615169
Change-Id: I264d12850f09bbdfdd7136e502a3c7e6282a05b6
Reviewed-by: Kevin McNee <mc...@chromium.org>
Reviewed-by: Trang Mai <tra...@google.com>
Commit-Queue: Ioana Treib <ioa...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1667722}
Files:
- M chrome/browser/actor/tools/attempt_otp_filling_tool.cc
- M chrome/browser/actor/tools/attempt_otp_filling_tool_unittest.cc
- M chrome/browser/autofill/actor/one_time_tokens/actor_one_time_token_filling_service.h
- M chrome/browser/autofill/actor/one_time_tokens/actor_one_time_token_filling_service_impl.cc
- M chrome/browser/autofill/actor/one_time_tokens/actor_one_time_token_filling_service_impl.h
- M chrome/browser/autofill/actor/one_time_tokens/actor_one_time_token_filling_service_impl_unittest.cc
Change size: M
Delta: 6 files changed, 108 insertions(+), 28 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kevin McNee, +1 by Trang Mai
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
luci-bisection@appspot.gserviceaccount.com (Gerrit)
5:08 AM (3 hours ago) 5:08 AM
to Chromium LUCI CQ, Ioana Treib, Kevin McNee, Trang Mai, chromium...@chromium.org, browser-comp...@chromium.org, mfoltz+wa...@chromium.org
Message from luci-bi...@appspot.gserviceaccount.com![]( "Open in Gerrit")
LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8675408020184038977
A revert for this change was not created because the builder that this CL broke is not watched by gardeners, therefore less important. You can consider revert this CL, fix forward or let builder owners resolve it themselves.
Sample failed build: https://ci.chromium.org/b/8675408020184038977
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F8103527&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8675408020184038977&type=BUG
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
luci-bisection@appspot.gserviceaccount.com (Gerrit)
5:10 AM (3 hours ago) 5:10 AM
to Chromium LUCI CQ, Ioana Treib, Kevin McNee, Trang Mai, chromium...@chromium.org, browser-comp...@chromium.org, mfoltz+wa...@chromium.org
luci-bi...@appspot.gserviceaccount.com has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages